{"id":11136,"url":"https://patchwork.libcamera.org/api/1.1/patches/11136/?format=json","web_url":"https://patchwork.libcamera.org/patch/11136/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210204093457.6879-7-david.plowman@raspberrypi.com>","date":"2021-02-04T09:34:56","name":"[libcamera-devel,6/7] ipa: raspberrypi: lux: Supply missing method and remove atomic variable","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"90b05d6336f6b9f56d6e23de349fc7fd008fc43d","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11136/mbox/","series":[{"id":1649,"url":"https://patchwork.libcamera.org/api/1.1/series/1649/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1649","date":"2021-02-04T09:34:50","name":"Raspberry Pi IPA maintenance","version":1,"mbox":"https://patchwork.libcamera.org/series/1649/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11136/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11136/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 00C72BD162\n\tfor ;\n\tThu, 4 Feb 2021 09:35:10 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C066B6141D;\n\tThu, 4 Feb 2021 10:35:09 +0100 (CET)","from mail-wr1-x432.google.com (mail-wr1-x432.google.com\n\t[IPv6:2a00:1450:4864:20::432])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 780E861414\n\tfor ;\n\tThu, 4 Feb 2021 10:35:06 +0100 (CET)","by mail-wr1-x432.google.com with SMTP id m13so2616510wro.12\n\tfor ;\n\tThu, 04 Feb 2021 01:35:06 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tg16sm5280580wmi.30.2021.02.04.01.35.05\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Feb 2021 01:35:05 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"p4imPPgj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=W0ndmTmLHTj+yjrjIbV9XFfDITNN9s+r1ID3eo4YSJY=;\n\tb=p4imPPgjZfCtEMbzauzuSbKgbpmYv6jlBy//gfQkxCxlWLbRFcfrr7FtnVrN4vGgot\n\t63Vqw1TdIU+nwOSnsiFgh2dzayJBCmS07wInEdheY/FaO2DGyqXVUcogFmzWqxD6m2gu\n\tDOgfXOZiMEGQ0ouPVG0v2M4XUnyA2aJPdK5aA3NI7hnzsFoHAniXAODpBfX3+ZaIBNW7\n\txQxVCKuPz/YhtI1UrcpJoovNiCAzjt78muz0eHFGzmXrS5g7yQlC+go+Fi7zKGWzpnde\n\tby8fZRMVtPZGq1j6tAIkio3TQjkxmI+98Z2iBr1qPYnYbhS03oyqNFJYz+QIMansBKF5\n\tiRaQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=W0ndmTmLHTj+yjrjIbV9XFfDITNN9s+r1ID3eo4YSJY=;\n\tb=Pftn5ZOP2O8xOUGpN+PsT9rUOG5ItAOq4MWHM5MCyywF2RfX1IW4fyBzkGVc5WzE2b\n\tNpVV6qCWYR92S6Ggn/rwAzEX9j5y5V/Sz9lsSKkn19NbkNix9pT4Y9O5WIF/JjE6hyOE\n\tSlOcTWi8GKSnGLK0NBmh+nMJJ3Rgh3kdD5/qfWi0zt6ayAnUJNC5ctX6F0+Udclo2Ic0\n\t4wFJ0d7bVoga/e7UWGPdeHs5ezTeeJeBgEdJdFkof8c23ckrfT3aDHdbf0v6BBlEQkoW\n\tJN4SMdbkEzbxV400ITN7eN7Qp9frgkbwtWDaYAk4d/6jfqQM59ZwXMmHrOYafbU3wDqs\n\tT20Q==","X-Gm-Message-State":"AOAM532YipSJY/zIaZyBaxIuKQe40SeoNbZLph2ENyaWhCoRgMSpWlrX\n\tdLFrVKdF5qPj5PzKj4e8nZRpusIZnrp6gmSK","X-Google-Smtp-Source":"ABdhPJzyi8XSi3yLTYPUAZMtM61Drzdxr6uyaoKx6HMmxB1nRsYeC0Meoa4On2W4Pt0sgEwbczz/Qw==","X-Received":"by 2002:a5d:640c:: with SMTP id\n\tz12mr8280944wru.342.1612431305970; \n\tThu, 04 Feb 2021 01:35:05 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 4 Feb 2021 09:34:56 +0000","Message-Id":"<20210204093457.6879-7-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20210204093457.6879-1-david.plowman@raspberrypi.com>","References":"<20210204093457.6879-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 6/7] ipa: raspberrypi: lux: Supply missing\n\tmethod and remove atomic variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Supply the missing SetCurrentAperture() method (even though no one is\ncalling it). If we did call it, it would be called synchronously so\nthe atomic variable is not required.\n\nSigned-off-by: David Plowman \n---\n src/ipa/raspberrypi/controller/rpi/lux.cpp | 5 +++++\n src/ipa/raspberrypi/controller/rpi/lux.hpp | 3 +--\n 2 files changed, 6 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/lux.cpp b/src/ipa/raspberrypi/controller/rpi/lux.cpp\nindex aefd92d4..f74381ca 100644\n--- a/src/ipa/raspberrypi/controller/rpi/lux.cpp\n+++ b/src/ipa/raspberrypi/controller/rpi/lux.cpp\n@@ -46,6 +46,11 @@ void Lux::Read(boost::property_tree::ptree const ¶ms)\n \tcurrent_aperture_ = reference_aperture_;\n }\n \n+void Lux::SetCurrentAperture(double aperture)\n+{\n+\tcurrent_aperture_ = aperture;\n+}\n+\n void Lux::Prepare(Metadata *image_metadata)\n {\n \tstd::unique_lock lock(mutex_);\ndiff --git a/src/ipa/raspberrypi/controller/rpi/lux.hpp b/src/ipa/raspberrypi/controller/rpi/lux.hpp\nindex 7b6c7258..f9090484 100644\n--- a/src/ipa/raspberrypi/controller/rpi/lux.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/lux.hpp\n@@ -6,7 +6,6 @@\n */\n #pragma once\n \n-#include \n #include \n \n #include \"../lux_status.h\"\n@@ -34,7 +33,7 @@ private:\n \tdouble reference_aperture_; // units of 1/f\n \tdouble reference_Y_; // out of 65536\n \tdouble reference_lux_;\n-\tstd::atomic current_aperture_;\n+\tdouble current_aperture_;\n \tLuxStatus status_;\n \tstd::mutex mutex_;\n };\n","prefixes":["libcamera-devel","6/7"]}