{"id":11135,"url":"https://patchwork.libcamera.org/api/1.1/patches/11135/?format=json","web_url":"https://patchwork.libcamera.org/patch/11135/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210204093457.6879-6-david.plowman@raspberrypi.com>","date":"2021-02-04T09:34:55","name":"[libcamera-devel,5/7] ipa: raspberrypi: noise: Remove unnecessary atomic variable","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a7ad39e645d2a9de64f009903e82d6aec747560f","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11135/mbox/","series":[{"id":1649,"url":"https://patchwork.libcamera.org/api/1.1/series/1649/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1649","date":"2021-02-04T09:34:50","name":"Raspberry Pi IPA maintenance","version":1,"mbox":"https://patchwork.libcamera.org/series/1649/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11135/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11135/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 90604BD162\n\tfor ;\n\tThu, 4 Feb 2021 09:35:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5CE1961429;\n\tThu, 4 Feb 2021 10:35:09 +0100 (CET)","from mail-wr1-x429.google.com (mail-wr1-x429.google.com\n\t[IPv6:2a00:1450:4864:20::429])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF02961404\n\tfor ;\n\tThu, 4 Feb 2021 10:35:05 +0100 (CET)","by mail-wr1-x429.google.com with SMTP id g10so2700777wrx.1\n\tfor ;\n\tThu, 04 Feb 2021 01:35:05 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tg16sm5280580wmi.30.2021.02.04.01.35.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 04 Feb 2021 01:35:04 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"tYGj8P8X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=pP7sGJGC3/Dlj6wlhh7yuZ9LtQ3CKVVkcL3Zmsk3Bd0=;\n\tb=tYGj8P8XP8kSfiWuBJzozd0Fu6aM8rxqfuu9RAMQ3GVQil+6TDphOFy6RHBdBkMl0n\n\tIuLqGOu0XLtFZvHVqM3aGnVKs+Oe9lrJJOX2+rG3Nbb8xekp54i//K9XGxg6C5gdQ0Ju\n\tdo5MKZ7fRwAD4f7YBmwVSqzwe8ItxxllzJVK/tNeo1Lj52zy+Y1vTZdzYKOnyZo9mUoo\n\tt1Bhdz6LB7KITeoARZQRLIKv/L+E3t0nJlMR7UB1LYPM5w6BlYUlRfeOFvZeJXorQSzu\n\tsV7fqWzmMQKOH2pQm07Jklv1XxIDMxb+MmaKo/JPYk9/eHHCXP+plsgC2wmmk40dyrgY\n\td4rw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=pP7sGJGC3/Dlj6wlhh7yuZ9LtQ3CKVVkcL3Zmsk3Bd0=;\n\tb=Fj+vZs1ElWIXuUtRiL+meHQT2ygWQT7EU03+hZha+iBMeBRaKX1cV+rgbih37GxtwP\n\t2osQDcwa6iwfye35DZRZVGWCEvvdyBpEeMpQ3jgm0qF+Aqdh6wPxTKoXVyGI7lnLaMUx\n\tGNRKQpwWgfjzFYQ9fJB2H895uPRiDPi7MNZBVP54BsxJ4o6MwdE3spNUxtBTcIRYwOZN\n\tDHBHLRZovVLOpzwo4x+y9v9Xd1PzQRWLYiaUI5uxDQrXJpMnHyblg6kWLKvU2Q8eopzr\n\t0caKEzP9CijRZ5FVrHBjVt6Y6KtCLHn9OsSt1v0kbuZBtf8QeTLtS1CXB+8VKCUw2HdT\n\taN3g==","X-Gm-Message-State":"AOAM532Cw5btRRlT7w9Q62OMigIVBHBfFXMsZ2MPWc19H1+TIuDKwVto\n\tc1pUC7NxAlPHyyVilQr2YV2RHe9fQBcwFEH6","X-Google-Smtp-Source":"ABdhPJzAGf8vcD1OXOO+IfSnyKQzCJ3KeLeibnREJTLfh0256x7k84BrqSyEx13J00sbM5K1D6NEdA==","X-Received":"by 2002:adf:fc88:: with SMTP id g8mr8015694wrr.259.1612431305207;\n\tThu, 04 Feb 2021 01:35:05 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 4 Feb 2021 09:34:55 +0000","Message-Id":"<20210204093457.6879-6-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20210204093457.6879-1-david.plowman@raspberrypi.com>","References":"<20210204093457.6879-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 5/7] ipa: raspberrypi: noise: Remove\n\tunnecessary atomic variable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"mode_factor_ does not need to be atomic - it is set by SwitchMode()\nwhich runs synchronously.\n\nSigned-off-by: David Plowman \n---\n src/ipa/raspberrypi/controller/rpi/noise.hpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/raspberrypi/controller/rpi/noise.hpp b/src/ipa/raspberrypi/controller/rpi/noise.hpp\nindex 6f6e0be9..1c9de5c8 100644\n--- a/src/ipa/raspberrypi/controller/rpi/noise.hpp\n+++ b/src/ipa/raspberrypi/controller/rpi/noise.hpp\n@@ -26,7 +26,7 @@ private:\n \t// the noise profile for analogue gain of 1.0\n \tdouble reference_constant_;\n \tdouble reference_slope_;\n-\tstd::atomic mode_factor_;\n+\tdouble mode_factor_;\n };\n \n } // namespace RPiController\n","prefixes":["libcamera-devel","5/7"]}