{"id":11124,"url":"https://patchwork.libcamera.org/api/1.1/patches/11124/?format=json","web_url":"https://patchwork.libcamera.org/patch/11124/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210203162600.206297-8-jacopo@jmondi.org>","date":"2021-02-03T16:26:00","name":"[libcamera-devel,7/7] android: camera_device: Report HOT_PIXEL_MAP_MODE as OFF","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9dd81d31bcbfcc2ed378fd39675840f3c2150a2a","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11124/mbox/","series":[{"id":1645,"url":"https://patchwork.libcamera.org/api/1.1/series/1645/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1645","date":"2021-02-03T16:25:53","name":"android: Report all the missing metadata tags","version":1,"mbox":"https://patchwork.libcamera.org/series/1645/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11124/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11124/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09657BD162\n\tfor ;\n\tWed, 3 Feb 2021 16:25:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C523668460;\n\tWed, 3 Feb 2021 17:25:48 +0100 (CET)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1898568446\n\tfor ;\n\tWed, 3 Feb 2021 17:25:46 +0100 (CET)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id DC1E620000C\n\tfor ;\n\tWed, 3 Feb 2021 16:25:45 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 3 Feb 2021 17:26:00 +0100","Message-Id":"<20210203162600.206297-8-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.30.0","In-Reply-To":"<20210203162600.206297-1-jacopo@jmondi.org>","References":"<20210203162600.206297-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 7/7] android: camera_device: Report\n\tHOT_PIXEL_MAP_MODE as OFF","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CaptureResultTest#testCameraCaptureResultAllKeys enforces the\npresence of the ANDROID_STATISTICS_HOT_PIXEL_MAP_MODE result\nmetadata.\n\nReport ANDROID_STATISTICS_HOT_PIXEL_MAP_MODE_OFF as the Camera HAL\ndoes not support the generation of an hot pixel correction map.\n\nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 9 +++++++--\n 1 file changed, 7 insertions(+), 2 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 2b065d57febb..df5e295656d7 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -708,7 +708,7 @@ std::tuple CameraDevice::calculateStaticMetadataSize()\n \t * Currently: 53 entries, 846 bytes of static metadata\n \t */\n \tuint32_t numEntries = 53;\n-\tuint32_t byteSize = 858;\n+\tuint32_t byteSize = 862;\n \n \t/*\n \t * Calculate space occupation in bytes for dynamically built metadata\n@@ -1285,6 +1285,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\tANDROID_SENSOR_TIMESTAMP,\n \t\tANDROID_STATISTICS_FACE_DETECT_MODE,\n \t\tANDROID_STATISTICS_LENS_SHADING_MAP_MODE,\n+\t\tANDROID_STATISTICS_HOT_PIXEL_MAP_MODE,\n \t\tANDROID_STATISTICS_SCENE_FLICKER,\n \t};\n \tstaticMetadata_->addEntry(ANDROID_REQUEST_AVAILABLE_RESULT_KEYS,\n@@ -1966,7 +1967,7 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n \t * Total bytes for JPEG metadata: 82\n \t */\n \tstd::unique_ptr resultMetadata =\n-\t\tstd::make_unique(43, 165);\n+\t\tstd::make_unique(44, 166);\n \tif (!resultMetadata->isValid()) {\n \t\tLOG(HAL, Error) << \"Failed to allocate static metadata\";\n \t\treturn nullptr;\n@@ -2073,6 +2074,10 @@ CameraDevice::getResultMetadata(Camera3RequestDescriptor *descriptor,\n \tresultMetadata->addEntry(ANDROID_STATISTICS_LENS_SHADING_MAP_MODE,\n \t\t\t\t &value, 1);\n \n+\tvalue = ANDROID_STATISTICS_HOT_PIXEL_MAP_MODE_OFF;\n+\tresultMetadata->addEntry(ANDROID_STATISTICS_HOT_PIXEL_MAP_MODE,\n+\t\t\t\t &value, 1);\n+\n \tvalue = ANDROID_STATISTICS_SCENE_FLICKER_NONE;\n \tresultMetadata->addEntry(ANDROID_STATISTICS_SCENE_FLICKER,\n \t\t\t\t &value, 1);\n","prefixes":["libcamera-devel","7/7"]}