{"id":11121,"url":"https://patchwork.libcamera.org/api/1.1/patches/11121/?format=json","web_url":"https://patchwork.libcamera.org/patch/11121/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210203162600.206297-5-jacopo@jmondi.org>","date":"2021-02-03T16:25:57","name":"[libcamera-devel,4/7] android: camera_device: Report AF_MODE_OFF in template","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ead84da9b8b400afbea97d63151f4038452e1206","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11121/mbox/","series":[{"id":1645,"url":"https://patchwork.libcamera.org/api/1.1/series/1645/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1645","date":"2021-02-03T16:25:53","name":"android: Report all the missing metadata tags","version":1,"mbox":"https://patchwork.libcamera.org/series/1645/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11121/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11121/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A385BD163\n\tfor ;\n\tWed, 3 Feb 2021 16:25:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E34136845F;\n\tWed, 3 Feb 2021 17:25:47 +0100 (CET)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0EA7B68450\n\tfor ;\n\tWed, 3 Feb 2021 17:25:45 +0100 (CET)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id CE211200011\n\tfor ;\n\tWed, 3 Feb 2021 16:25:44 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 3 Feb 2021 17:25:57 +0100","Message-Id":"<20210203162600.206297-5-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.30.0","In-Reply-To":"<20210203162600.206297-1-jacopo@jmondi.org>","References":"<20210203162600.206297-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 4/7] android: camera_device: Report\n\tAF_MODE_OFF in template","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The CaptureResultTest#testCameraCaptureResultAllKeys CTS test\nenforces the presence of the auto focus mode in the preview\nrequest template.\n\nAdd the only supported mode AF_MODE_OFF in the generated template.\n\nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 5 ++++-\n 1 file changed, 4 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 27f6ec109da9..fdda43e9b4af 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1306,7 +1306,7 @@ CameraMetadata *CameraDevice::requestTemplatePreview()\n \t * \\todo Keep this in sync with the actual number of entries.\n \t * Currently: 20 entries, 35 bytes\n \t */\n-\tCameraMetadata *requestTemplate = new CameraMetadata(20, 35);\n+\tCameraMetadata *requestTemplate = new CameraMetadata(21, 36);\n \tif (!requestTemplate->isValid()) {\n \t\tdelete requestTemplate;\n \t\treturn nullptr;\n@@ -1339,6 +1339,9 @@ CameraMetadata *CameraDevice::requestTemplatePreview()\n \trequestTemplate->addEntry(ANDROID_CONTROL_AE_ANTIBANDING_MODE,\n \t\t\t\t &aeAntibandingMode, 1);\n \n+\tuint8_t afMode = ANDROID_CONTROL_AF_MODE_OFF;\n+\trequestTemplate->addEntry(ANDROID_CONTROL_AF_MODE, &afMode, 1);\n+\n \tuint8_t afTrigger = ANDROID_CONTROL_AF_TRIGGER_IDLE;\n \trequestTemplate->addEntry(ANDROID_CONTROL_AF_TRIGGER,\n \t\t\t\t &afTrigger, 1);\n","prefixes":["libcamera-devel","4/7"]}