{"id":11120,"url":"https://patchwork.libcamera.org/api/1.1/patches/11120/?format=json","web_url":"https://patchwork.libcamera.org/patch/11120/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210203162600.206297-4-jacopo@jmondi.org>","date":"2021-02-03T16:25:56","name":"[libcamera-devel,3/7] android: camera_device: Use AF_MODE_OFF in scene override","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"edaf0c0a47c1b16c03e5a810521d482b568a72da","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11120/mbox/","series":[{"id":1645,"url":"https://patchwork.libcamera.org/api/1.1/series/1645/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1645","date":"2021-02-03T16:25:53","name":"android: Report all the missing metadata tags","version":1,"mbox":"https://patchwork.libcamera.org/series/1645/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11120/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11120/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ECB56BD162\n\tfor ;\n\tWed, 3 Feb 2021 16:25:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BD0506845C;\n\tWed, 3 Feb 2021 17:25:45 +0100 (CET)","from relay12.mail.gandi.net (relay12.mail.gandi.net\n\t[217.70.178.232])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A4EA168447\n\tfor ;\n\tWed, 3 Feb 2021 17:25:44 +0100 (CET)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay12.mail.gandi.net (Postfix) with ESMTPSA id 7429F200002\n\tfor ;\n\tWed, 3 Feb 2021 16:25:44 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 3 Feb 2021 17:25:56 +0100","Message-Id":"<20210203162600.206297-4-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.30.0","In-Reply-To":"<20210203162600.206297-1-jacopo@jmondi.org>","References":"<20210203162600.206297-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 3/7] android: camera_device: Use\n\tAF_MODE_OFF in scene override","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The camera HAL does currently list AF_MODE_OFF as the only supported\nauto-focus mode in the ANDROID_CONTROL_AF_AVAILABLE_MODES static\nmetadata. For this reason reporting AF_MODE_AUTO as scene override\nis wrong.\n\nAt the moment scene override is disabled in the Camera HAL, but this\nis worth a fix nonetheless.\n\nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex cdc75b949206..27f6ec109da9 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -852,7 +852,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \tstd::vector sceneModesOverride = {\n \t\tANDROID_CONTROL_AE_MODE_ON,\n \t\tANDROID_CONTROL_AWB_MODE_AUTO,\n-\t\tANDROID_CONTROL_AF_MODE_AUTO,\n+\t\tANDROID_CONTROL_AF_MODE_OFF,\n \t};\n \tstaticMetadata_->addEntry(ANDROID_CONTROL_SCENE_MODE_OVERRIDES,\n \t\t\t\t sceneModesOverride.data(),\n","prefixes":["libcamera-devel","3/7"]}