{"id":1108,"url":"https://patchwork.libcamera.org/api/1.1/patches/1108/?format=json","web_url":"https://patchwork.libcamera.org/patch/1108/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190426150155.18652-3-laurent.pinchart@ideasonboard.com>","date":"2019-04-26T15:01:49","name":"[libcamera-devel,2/8] libcamera: event_dispatcher_poll: Fix bitwise test","commit_ref":"2eeb826f3fa294f4f980e3a62da4e96095355997","pull_url":null,"state":"accepted","archived":false,"hash":"a2a2efd13b8b2279ccd694f14f0ed8c28c68c461","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1108/mbox/","series":[{"id":271,"url":"https://patchwork.libcamera.org/api/1.1/series/271/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=271","date":"2019-04-26T15:01:47","name":"Fix clang compilation warnings and errors","version":1,"mbox":"https://patchwork.libcamera.org/series/271/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1108/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1108/checks/","tags":{},"headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0322D60E9C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Apr 2019 17:02:10 +0200 (CEST)","from pendragon.station (net-37-182-44-227.cust.vodafonedsl.it\n\t[37.182.44.227])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9972A54C\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 26 Apr 2019 17:02:09 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1556290929;\n\tbh=heOyTImYa5Vv7LOX2E+/yZQBGwhUuoN0exFMit7GV2A=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=CfRLVq8AxOdBqPBJjwDCpgqdU5pbIDEAAlyVd1H9ryKeYjx/EpgjTFwo60wSwwoEf\n\t91h/MXuBTb3UTJ6uHg4ORU2jgL8jIfRSG+jwr7w5x5/dLp5dsefU41cRdCXidSixfS\n\t3k2eb0opHSYru/pWge9p3K9/qNJAGNgOP6e9kxGQ=","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 26 Apr 2019 18:01:49 +0300","Message-Id":"<20190426150155.18652-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>","References":"<20190426150155.18652-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH 2/8] libcamera: event_dispatcher_poll: Fix\n\tbitwise test","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Fri, 26 Apr 2019 15:02:10 -0000"},"content":"Add missing parentheses to fix a bitwise test.\n\nSigned-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n---\n src/libcamera/event_dispatcher_poll.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/event_dispatcher_poll.cpp b/src/libcamera/event_dispatcher_poll.cpp\nindex 130b5e20ea09..1f0f352a8e0a 100644\n--- a/src/libcamera/event_dispatcher_poll.cpp\n+++ b/src/libcamera/event_dispatcher_poll.cpp\n@@ -210,7 +210,7 @@ int EventDispatcherPoll::poll(std::vector<struct pollfd> *pollfds)\n \n void EventDispatcherPoll::processInterrupt(const struct pollfd &pfd)\n {\n-\tif (!pfd.revents & POLLIN)\n+\tif (!(pfd.revents & POLLIN))\n \t\treturn;\n \n \tuint64_t value;\n","prefixes":["libcamera-devel","2/8"]}