{"id":11051,"url":"https://patchwork.libcamera.org/api/1.1/patches/11051/?format=json","web_url":"https://patchwork.libcamera.org/patch/11051/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210129111616.1047483-2-naush@raspberrypi.com>","date":"2021-01-29T11:16:12","name":"[libcamera-devel,v4,1/5] libcamera: camera_sensor: Make VBLANK mandatory","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"de015c3f7f6774f9259f31b8bcbbf5c6774d377f","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11051/mbox/","series":[{"id":1625,"url":"https://patchwork.libcamera.org/api/1.1/series/1625/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1625","date":"2021-01-29T11:16:11","name":"Raspberry Pi: FrameDurations control refinements","version":4,"mbox":"https://patchwork.libcamera.org/series/1625/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11051/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11051/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C117BD808\n\tfor ;\n\tFri, 29 Jan 2021 11:16:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3E75D683AA;\n\tFri, 29 Jan 2021 12:16:27 +0100 (CET)","from mail-wr1-x434.google.com (mail-wr1-x434.google.com\n\t[IPv6:2a00:1450:4864:20::434])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E6C75683A2\n\tfor ;\n\tFri, 29 Jan 2021 12:16:25 +0100 (CET)","by mail-wr1-x434.google.com with SMTP id m13so8432076wro.12\n\tfor ;\n\tFri, 29 Jan 2021 03:16:25 -0800 (PST)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tf14sm11324007wre.69.2021.01.29.03.16.22\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 29 Jan 2021 03:16:23 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"PhjfmVro\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=x05WP2jGPAHR3jvXFT93jDzxY90RnftgMznUPHjSXzM=;\n\tb=PhjfmVrosEtWrcb6JwldGS0FPuiYnEA+anMREJDA9YBMb5tD1LXHhFZGkj+31vBKBl\n\tcrkAcpivc0aWxDa+4AbUSAQBoNNcZWBzVcRtbwAsGFB5zi796bH+Hzz6YtwpZSPFM+xC\n\tFKsCiSJnTYvKUL35KUMj823ST+sxBRyeyJ+szIlLR8nQCtMzVBz5x4daYRXqf4jIF/1N\n\tNMxZbNmhV58V2N29b/BkTywmozq8alikDxlHx6f7gCfSwsZI/VgwCzWNxC7jaSwXLKuG\n\t3fh2togvCsf0MMW3fEU+L5c246YqzNsaEEPPgkoCAJeIyvYabbpKFlUqk03FdpqfVUAO\n\tKCdQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=x05WP2jGPAHR3jvXFT93jDzxY90RnftgMznUPHjSXzM=;\n\tb=uj8FO/pPSSGJh335SUCpccyvW2oW1L4DMkstSpnE7Q4rWXasQHFv1y7bssTqxeGYU2\n\t5ZQ5bpmIu4ReuQcSNCBeWQsdxLtboqCOp6/o3sWW6gX4Zyb1EpyMm+h5M6/ZR2Pssrwr\n\tIaCLyHbrWSFhZe9gPY6bl5vtvh/cSQ0XoGEx27ukjn8JLLT5cp+0qS8QhztYZHg6T23a\n\tegaEsO8DAq+Q3q/OAtrnmOZkfxf7DIOwGC5Ibk3H07npmJUZhG5CLi1HTCzg2XNRoaQx\n\tgU4RCXpdsEslhoCZw2Grn1Ouaq+6NSO3jO7B5u7K2dKjoiQ186Slbz8KUKVTR30WgPBG\n\tTCgA==","X-Gm-Message-State":"AOAM531bjxCq0V8espyBoWcZJ39+xm9pzCs2nWpNLbQRZDJBbWMM2Uy5\n\toGWQx3xuV5jTxBYv1N+8bV6m5EurZNWi5YLf","X-Google-Smtp-Source":"ABdhPJxFEvlzy38LE3dp1AwHGQkoun9SU/Rvuhirk6jtAUACosC1C1CZ6Dv414ayYNUAuuBQTAVtQQ==","X-Received":"by 2002:a5d:4a0c:: with SMTP id\n\tm12mr3935345wrq.309.1611918985479; \n\tFri, 29 Jan 2021 03:16:25 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 29 Jan 2021 11:16:12 +0000","Message-Id":"<20210129111616.1047483-2-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210129111616.1047483-1-naush@raspberrypi.com>","References":"<20210129111616.1047483-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 1/5] libcamera: camera_sensor: Make\n\tVBLANK mandatory","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Jacopo Mondi \n\nAdd the V4L2_CID_VBLANK control to the list of mandatory controls\nthe sensor driver has to report and document the new requirement.\n\nThe vertical blanking control is used to calculate the frame duration.\n\nSigned-off-by: Jacopo Mondi \nSigned-off-by: Naushir Patuck \nReviewed-by: Naushir Patuck \n---\n Documentation/sensor_driver_requirements.rst | 6 ++++--\n src/libcamera/camera_sensor.cpp | 1 +\n 2 files changed, 5 insertions(+), 2 deletions(-)","diff":"diff --git a/Documentation/sensor_driver_requirements.rst b/Documentation/sensor_driver_requirements.rst\nindex 6dcd4e68d64d..590797f054ce 100644\n--- a/Documentation/sensor_driver_requirements.rst\n+++ b/Documentation/sensor_driver_requirements.rst\n@@ -27,18 +27,20 @@ The sensor driver shall support the following V4L2 controls:\n * `V4L2_CID_EXPOSURE`_\n * `V4L2_CID_HBLANK`_\n * `V4L2_CID_PIXEL_RATE`_\n+* `V4L2_CID_VBLANK`_\n \n .. _V4L2_CID_EXPOSURE: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/control.html\n .. _V4L2_CID_HBLANK: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-source.html\n .. _V4L2_CID_PIXEL_RATE: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-process.html\n+.. _V4L2_CID_VBLANK: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-source.html\n \n While V4L2 doesn't specify a unit for the `EXPOSURE` control, libcamera requires\n it to be expressed as a number of image lines. Camera sensor drivers that do not\n comply with this requirement will need to be adapted or will produce incorrect\n results.\n \n-The `HBLANK` and `PIXEL_RATE` controls are used to compute the sensor output\n-timings.\n+The `HBLANK`, `PIXEL_RATE` and `VBLANK` controls are used to compute the sensor\n+output timings.\n \n Optional Requirements\n ---------------------\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex ca33c0094088..ab315bdc468c 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -244,6 +244,7 @@ int CameraSensor::validateSensorDriver()\n \t\tV4L2_CID_EXPOSURE,\n \t\tV4L2_CID_HBLANK,\n \t\tV4L2_CID_PIXEL_RATE,\n+\t\tV4L2_CID_VBLANK,\n \t};\n \n \tControlList ctrls = subdev_->getControls(mandatoryControls);\n","prefixes":["libcamera-devel","v4","1/5"]}