{"id":11003,"url":"https://patchwork.libcamera.org/api/1.1/patches/11003/?format=json","web_url":"https://patchwork.libcamera.org/patch/11003/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210126102825.147026-8-paul.elder@ideasonboard.com>","date":"2021-01-26T10:28:24","name":"[libcamera-devel,v5,7/8] android: camera_device: Cache request metadata","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4c6c158fdc23c3e96b4aa77f8fc255171ac9b3d1","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/11003/mbox/","series":[{"id":1608,"url":"https://patchwork.libcamera.org/api/1.1/series/1608/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1608","date":"2021-01-26T10:28:17","name":"Fill in android result metadata and EXIF tags","version":5,"mbox":"https://patchwork.libcamera.org/series/1608/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/11003/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/11003/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A307BD808\n\tfor ;\n\tTue, 26 Jan 2021 10:28:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 37667682FA;\n\tTue, 26 Jan 2021 11:28:53 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA88D682FA\n\tfor ;\n\tTue, 26 Jan 2021 11:28:51 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E0E578B6;\n\tTue, 26 Jan 2021 11:28:49 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KCV6+JBo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1611656931;\n\tbh=g7JHqzEv+3imoFUC5H6JkM5l2rc9fwQptpOGIzKPp+4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KCV6+JBoml1ex6E0BX3v801Egic0wgeQugz0WdMKU5P6qBN7FgS8XgFHKP1Y9jNsg\n\tYdIcHE8TtYBoQHwSs18u9QMmapLU5uWf4QYSRMTL+XfnI89VpfmK68wfCRAEujyH4g\n\tgvgv9D3kDkaQSpKO1eUbWAFucC27HLMM0PzQ/qNE=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 26 Jan 2021 19:28:24 +0900","Message-Id":"<20210126102825.147026-8-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210126102825.147026-1-paul.elder@ideasonboard.com>","References":"<20210126102825.147026-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 7/8] android: camera_device: Cache\n\trequest metadata","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The settings in an android capture request may be null, in which case\nthe settings from the most recently submitted capture request should be\nused. Cache the request settings to achieve this.\n\nSigned-off-by: Paul Elder \nReviewed-by: Laurent Pinchart \nReviewed-by: Jacopo Mondi \n\n---\nChanges in v5:\n- expand todo\n\nChanges in v4:\n- use default CameraMetadata constructor for lastSettings_ (so no\n initialization in CameraDevice constructor)\n- add todo for incremental caching of android request settings\n\nChanges in v3:\n- rebase on \"android: camera device and metatada improvements\", so it's\n a bit cleaner\n\nNew in v2\n---\n src/android/camera_device.cpp | 10 ++++++++++\n src/android/camera_device.h | 2 ++\n 2 files changed, 12 insertions(+)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex f0a24514..d297bdf4 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1694,6 +1694,16 @@ int CameraDevice::processCaptureRequest(camera3_capture_request_t *camera3Reques\n \t */\n \tCamera3RequestDescriptor *descriptor =\n \t\tnew Camera3RequestDescriptor(camera_.get(), camera3Request);\n+\t/*\n+\t * \\todo The Android request model is incremental, settings passed in\n+\t * previous requests are to be effective until overridden explicitly in\n+\t * a new request. Do we need to cache settings incrementally here, or is\n+\t * it handled by the Android camera service ?\n+\t */\n+\tif (camera3Request->settings)\n+\t\tlastSettings_ = camera3Request->settings;\n+\telse\n+\t\tdescriptor->settings_ = lastSettings_;\n \n \tLOG(HAL, Debug) << \"Queueing Request to libcamera with \"\n \t\t\t<< descriptor->numBuffers_ << \" HAL streams\";\ndiff --git a/src/android/camera_device.h b/src/android/camera_device.h\nindex 4b0d8575..9cbfcad3 100644\n--- a/src/android/camera_device.h\n+++ b/src/android/camera_device.h\n@@ -134,6 +134,8 @@ private:\n \tint orientation_;\n \n \tunsigned int maxJpegBufferSize_;\n+\n+\tCameraMetadata lastSettings_;\n };\n \n #endif /* __ANDROID_CAMERA_DEVICE_H__ */\n","prefixes":["libcamera-devel","v5","7/8"]}