{"id":10987,"url":"https://patchwork.libcamera.org/api/1.1/patches/10987/?format=json","web_url":"https://patchwork.libcamera.org/patch/10987/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210125081932.799132-1-naush@raspberrypi.com>","date":"2021-01-25T08:19:32","name":"[libcamera-devel] raspberrypi: Add the correct integer const postfix for FrameDurations","commit_ref":"34897234d10ce8fafd95121fb12f28a2477d99e0","pull_url":null,"state":"accepted","archived":false,"hash":"be4e47bf358b986cf10408f3a270479bc96b649e","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10987/mbox/","series":[{"id":1604,"url":"https://patchwork.libcamera.org/api/1.1/series/1604/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1604","date":"2021-01-25T08:19:32","name":"[libcamera-devel] raspberrypi: Add the correct integer const postfix for FrameDurations","version":1,"mbox":"https://patchwork.libcamera.org/series/1604/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10987/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10987/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 49BABBD808\n\tfor ;\n\tMon, 25 Jan 2021 08:19:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A8126682A8;\n\tMon, 25 Jan 2021 09:19:38 +0100 (CET)","from mail-wm1-x334.google.com (mail-wm1-x334.google.com\n\t[IPv6:2a00:1450:4864:20::334])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CDAA368212\n\tfor ;\n\tMon, 25 Jan 2021 09:19:37 +0100 (CET)","by mail-wm1-x334.google.com with SMTP id y187so9892422wmd.3\n\tfor ;\n\tMon, 25 Jan 2021 00:19:37 -0800 (PST)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\tp18sm19976634wmc.31.2021.01.25.00.19.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 25 Jan 2021 00:19:36 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"W6g1nQRG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=wwOK9OH0Hh2287T4li/4enCYaYykXaqQiilFMXP8GnQ=;\n\tb=W6g1nQRGvbgvfNx294JARgSfLH5yszQysbR7swi9ZTS0gl/Em3VBxXbp1mBrV3IJLU\n\tQ2IiyvNtaKM0HYVcaDImHNbjuE2EIbuBtcHV67smCBkFCdVknnyTc57yQA+MbKepUvWb\n\tyi9m4CLH6Fu4+yhqaQzmB3veDBvsmctlfgix9gx7QvA97qz+5Xj7pfqKj5tYD//aJyrX\n\tVKfZNqkSpMun97JofPKxJvsWmPKHlAlw4t7crCXVjlbaELzt+DtZqfKblpg/QOLE0R/7\n\tp2MB0D04jff4ISjNpO2iflkUNzFrN2lxDcqjNnVWuWBMX7nZHJStthyS7KXBxBDSdt6x\n\t/oug==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=wwOK9OH0Hh2287T4li/4enCYaYykXaqQiilFMXP8GnQ=;\n\tb=XqtMEn8oJmhG6kDT3fnAtM+OTQE0v5Obld8Y//JuG1bHpprHE4qoJmfqIj/g4nqS6p\n\teiWifhfj3TGodjIMdUe+ZwEebGK8HqMyqXvOnYjgI37zIYwKBZPUFJ5Ikzumgv6wwIbx\n\tq9E1E1G4BcN4V9X2Y2q7vaESM+TZIf5OvhRd0ILIpes6HaQV/fbCIOAfDhBehnpW0c9j\n\t3Rk4OSH0bs9f81zluwAUm73PFubB+2xtuOs1UOdatYscU8k4iyk/M3qk55Xj7nzb8TS2\n\tBNZr4mt09KN83QfumT4S2QUu+/KtFo/lXZ7mZ3Ls+y376OaJ9ZRpcYIWlsUbLrKesb2a\n\t0inw==","X-Gm-Message-State":"AOAM530PFxnXeO1rHIzRDeJZMUgbADfVlG5gw6YklCr7whTr2iYVQA8/\n\tm+1ijrw0GC0WNbWQIRp4eRgsj96VNTqNBz3b","X-Google-Smtp-Source":"ABdhPJxHZjEgqma2E21mYYlsyFSXJdihBL4d8x1mzv7klMK1OCbF3K62hZph7QZ9Ovd0kEP6KmV/Uw==","X-Received":"by 2002:a1c:e043:: with SMTP id x64mr379601wmg.48.1611562777200; \n\tMon, 25 Jan 2021 00:19:37 -0800 (PST)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 25 Jan 2021 08:19:32 +0000","Message-Id":"<20210125081932.799132-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20210124140506.786503-1-naush@raspberrypi.com>","References":"<20210124140506.786503-1-naush@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] raspberrypi: Add the correct integer\n\tconst postfix for FrameDurations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Kieran Bingham ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"At startup, ControlInfoMap::generateIdmap() threw a log message warning\nthat the controls::FrameDurations had a type mismatch based on the\nmin/max values provided in libcamera::RPi::Controls initialiser.\n\nFix this warning by forcing the integer constants to be 64-bit wide by\nusing the INT64_C() macro.\n\nSigned-off-by: Naushir Patuck \nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \n---\n include/libcamera/ipa/raspberrypi.h | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\nindex 1de36039cee0..4038428bdba4 100644\n--- a/include/libcamera/ipa/raspberrypi.h\n+++ b/include/libcamera/ipa/raspberrypi.h\n@@ -7,6 +7,8 @@\n #ifndef __LIBCAMERA_IPA_INTERFACE_RASPBERRYPI_H__\n #define __LIBCAMERA_IPA_INTERFACE_RASPBERRYPI_H__\n \n+#include \n+\n #include \n #include \n \n@@ -65,7 +67,7 @@ static const ControlInfoMap Controls = {\n \t{ &controls::Sharpness, ControlInfo(0.0f, 16.0f, 1.0f) },\n \t{ &controls::ColourCorrectionMatrix, ControlInfo(-16.0f, 16.0f) },\n \t{ &controls::ScalerCrop, ControlInfo(Rectangle{}, Rectangle(65535, 65535, 65535, 65535), Rectangle{}) },\n-\t{ &controls::FrameDurations, ControlInfo(1000, 1000000000) },\n+\t{ &controls::FrameDurations, ControlInfo(INT64_C(1000), INT64_C(1000000000)) },\n };\n \n } /* namespace RPi */\n","prefixes":["libcamera-devel"]}