{"id":10889,"url":"https://patchwork.libcamera.org/api/1.1/patches/10889/?format=json","web_url":"https://patchwork.libcamera.org/patch/10889/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210119143711.153517-2-jacopo@jmondi.org>","date":"2021-01-19T14:37:01","name":"[libcamera-devel,v2,01/11] libcamera: CameraSensor: Mention V4L2 in get/setControls()","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"4f3e8d7ac753274df76d9f0a1d1ca6d816b0f257","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/1.1/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/10889/mbox/","series":[{"id":1584,"url":"https://patchwork.libcamera.org/api/1.1/series/1584/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1584","date":"2021-01-19T14:37:00","name":"android: Exposure times + scaler crop + android metadata","version":2,"mbox":"https://patchwork.libcamera.org/series/1584/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10889/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10889/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B76B8BD808\n\tfor ;\n\tTue, 19 Jan 2021 14:36:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4C96B68152;\n\tTue, 19 Jan 2021 15:36:59 +0100 (CET)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7B21E68140\n\tfor ;\n\tTue, 19 Jan 2021 15:36:57 +0100 (CET)","from uno.LocalDomain (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190]) (Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 3D2B4C000E\n\tfor ;\n\tTue, 19 Jan 2021 14:36:57 +0000 (UTC)"],"X-Originating-IP":"93.61.96.190","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 19 Jan 2021 15:37:01 +0100","Message-Id":"<20210119143711.153517-2-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210119143711.153517-1-jacopo@jmondi.org>","References":"<20210119143711.153517-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 01/11] libcamera: CameraSensor: Mention\n\tV4L2 in get/setControls()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The current CameraSensor interface for reading and writing controls\nis currently based on V4L2 controls.\n\nMention that more clearly in the documentation and, while at it, re-sort\nthe documentation to match the methods declaration order.\n\nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/camera_sensor.cpp | 24 +++++++++++++-----------\n 1 file changed, 13 insertions(+), 11 deletions(-)","diff":"diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 251691aedfa3..9abb9d330664 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -590,11 +590,12 @@ const ControlInfoMap &CameraSensor::controls() const\n }\n \n /**\n- * \\brief Read controls from the sensor\n+ * \\brief Read V4L2 controls from the sensor\n * \\param[in] ids The list of controls to read, specified by their ID\n *\n * This method reads the value of all controls contained in \\a ids, and returns\n- * their values as a ControlList.\n+ * their values as a ControlList. The control identifiers are defined by the\n+ * V4L2 specification (V4L2_CID_*).\n *\n * If any control in \\a ids is not supported by the device, is disabled (i.e.\n * has the V4L2_CTRL_FLAG_DISABLED flag set), or if any other error occurs\n@@ -612,18 +613,13 @@ ControlList CameraSensor::getControls(const std::vector &ids)\n }\n \n /**\n- * \\fn CameraSensor::properties()\n- * \\brief Retrieve the camera sensor properties\n- * \\return The list of camera sensor properties\n- */\n-\n-/**\n- * \\brief Write controls to the sensor\n+ * \\brief Write V4L2 controls to the sensor\n * \\param[in] ctrls The list of controls to write\n *\n * This method writes the value of all controls contained in \\a ctrls, and\n- * stores the values actually applied to the device in the corresponding\n- * \\a ctrls entry.\n+ * stores the values actually applied to the device in the corresponding \\a\n+ * ctrls entry. The control identifiers are defined by the V4L2 specification\n+ * (V4L2_CID_*).\n *\n * If any control in \\a ctrls is not supported by the device, is disabled (i.e.\n * has the V4L2_CTRL_FLAG_DISABLED flag set), is read-only, or if any other\n@@ -646,6 +642,12 @@ int CameraSensor::setControls(ControlList *ctrls)\n \treturn subdev_->setControls(ctrls);\n }\n \n+/**\n+ * \\fn CameraSensor::properties()\n+ * \\brief Retrieve the camera sensor properties\n+ * \\return The list of camera sensor properties\n+ */\n+\n /**\n * \\brief Assemble and return the camera sensor info\n * \\param[out] info The camera sensor info\n","prefixes":["libcamera-devel","v2","01/11"]}