{"id":10883,"url":"https://patchwork.libcamera.org/api/1.1/patches/10883/?format=json","web_url":"https://patchwork.libcamera.org/patch/10883/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210118114624.13240-2-jacopo@jmondi.org>","date":"2021-01-18T11:46:24","name":"[libcamera-devel,2/2] Documentation: sensor-driver: Correct camera rotation","commit_ref":"dce1568a8a81f28592ba2ec9993fde1f39096031","pull_url":null,"state":"accepted","archived":false,"hash":"df3bfc09f645ae2891616de8de98dc62acc63d69","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10883/mbox/","series":[{"id":1581,"url":"https://patchwork.libcamera.org/api/1.1/series/1581/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1581","date":"2021-01-18T11:46:23","name":"[libcamera-devel,1/2] Documentation: sensor-drivers: Reorder introduction","version":1,"mbox":"https://patchwork.libcamera.org/series/1581/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10883/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10883/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E506DBD808\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 18 Jan 2021 11:46:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BA18468126;\n\tMon, 18 Jan 2021 12:46:17 +0100 (CET)","from relay2-d.mail.gandi.net (relay2-d.mail.gandi.net\n\t[217.70.183.194])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4D4C5680F9\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 18 Jan 2021 12:46:15 +0100 (CET)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay2-d.mail.gandi.net (Postfix) with ESMTPSA id DE86D4000E;\n\tMon, 18 Jan 2021 11:46:14 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi <jacopo@jmondi.org>","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 18 Jan 2021 12:46:24 +0100","Message-Id":"<20210118114624.13240-2-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210118114624.13240-1-jacopo@jmondi.org>","References":"<20210118114624.13240-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/2] Documentation: sensor-driver: Correct\n\tcamera rotation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The description of the V4L2_CID_CAMERA_SENSOR_ROTATION control\nusage wrongly mentioned the camera \"orientation\" while it actually\nreports the camera rotation.\n\nFix it by using the right term.\n\nReported-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\nSigned-off-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n Documentation/sensor_driver_requirements.rst | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/Documentation/sensor_driver_requirements.rst b/Documentation/sensor_driver_requirements.rst\nindex 8cd24c15ca63..1dc8c890d16d 100644\n--- a/Documentation/sensor_driver_requirements.rst\n+++ b/Documentation/sensor_driver_requirements.rst\n@@ -43,7 +43,7 @@ The sensor driver should support the following V4L2 controls:\n .. _V4L2_CID_CAMERA_ORIENTATION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-camera.html\n .. _V4L2_CID_CAMERA_SENSOR_ROTATION: https://www.kernel.org/doc/html/latest/userspace-api/media/v4l/ext-ctrls-image-process.html\n \n-The controls are used to register the camera location and orientation.\n+The controls are used to register the camera location and rotation.\n \n The sensor driver should implement support for the V4L2 Selection API,\n specifically it should implement support for the\n","prefixes":["libcamera-devel","2/2"]}