{"id":1088,"url":"https://patchwork.libcamera.org/api/1.1/patches/1088/?format=json","web_url":"https://patchwork.libcamera.org/patch/1088/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190419132531.17856-3-jacopo@jmondi.org>","date":"2019-04-19T13:25:25","name":"[libcamera-devel,v8,2/8] libcamera: camera: Reset basefield to decimal","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"503fe2369bc064770abfd491f8c451753da9200f","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1088/mbox/","series":[{"id":263,"url":"https://patchwork.libcamera.org/api/1.1/series/263/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=263","date":"2019-04-19T13:25:23","name":"libcamera: ipu3: Multiple streams support","version":8,"mbox":"https://patchwork.libcamera.org/series/263/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1088/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1088/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F6BE60DC7\n\tfor ;\n\tFri, 19 Apr 2019 15:24:45 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id BB6B72000E;\n\tFri, 19 Apr 2019 13:24:44 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 19 Apr 2019 15:25:25 +0200","Message-Id":"<20190419132531.17856-3-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190419132531.17856-1-jacopo@jmondi.org>","References":"<20190419132531.17856-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v8 2/8] libcamera: camera: Reset basefield\n\tto decimal","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Fri, 19 Apr 2019 13:24:46 -0000"},"content":"When logging the camera configuration, the same ostringstream instance\nis used to assemble a message describing configuration of all the\nconfigured streams.\n\nAfter the first stream configuration has been assembled, the use of\nstd::hex modifies the ostringstream basefield, causing all successive\nintegers values inserted in the stream to be expressed as hexadecimals.\n\nFix that by resetting the stream's basefield to decimal, before\nassembling a stream configuration description.\n\nBefore this patch:\nINFO Camera camera.cpp:615 (0) 640x480-0x3231564e (1) 140xa0-0x3231564e\nAfter this patch:\nINFO Camera camera.cpp:616 (0) 640x480-0x3231564e (1) 320x160-0x3231564e\n\nFixes: 9c9078133216 (\"libcamera: camera: Log requested configuration in configureStreams()\")\nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/camera.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/camera.cpp b/src/libcamera/camera.cpp\nindex d7a39ca6af12..655996f26224 100644\n--- a/src/libcamera/camera.cpp\n+++ b/src/libcamera/camera.cpp\n@@ -597,7 +597,7 @@ int Camera::configureStreams(const CameraConfiguration &config)\n \t\t\treturn -EINVAL;\n \n \t\tconst StreamConfiguration &cfg = config[stream];\n-\t\tmsg << \" (\" << index << \") \" << cfg.toString();\n+\t\tmsg << std::dec << \" (\" << index << \") \" << cfg.toString();\n \n \t\tindex++;\n \t}\n","prefixes":["libcamera-devel","v8","2/8"]}