{"id":10872,"url":"https://patchwork.libcamera.org/api/1.1/patches/10872/?format=json","web_url":"https://patchwork.libcamera.org/patch/10872/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210115170033.27124-10-jacopo@jmondi.org>","date":"2021-01-15T17:00:32","name":"[libcamera-devel,v7,09/10] libcamera: camera_sensor: Initialize VIMC properties","commit_ref":"db6a3bfa6e92081c33463ce58c51ac8fae7f854c","pull_url":null,"state":"accepted","archived":false,"hash":"0635408cb2ca1a9cfd4cd16cf4c8abe3c64b28a6","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10872/mbox/","series":[{"id":1578,"url":"https://patchwork.libcamera.org/api/1.1/series/1578/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1578","date":"2021-01-15T17:00:23","name":"libcamera: camera_sensor: Make validation more strict","version":7,"mbox":"https://patchwork.libcamera.org/series/1578/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10872/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10872/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9164C3383\n\tfor ;\n\tFri, 15 Jan 2021 17:00:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1883E68102;\n\tFri, 15 Jan 2021 18:00:26 +0100 (CET)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4CF8D680FE\n\tfor ;\n\tFri, 15 Jan 2021 18:00:21 +0100 (CET)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 1AB95240004\n\tfor ;\n\tFri, 15 Jan 2021 17:00:20 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 15 Jan 2021 18:00:32 +0100","Message-Id":"<20210115170033.27124-10-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210115170033.27124-1-jacopo@jmondi.org>","References":"<20210115170033.27124-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v7 09/10] libcamera: camera_sensor:\n\tInitialize VIMC properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The VIMC driver does not yet support all the features required\nfor all sensor drivers. As it is the main testing platforms and the\ndriver changes might take a long time to land in the developments\nand testing platforms, temporary close the gap by skipping driver\nvalidation and initializing properties with static information such\nas the sensor resolution.\n\nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/internal/camera_sensor.h | 1 +\n src/libcamera/camera_sensor.cpp | 26 ++++++++++++++++++++++\n 2 files changed, 27 insertions(+)","diff":"diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex 86902b85ada8..fed36bf26e47 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -70,6 +70,7 @@ protected:\n private:\n \tint generateId();\n \tint validateSensorDriver();\n+\tvoid initVimcDefaultProperties();\n \tint initProperties();\n \n \tconst MediaEntity *entity_;\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex e9c80c304dd4..251691aedfa3 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -6,6 +6,7 @@\n */\n \n #include \"libcamera/internal/camera_sensor.h\"\n+#include \"libcamera/internal/media_device.h\"\n \n #include \n #include \n@@ -207,6 +208,21 @@ int CameraSensor::init()\n \t */\n \tresolution_ = sizes_.back();\n \n+\t/*\n+\t * VIMC is a bit special, as it does not yet support all the mandatory\n+\t * requirements regular sensors have to respect.\n+\t *\n+\t * Do not validate the driver if it's VIMC and initialize the sensor\n+\t * properties with static information.\n+\t *\n+\t * \\todo Remove the special case once the VIMC driver has been\n+\t * updated in all test platforms.\n+\t */\n+\tif (entity_->device()->driver() == \"vimc\") {\n+\t\tinitVimcDefaultProperties();\n+\t\treturn initProperties();\n+\t}\n+\n \tret = validateSensorDriver();\n \tif (ret)\n \t\treturn ret;\n@@ -304,6 +320,16 @@ int CameraSensor::validateSensorDriver()\n \treturn 0;\n }\n \n+/*\n+ * \\brief Initialize properties that cannot be intialized by the\n+ * regular initProperties() function for VIMC\n+ */\n+void CameraSensor::initVimcDefaultProperties()\n+{\n+\tpixelArraySize_ = resolution();\n+\tactiveArea_ = Rectangle(pixelArraySize_);\n+}\n+\n int CameraSensor::initProperties()\n {\n \t/*\n","prefixes":["libcamera-devel","v7","09/10"]}