{"id":10857,"url":"https://patchwork.libcamera.org/api/1.1/patches/10857/?format=json","web_url":"https://patchwork.libcamera.org/patch/10857/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210114104035.302968-2-paul.elder@ideasonboard.com>","date":"2021-01-14T10:40:30","name":"[libcamera-devel,1/6] utils: Add function to convert string to UCS-2","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"fb6748da0fae80757c905f120375393eaeb5c405","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/10857/mbox/","series":[{"id":1577,"url":"https://patchwork.libcamera.org/api/1.1/series/1577/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1577","date":"2021-01-14T10:40:29","name":"Fill in android result metadata and EXIF tags","version":1,"mbox":"https://patchwork.libcamera.org/series/1577/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10857/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10857/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9D881BD808\n\tfor ;\n\tThu, 14 Jan 2021 10:40:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 59B7A680E8;\n\tThu, 14 Jan 2021 11:40:50 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 37C3D680E3\n\tfor ;\n\tThu, 14 Jan 2021 11:40:49 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BC85B2B3;\n\tThu, 14 Jan 2021 11:40:47 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ri8D12IZ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1610620848;\n\tbh=2rO6jGp2Y1nu6awNfsdYgxsRDJn8UjiYQY07RH1f5Zc=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Ri8D12IZDtonTqcr/fAKoRrK3K3MlQCJQxGh1+TDChAIOeU4uoNBE5UZsyrenNWf2\n\t1af/fpmPGxnW9xCSY53oExDonIOZiR0wOtuhbiZ5c6itrFzOErhEcn4lo7emujoVUB\n\tDtnYsdptIFu6oe6HlyoCz4dQA6uEm0L9ImcjqCdM=","From":"Paul Elder ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 14 Jan 2021 19:40:30 +0900","Message-Id":"<20210114104035.302968-2-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20210114104035.302968-1-paul.elder@ideasonboard.com>","References":"<20210114104035.302968-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/6] utils: Add function to convert string\n\tto UCS-2","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"GPSProcessingMethod and UserComment in EXIF tags can be in Unicode, but\nare recommended to be in UCS-2. Add a function in utils to help with\nthis.\n\nSigned-off-by: Paul Elder \n---\n include/libcamera/internal/utils.h | 2 ++\n src/libcamera/utils.cpp | 30 ++++++++++++++++++++++++++++++\n 2 files changed, 32 insertions(+)","diff":"diff --git a/include/libcamera/internal/utils.h b/include/libcamera/internal/utils.h\nindex f08134af..aa9cc236 100644\n--- a/include/libcamera/internal/utils.h\n+++ b/include/libcamera/internal/utils.h\n@@ -35,6 +35,8 @@ const char *basename(const char *path);\n char *secure_getenv(const char *name);\n std::string dirname(const std::string &path);\n \n+std::vector string_to_c16(const std::string &str, bool le);\n+\n template\n std::vector map_keys(const T &map)\n {\ndiff --git a/src/libcamera/utils.cpp b/src/libcamera/utils.cpp\nindex e90375ae..89cb0f73 100644\n--- a/src/libcamera/utils.cpp\n+++ b/src/libcamera/utils.cpp\n@@ -17,6 +17,7 @@\n #include \n #include \n #include \n+#include \n #include \n \n /**\n@@ -122,6 +123,35 @@ std::string dirname(const std::string &path)\n \treturn path.substr(0, pos + 1);\n }\n \n+/**\n+ * \\brief Convert string to byte array of UCS-2\n+ * \\param[in] str String to convert\n+ * \\param[in] le Little-endian (false for Big-endian)\n+ *\n+ * \\return Byte array of UCS-2 representation of \\a str, without null-terminator\n+ */\n+std::vector string_to_c16(const std::string &str, bool le)\n+{\n+\tstd::mbstate_t state{};\n+\tchar16_t c16;\n+\tconst char *ptr = &str[0], *end = &str[0] + str.size();\n+\n+\tstd::vector ret;\n+\twhile (size_t rc = mbrtoc16(&c16, ptr, end - ptr + 1, &state)) {\n+\t\tif (rc == static_cast(-2) ||\n+\t\t rc == static_cast(-1))\n+\t\t\tbreak;\n+\n+\t\tret.push_back(le ? (c16 & 0xff) : ((c16 >> 8) & 0xff));\n+\t\tret.push_back(le ? ((c16 >> 8) & 0xff) : (c16 & 0xff));\n+\n+\t\tif (rc > 0)\n+\t\t\tptr += rc;\n+\t}\n+\n+\treturn ret;\n+}\n+\n /**\n * \\fn std::vector map_keys(const T &map)\n * \\brief Retrieve the keys of a std::map<>\n","prefixes":["libcamera-devel","1/6"]}