{"id":10818,"url":"https://patchwork.libcamera.org/api/1.1/patches/10818/?format=json","web_url":"https://patchwork.libcamera.org/patch/10818/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210105190522.682324-5-jacopo@jmondi.org>","date":"2021-01-05T19:05:14","name":"[libcamera-devel,04/12] android: camera_device: Register EXPOSURE_TIME_RANGE","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"88a5cc3a8b1b8e4529cdc28001610ff49ee4684e","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/1.1/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/10818/mbox/","series":[{"id":1568,"url":"https://patchwork.libcamera.org/api/1.1/series/1568/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1568","date":"2021-01-05T19:05:10","name":"android: Exposure times + scaler crop + android metadata","version":1,"mbox":"https://patchwork.libcamera.org/series/1568/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10818/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10818/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A11D9C0F1D\n\tfor ;\n\tTue, 5 Jan 2021 19:05:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D8570631D0;\n\tTue, 5 Jan 2021 20:05:16 +0100 (CET)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FFDD62012\n\tfor ;\n\tTue, 5 Jan 2021 20:05:15 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id DBBF3100002\n\tfor ;\n\tTue, 5 Jan 2021 19:05:14 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 5 Jan 2021 20:05:14 +0100","Message-Id":"<20210105190522.682324-5-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210105190522.682324-1-jacopo@jmondi.org>","References":"<20210105190522.682324-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 04/12] android: camera_device: Register\n\tEXPOSURE_TIME_RANGE","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Register the EXPOSURE_TIME_RANGE static metadata inspecting the\nExposureTime control limits as reported by the camera.\n\nIf such information is not available, do not register the property.\n\nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 14 +++++++++-----\n 1 file changed, 9 insertions(+), 5 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex a136f8e33843..de3ead275e91 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -888,11 +888,15 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t\t\t\t\t &filterArr, 1);\n \t}\n \n-\tint64_t exposureTimeRange[] = {\n-\t\t100000, 200000000,\n-\t};\n-\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n-\t\t\t\t &exposureTimeRange, 2);\n+\tconst auto &exposureInfo = controlsInfo.find(&controls::ExposureTime);\n+\tif (exposureInfo != controlsInfo.end()) {\n+\t\tint64_t exposureTimeRange[2] = {\n+\t\t\texposureInfo->second.min().get() * 1000,\n+\t\t\texposureInfo->second.max().get() * 1000,\n+\t\t};\n+\t\tstaticMetadata_->addEntry(ANDROID_SENSOR_INFO_EXPOSURE_TIME_RANGE,\n+\t\t\t\t\t &exposureTimeRange, 2);\n+\t}\n \n \tstaticMetadata_->addEntry(ANDROID_SENSOR_ORIENTATION, &orientation_, 1);\n \n","prefixes":["libcamera-devel","04/12"]}