{"id":10812,"url":"https://patchwork.libcamera.org/api/1.1/patches/10812/?format=json","web_url":"https://patchwork.libcamera.org/patch/10812/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210105123128.617543-10-jacopo@jmondi.org>","date":"2021-01-05T12:31:27","name":"[libcamera-devel,v5,09/10] libcamera: camera_sensor: Initialize VIMC properties","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"80fe4b7435325b776c7cb169aa372fb0cbe58a29","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10812/mbox/","series":[{"id":1567,"url":"https://patchwork.libcamera.org/api/1.1/series/1567/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1567","date":"2021-01-05T12:31:18","name":"libcamera: camera_sensor: Make validation more strict","version":5,"mbox":"https://patchwork.libcamera.org/series/1567/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10812/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10812/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6BFFC0F1D\n\tfor ;\n\tTue, 5 Jan 2021 12:31:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4CAB0630BB;\n\tTue, 5 Jan 2021 13:31:25 +0100 (CET)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6991B62015\n\tfor ;\n\tTue, 5 Jan 2021 13:31:22 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 28FC0E0003\n\tfor ;\n\tTue, 5 Jan 2021 12:31:21 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 5 Jan 2021 13:31:27 +0100","Message-Id":"<20210105123128.617543-10-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210105123128.617543-1-jacopo@jmondi.org>","References":"<20210105123128.617543-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 09/10] libcamera: camera_sensor:\n\tInitialize VIMC properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The VIMC driver does not yet support all the features required\nfor all sensor drivers. As it is the main testing platforms and the\ndriver changes might take a long time to land in the developments\nand testing platforms, temporary close the gap by skipping driver\nvalidation and initializing properties with static information such\nas the sensor resolution.\n\nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/internal/camera_sensor.h | 1 +\n src/libcamera/camera_sensor.cpp | 27 ++++++++++++++++++++++\n 2 files changed, 28 insertions(+)","diff":"diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex de6a0202d19a..759a12d16f72 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -70,6 +70,7 @@ protected:\n private:\n \tint generateId();\n \tint validateSensorDriver();\n+\tvoid initVIMCDefaultProperties();\n \tint initProperties();\n \n \tconst MediaEntity *entity_;\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 0e8aff27b712..046474c03f4a 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -6,6 +6,7 @@\n */\n \n #include \"libcamera/internal/camera_sensor.h\"\n+#include \"libcamera/internal/media_device.h\"\n \n #include \n #include \n@@ -207,6 +208,21 @@ int CameraSensor::init()\n \t */\n \tresolution_ = sizes_.back();\n \n+\t/*\n+\t * VIMC is a bit special, as it does not yet support all the\n+\t * mandatory requirements regular sensors have to respect.\n+\t *\n+\t * Do not validate the driver if it's VIMC and initialize the\n+\t * the sensor properties with static information.\n+\t *\n+\t * \\todo Remove the special case once the VIMC driver has been\n+\t * updated in all test platforms.\n+\t */\n+\tif (entity_->device()->driver() == \"vimc\") {\n+\t\tinitVIMCDefaultProperties();\n+\t\treturn initProperties();\n+\t}\n+\n \tret = validateSensorDriver();\n \tif (ret)\n \t\treturn ret;\n@@ -306,6 +322,17 @@ int CameraSensor::validateSensorDriver()\n \treturn 0;\n }\n \n+/*\n+ * \\brief Initialize properties that cannot be intialized by the\n+ * regular initProperties() function for VIMC\n+ */\n+void CameraSensor::initVIMCDefaultProperties()\n+{\n+\tpixelArraySize_ = resolution();\n+\tactiveArea_ = Rectangle(pixelArraySize_);\n+\tanalogueCrop_ = activeArea_;\n+}\n+\n int CameraSensor::initProperties()\n {\n \t/*\n","prefixes":["libcamera-devel","v5","09/10"]}