{"id":10810,"url":"https://patchwork.libcamera.org/api/1.1/patches/10810/?format=json","web_url":"https://patchwork.libcamera.org/patch/10810/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210105123128.617543-8-jacopo@jmondi.org>","date":"2021-01-05T12:31:25","name":"[libcamera-devel,v5,07/10] libcamera: uvc: Initialize the pixel array properties","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"1f2b3d826ed73e592d7bd5247d608db332a783d4","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10810/mbox/","series":[{"id":1567,"url":"https://patchwork.libcamera.org/api/1.1/series/1567/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1567","date":"2021-01-05T12:31:18","name":"libcamera: camera_sensor: Make validation more strict","version":5,"mbox":"https://patchwork.libcamera.org/series/1567/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10810/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10810/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 22DE4C0F1D\n\tfor ;\n\tTue, 5 Jan 2021 12:31:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D8F16631D0;\n\tTue, 5 Jan 2021 13:31:24 +0100 (CET)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FAF66010F\n\tfor ;\n\tTue, 5 Jan 2021 13:31:21 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 4A331E0004\n\tfor ;\n\tTue, 5 Jan 2021 12:31:21 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 5 Jan 2021 13:31:25 +0100","Message-Id":"<20210105123128.617543-8-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210105123128.617543-1-jacopo@jmondi.org>","References":"<20210105123128.617543-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 07/10] libcamera: uvc: Initialize the\n\tpixel array properties","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Initialize the pixel array properties in the UVC pipeline handler as\nthey're now initialized in the CameraSensor class, which the UVC\npipeline handler does not ue.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/uvcvideo/uvcvideo.cpp | 13 +++++++++++++\n 1 file changed, 13 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\nindex 7cb310e20511..1efced949762 100644\n--- a/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n+++ b/src/libcamera/pipeline/uvcvideo/uvcvideo.cpp\n@@ -509,6 +509,19 @@ int UVCCameraData::init(MediaDevice *media)\n \tproperties_.set(properties::Location, properties::CameraLocationExternal);\n \tproperties_.set(properties::Model, utils::toAscii(media->model()));\n \n+\t/*\n+\t * Get the current format in order to initialize the sensor array\n+\t * properties.\n+\t */\n+\tV4L2DeviceFormat format;\n+\tret = video_->getFormat(&format);\n+\tif (ret)\n+\t\treturn ret;\n+\n+\tproperties_.set(properties::PixelArraySize, format.size);\n+\tproperties_.set(properties::PixelArrayActiveAreas,\n+\t\t\t{ Rectangle(format.size) });\n+\n \t/* Initialise the supported controls. */\n \tControlInfoMap::Map ctrls;\n \n","prefixes":["libcamera-devel","v5","07/10"]}