{"id":10809,"url":"https://patchwork.libcamera.org/api/1.1/patches/10809/?format=json","web_url":"https://patchwork.libcamera.org/patch/10809/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20210105123128.617543-7-jacopo@jmondi.org>","date":"2021-01-05T12:31:24","name":"[libcamera-devel,v5,06/10] libcamera: camera_sensor: Do not default 'rotation'","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ed5b8abcc62258f24e47152165c94c648377fc0d","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10809/mbox/","series":[{"id":1567,"url":"https://patchwork.libcamera.org/api/1.1/series/1567/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1567","date":"2021-01-05T12:31:18","name":"libcamera: camera_sensor: Make validation more strict","version":5,"mbox":"https://patchwork.libcamera.org/series/1567/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10809/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10809/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C2FB6C0F1C\n\tfor ;\n\tTue, 5 Jan 2021 12:31:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9FF86631AC;\n\tTue, 5 Jan 2021 13:31:24 +0100 (CET)","from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net\n\t[217.70.183.196])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CF2F62012\n\tfor ;\n\tTue, 5 Jan 2021 13:31:21 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay4-d.mail.gandi.net (Postfix) with ESMTPSA id D41DBE0003\n\tfor ;\n\tTue, 5 Jan 2021 12:31:20 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 5 Jan 2021 13:31:24 +0100","Message-Id":"<20210105123128.617543-7-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20210105123128.617543-1-jacopo@jmondi.org>","References":"<20210105123128.617543-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 06/10] libcamera: camera_sensor: Do not\n\tdefault 'rotation'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The 'rotation' property is not critical. Only register it if the\nsensor driver reports it.\n\nReviewed-by: Niklas Söderlund \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/camera_sensor.cpp | 8 +++-----\n 1 file changed, 3 insertions(+), 5 deletions(-)","diff":"diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 205a4ad6085f..0e8aff27b712 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -372,13 +372,11 @@ int CameraSensor::initProperties()\n \t}\n \tproperties_.set(properties::Location, propertyValue);\n \n-\t/* Camera Rotation: default is 0 degrees. */\n \tconst auto &rotationControl = controls.find(V4L2_CID_CAMERA_SENSOR_ROTATION);\n-\tif (rotationControl != controls.end())\n+\tif (rotationControl != controls.end()) {\n \t\tpropertyValue = rotationControl->second.def().get();\n-\telse\n-\t\tpropertyValue = 0;\n-\tproperties_.set(properties::Rotation, propertyValue);\n+\t\tproperties_.set(properties::Rotation, propertyValue);\n+\t}\n \n \tproperties_.set(properties::PixelArraySize, pixelArraySize_);\n \tproperties_.set(properties::PixelArrayActiveAreas, { activeArea_ });\n","prefixes":["libcamera-devel","v5","06/10"]}