{"id":10797,"url":"https://patchwork.libcamera.org/api/1.1/patches/10797/?format=json","web_url":"https://patchwork.libcamera.org/patch/10797/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201231155336.7058-4-sebastian.fricke.linux@gmail.com>","date":"2020-12-31T15:53:35","name":"[libcamera-devel,v2,3/4] libcamera: pipeline: rpi: Adjust to new implementation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"6cdb862b547678c5760cc30d2f612319fd8e75d4","submitter":{"id":73,"url":"https://patchwork.libcamera.org/api/1.1/people/73/?format=json","name":"Sebastian Fricke","email":"sebastian.fricke.linux@gmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10797/mbox/","series":[{"id":1564,"url":"https://patchwork.libcamera.org/api/1.1/series/1564/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1564","date":"2020-12-31T15:53:32","name":"Improve BayerFormat class","version":2,"mbox":"https://patchwork.libcamera.org/series/1564/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10797/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10797/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C0664C0F1A\n\tfor ;\n\tThu, 31 Dec 2020 15:54:36 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C2BE615B4;\n\tThu, 31 Dec 2020 16:54:36 +0100 (CET)","from mail-wm1-x32d.google.com (mail-wm1-x32d.google.com\n\t[IPv6:2a00:1450:4864:20::32d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BB7796031D\n\tfor ;\n\tThu, 31 Dec 2020 16:54:34 +0100 (CET)","by mail-wm1-x32d.google.com with SMTP id a6so7572641wmc.2\n\tfor ;\n\tThu, 31 Dec 2020 07:54:34 -0800 (PST)","from basti-TUXEDO-Book-XA1510.fritz.box\n\t(p200300d1ff267500b10aabf0e84cdf75.dip0.t-ipconnect.de.\n\t[2003:d1:ff26:7500:b10a:abf0:e84c:df75])\n\tby smtp.gmail.com with ESMTPSA id\n\ts63sm14595787wms.18.2020.12.31.07.54.33\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 31 Dec 2020 07:54:34 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"bGl1bYKb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=JeKcmpfqab8zYgc9B7pPMg9/TDryKELzcuN4CWwnkkc=;\n\tb=bGl1bYKb6E/1Xz6guYvWt1eEjU2ZDKibgZ2ATtado99IZtafW7ypcSrG136mYQMHPq\n\toYWjGUFFuks3/aevRgql0DJDmCgZaPvC5T3rmW+lLe+0M2tYP1AehRW7BqjaQ9WX+jHG\n\tAltExtjliYRJc3QisSqwMevicB/42jQdISynHGvoGZhFOWh2yMqkQpCMGr1rbXjeRZ7C\n\txiw2u38d8delI411Me81OcKCHDhAg/AlwN7SkbySXH6Gftfq1xJikMswM92UrGdVBsJM\n\tdih0O0wMdQ7DLKK80FPH04+Kn3M+On7NWWDFZhDWlQlnFjhbyYIoQUZBm9lNyJbNQFLJ\n\t9sMA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=JeKcmpfqab8zYgc9B7pPMg9/TDryKELzcuN4CWwnkkc=;\n\tb=HiYV/dW7lMXC6vmLvakVy8pXZ/lFlJW2zk5r6/6pCTf7Eo49UTt71lr5OwZndn4cz6\n\taWN5xG7s4GM/ti1zHe7r6SqItYYnD7PmdxiOt0ph6gBD+wb7xT2yjKihZm3AdCe4vbLb\n\tjX0vY77xuyO8I+sMdT0fffEbtq4StjmfA7kQ1nRKvhSbVBvzGwAmO6gyE/Ho1kxAB8Bz\n\tpTVcGqHx1rhOMS+IoJI+BR5iPdWImbNmj/fAIYvXY1m4G2z1G3tElEWk7I8ciXR/No4u\n\tP02m1yIV2iqyX+l6UyAcOKmHggeqbBq42jSMlVIuNjh+9wUJ/HAusD+jN9UDGx8md4oC\n\tQYWQ==","X-Gm-Message-State":"AOAM533RoibtTLlq9excPUvy8Y750FBNd1OYLnUHQf0NDvDOBuIMArmJ\n\trjyfm1wubkADSHnVpfa/lQksSl5pN4U=","X-Google-Smtp-Source":"ABdhPJxOydR6C76iB4zmOYoxjMAXI82A1NM11Y4z645obukiGBNgpEug9oJBR8Qx+WiC58gWTh5WgQ==","X-Received":"by 2002:a7b:c246:: with SMTP id\n\tb6mr12520083wmj.154.1609430074585; \n\tThu, 31 Dec 2020 07:54:34 -0800 (PST)","From":"Sebastian Fricke ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 31 Dec 2020 16:53:35 +0100","Message-Id":"<20201231155336.7058-4-sebastian.fricke.linux@gmail.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201231155336.7058-1-sebastian.fricke.linux@gmail.com>","References":"<20201231155336.7058-1-sebastian.fricke.linux@gmail.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 3/4] libcamera: pipeline: rpi: Adjust\n\tto new implementation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Remove the construction of a BayerFormat from a V4L2PixelFormat through\nthe old constructor. Add the new 'fromV4L2PixelFormat' static member\nfunction.\n\nSigned-off-by: Sebastian Fricke \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex 7a5f5881..8ca9b9cf 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -358,7 +358,7 @@ CameraConfiguration::Status RPiCameraConfiguration::validate()\n \t\t\t */\n \t\t\tV4L2PixelFormat fourcc = sensorFormat.fourcc;\n \t\t\tif (data_->flipsAlterBayerOrder_) {\n-\t\t\t\tBayerFormat bayer(fourcc);\n+\t\t\t\tBayerFormat bayer = BayerFormat::fromV4L2PixelFormat(fourcc);\n \t\t\t\tbayer.order = data_->nativeBayerOrder_;\n \t\t\t\tbayer = bayer.transform(combined);\n \t\t\t\tfourcc = bayer.toV4L2PixelFormat();\n@@ -1007,7 +1007,7 @@ bool PipelineHandlerRPi::match(DeviceEnumerator *enumerator)\n \tBayerFormat bayerFormat;\n \tfor (const auto &iter : dev->formats()) {\n \t\tV4L2PixelFormat v4l2Format = iter.first;\n-\t\tbayerFormat = BayerFormat(v4l2Format);\n+\t\tbayerFormat = BayerFormat::fromV4L2PixelFormat(v4l2Format);\n \t\tif (bayerFormat.isValid())\n \t\t\tbreak;\n \t}\n","prefixes":["libcamera-devel","v2","3/4"]}