{"id":10792,"url":"https://patchwork.libcamera.org/api/1.1/patches/10792/?format=json","web_url":"https://patchwork.libcamera.org/patch/10792/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201231100218.1365123-1-niklas.soderlund@ragnatech.se>","date":"2020-12-31T10:02:18","name":"[libcamera-devel] android: camera_device: Only advertise RAW support if RAW16 is available","commit_ref":"35de31e0277142247ca37660ccf75fbaa213fd0e","pull_url":null,"state":"accepted","archived":false,"hash":"52c3d16c2adaccbd09dee7a2c44d3d8cc9aeada6","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/1.1/people/5/?format=json","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10792/mbox/","series":[{"id":1562,"url":"https://patchwork.libcamera.org/api/1.1/series/1562/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1562","date":"2020-12-31T10:02:18","name":"[libcamera-devel] android: camera_device: Only advertise RAW support if RAW16 is available","version":1,"mbox":"https://patchwork.libcamera.org/series/1562/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10792/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10792/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5FDE5C0F1A\n\tfor ;\n\tThu, 31 Dec 2020 10:02:27 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECA71615B2;\n\tThu, 31 Dec 2020 11:02:26 +0100 (CET)","from bin-mail-out-05.binero.net (bin-mail-out-05.binero.net\n\t[195.74.38.228])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B85776031A\n\tfor ;\n\tThu, 31 Dec 2020 11:02:25 +0100 (CET)","from bismarck.berto.se (p4fca2458.dip0.t-ipconnect.de\n\t[79.202.36.88])\n\tby bin-vsp-out-03.atm.binero.net (Halon) with ESMTPA\n\tid 45b6844f-4b4f-11eb-b73f-0050569116f7;\n\tThu, 31 Dec 2020 11:02:24 +0100 (CET)"],"X-Halon-ID":"45b6844f-4b4f-11eb-b73f-0050569116f7","Authorized-sender":"niklas.soderlund@fsdn.se","From":"=?utf-8?q?Niklas_S=C3=B6derlund?= ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 31 Dec 2020 11:02:18 +0100","Message-Id":"<20201231100218.1365123-1-niklas.soderlund@ragnatech.se>","X-Mailer":"git-send-email 2.29.2","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH] android: camera_device: Only advertise\n\tRAW support if RAW16 is available","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The HAL expects RAW16 support if the RAW capability is set, add a check\nfor this.\n\nSuggested-by: Jacopo Mondi \nSigned-off-by: Niklas Söderlund \n---\n src/android/camera_device.cpp | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex 7678d4485ce987b5..23be2a593a2aee5e 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -1099,7 +1099,9 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \tif (cameraConfig && !cameraConfig->empty()) {\n \t\tconst PixelFormatInfo &info =\n \t\t\tPixelFormatInfo::info(cameraConfig->at(0).pixelFormat);\n-\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW) {\n+\t\t/* Only advertise RAW support if RAW16 is possible. */\n+\t\tif (info.colourEncoding == PixelFormatInfo::ColourEncodingRAW &&\n+\t\t info.bitsPerPixel == 16) {\n \t\t\trawStreamAvailable = true;\n \t\t\tavailableCapabilities.push_back(ANDROID_REQUEST_AVAILABLE_CAPABILITIES_RAW);\n \t\t}\n","prefixes":["libcamera-devel"]}