{"id":10783,"url":"https://patchwork.libcamera.org/api/1.1/patches/10783/?format=json","web_url":"https://patchwork.libcamera.org/patch/10783/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201230180120.78407-6-jacopo@jmondi.org>","date":"2020-12-30T18:01:19","name":"[libcamera-devel,v3,5/6] libcamera: camera_sensor: Do not default 'rotation'","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"cf2f6c8fe5a35b9d4e532ce1e2fc1f4bed5b7f29","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10783/mbox/","series":[{"id":1560,"url":"https://patchwork.libcamera.org/api/1.1/series/1560/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1560","date":"2020-12-30T18:01:14","name":"libcamera: camera_sensor: Make validation more strict","version":3,"mbox":"https://patchwork.libcamera.org/series/1560/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10783/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10783/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26E60C0F1C\n\tfor ;\n\tWed, 30 Dec 2020 18:01:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A386662010;\n\tWed, 30 Dec 2020 19:01:17 +0100 (CET)","from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net\n\t[217.70.183.200])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5F5A760526\n\tfor ;\n\tWed, 30 Dec 2020 19:01:13 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay7-d.mail.gandi.net (Postfix) with ESMTPSA id 25E8020006\n\tfor ;\n\tWed, 30 Dec 2020 18:01:12 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 30 Dec 2020 19:01:19 +0100","Message-Id":"<20201230180120.78407-6-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20201230180120.78407-1-jacopo@jmondi.org>","References":"<20201230180120.78407-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 5/6] libcamera: camera_sensor: Do not\n\tdefault 'rotation'","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The 'rotation' property is not critical. Only register if the\nsensor driver reports it.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/camera_sensor.cpp | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)","diff":"diff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 1a316da45511..f7b20b396914 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -379,16 +379,11 @@ int CameraSensor::initProperties()\n \t}\n \tproperties_.set(properties::Location, propertyValue);\n \n-\t/* Camera Rotation: default is 0 degrees. */\n \tconst auto &rotationControl = controls.find(V4L2_CID_CAMERA_SENSOR_ROTATION);\n \tif (rotationControl != controls.end()) {\n \t\tpropertyValue = rotationControl->second.def().get();\n-\t} else {\n-\t\tpropertyValue = 0;\n-\t\tLOG(CameraSensor, Debug)\n-\t\t\t<< \"Rotation property defaulted to 0 degrees\";\n+\t\tproperties_.set(properties::Rotation, propertyValue);\n \t}\n-\tproperties_.set(properties::Rotation, propertyValue);\n \n \tproperties_.set(properties::PixelArraySize, pixelArraySize_);\n \tproperties_.set(properties::PixelArrayActiveAreas, { activeAreaSize_ });\n","prefixes":["libcamera-devel","v3","5/6"]}