{"id":10765,"url":"https://patchwork.libcamera.org/api/1.1/patches/10765/?format=json","web_url":"https://patchwork.libcamera.org/patch/10765/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201228165600.53987-6-jacopo@jmondi.org>","date":"2020-12-28T16:56:00","name":"[libcamera-devel,v2,5/5] libcamera: ipu3: Register sensor controls","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"6bbba357d9ef6da46235ef9fdd0d2f2690a9db28","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/1.1/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/10765/mbox/","series":[{"id":1558,"url":"https://patchwork.libcamera.org/api/1.1/series/1558/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1558","date":"2020-12-28T16:55:55","name":"libcamera: Calculate expoure time limits","version":2,"mbox":"https://patchwork.libcamera.org/series/1558/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10765/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10765/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 077B0C0F1C\n\tfor ;\n\tMon, 28 Dec 2020 16:55:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 699F06200D;\n\tMon, 28 Dec 2020 17:55:55 +0100 (CET)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 924DE6159A\n\tfor ;\n\tMon, 28 Dec 2020 17:55:52 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 28829100004;\n\tMon, 28 Dec 2020 16:55:51 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 28 Dec 2020 17:56:00 +0100","Message-Id":"<20201228165600.53987-6-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20201228165600.53987-1-jacopo@jmondi.org>","References":"<20201228165600.53987-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 5/5] libcamera: ipu3: Register sensor\n\tcontrols","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Register the sensor provided controls together with the pipeline\nhandler initialized controls.\n\nReviewed-by: Paul Elder \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/pipeline/ipu3/ipu3.cpp | 7 ++++++-\n 1 file changed, 6 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex f1151733d9fe..a745d163462d 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -777,7 +777,12 @@ int PipelineHandlerIPU3::registerCameras()\n \t\tdata->properties_ = cio2->sensor()->properties();\n \n \t\t/* Initialze the camera controls. */\n-\t\tdata->controlInfo_ = IPU3Controls;\n+\t\tControlInfoMap::Map controlsMap;\n+\t\tfor (const auto &it : IPU3Controls)\n+\t\t\tcontrolsMap[it.first] = it.second;\n+\t\tfor (const auto &it : cio2->sensor()->controls())\n+\t\t\tcontrolsMap[it.first] = it.second;\n+\t\tdata->controlInfo_ = std::move(controlsMap);\n \n \t\t/**\n \t\t * \\todo Dynamically assign ImgU and output devices to each\n","prefixes":["libcamera-devel","v2","5/5"]}