{"id":10764,"url":"https://patchwork.libcamera.org/api/1.1/patches/10764/?format=json","web_url":"https://patchwork.libcamera.org/patch/10764/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201228165600.53987-5-jacopo@jmondi.org>","date":"2020-12-28T16:55:59","name":"[libcamera-devel,v2,4/5] libcamera: camera_sensor: Add controls() method","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"098d8483807d4f795a15c15f57857b0f994ca6c2","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/1.1/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/10764/mbox/","series":[{"id":1558,"url":"https://patchwork.libcamera.org/api/1.1/series/1558/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1558","date":"2020-12-28T16:55:55","name":"libcamera: Calculate expoure time limits","version":2,"mbox":"https://patchwork.libcamera.org/series/1558/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10764/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10764/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AD697C0F1A\n\tfor ;\n\tMon, 28 Dec 2020 16:55:55 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4925B6200A;\n\tMon, 28 Dec 2020 17:55:55 +0100 (CET)","from relay11.mail.gandi.net (relay11.mail.gandi.net\n\t[217.70.178.231])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 04A9661D25\n\tfor ;\n\tMon, 28 Dec 2020 17:55:51 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay11.mail.gandi.net (Postfix) with ESMTPSA id 8C17810000A;\n\tMon, 28 Dec 2020 16:55:51 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 28 Dec 2020 17:55:59 +0100","Message-Id":"<20201228165600.53987-5-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20201228165600.53987-1-jacopo@jmondi.org>","References":"<20201228165600.53987-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 4/5] libcamera: camera_sensor: Add\n\tcontrols() method","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add a controls() method to retrieve the map of libcamera controls\nregistered by the CameraSensor class.\n\nReviewed-by: Paul Elder \nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/internal/camera_sensor.h | 1 +\n src/libcamera/camera_sensor.cpp | 6 ++++++\n 2 files changed, 7 insertions(+)","diff":"diff --git a/include/libcamera/internal/camera_sensor.h b/include/libcamera/internal/camera_sensor.h\nindex 841c7f4bef0f..10877b9d1d9d 100644\n--- a/include/libcamera/internal/camera_sensor.h\n+++ b/include/libcamera/internal/camera_sensor.h\n@@ -62,6 +62,7 @@ public:\n \tint setControls(ControlList *ctrls);\n \n \tconst ControlList &properties() const { return properties_; }\n+\tconst ControlInfoMap &controls() const { return controls_; }\n \tint sensorInfo(CameraSensorInfo *info) const;\n \n protected:\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 337d73c524bf..ea57943647b1 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -653,6 +653,12 @@ ControlList CameraSensor::getControls(const std::vector &ids)\n * \\return The list of camera sensor properties\n */\n \n+/**\n+ * \\fn CameraSensor::controls()\n+ * \\brief Retrieve the camera sensor controls info\n+ * \\return The map of camera sensor controls info\n+ */\n+\n /**\n * \\brief Write controls to the sensor\n * \\param[in] ctrls The list of controls to write\n","prefixes":["libcamera-devel","v2","4/5"]}