{"id":10755,"url":"https://patchwork.libcamera.org/api/1.1/patches/10755/?format=json","web_url":"https://patchwork.libcamera.org/patch/10755/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201228164003.53051-6-jacopo@jmondi.org>","date":"2020-12-28T16:40:03","name":"[libcamera-devel,v2,5/5] android: camera_device: Simplify properties.get()","commit_ref":"0ed053245702d193b9c0ad7d8bda9e975ddfb6ed","pull_url":null,"state":"accepted","archived":false,"hash":"1f13c30ebf3d20e5f822564a1f05faae308e1e5b","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/1.1/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/10755/mbox/","series":[{"id":1556,"url":"https://patchwork.libcamera.org/api/1.1/series/1556/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1556","date":"2020-12-28T16:39:58","name":"android: support ColorFilterArrangement property","version":2,"mbox":"https://patchwork.libcamera.org/series/1556/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10755/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10755/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CB201C0F1C\n\tfor ;\n\tMon, 28 Dec 2020 16:39:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 808F362007;\n\tMon, 28 Dec 2020 17:39:59 +0100 (CET)","from relay1-d.mail.gandi.net (relay1-d.mail.gandi.net\n\t[217.70.183.193])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AFFAF61FFA\n\tfor ;\n\tMon, 28 Dec 2020 17:39:56 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 1D30124001A;\n\tMon, 28 Dec 2020 16:39:55 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Mon, 28 Dec 2020 17:40:03 +0100","Message-Id":"<20201228164003.53051-6-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.29.2","In-Reply-To":"<20201228164003.53051-1-jacopo@jmondi.org>","References":"<20201228164003.53051-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 5/5] android: camera_device: Simplify\n\tproperties.get()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"When accessing the value of a property by reading the properties\nControlList content with ControlList::get<>() it is not necessary to\nspecify the template type as it is already conveyed by the Control\ninstance provided as first argument.\n\nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \nSigned-off-by: Jacopo Mondi \n---\n src/android/camera_device.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex bbf016c323a7..7678d4485ce9 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -853,7 +853,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \t/* Sensor static metadata. */\n \tif (properties.contains(properties::PixelArraySize)) {\n \t\tconst Size &size =\n-\t\t\tproperties.get(properties::PixelArraySize);\n+\t\t\tproperties.get(properties::PixelArraySize);\n \t\tstd::vector data{\n \t\t\tstatic_cast(size.width),\n \t\t\tstatic_cast(size.height),\n@@ -872,7 +872,7 @@ const camera_metadata_t *CameraDevice::getStaticMetadata()\n \n \tif (properties.contains(properties::PixelArrayActiveAreas)) {\n \t\tconst Span &rects =\n-\t\t\tproperties.get>(properties::PixelArrayActiveAreas);\n+\t\t\tproperties.get(properties::PixelArrayActiveAreas);\n \t\tstd::vector data{\n \t\t\tstatic_cast(rects[0].x),\n \t\t\tstatic_cast(rects[0].y),\n","prefixes":["libcamera-devel","v2","5/5"]}