{"id":10738,"url":"https://patchwork.libcamera.org/api/1.1/patches/10738/?format=json","web_url":"https://patchwork.libcamera.org/patch/10738/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201224122855.22200-3-laurent.pinchart@ideasonboard.com>","date":"2020-12-24T12:28:49","name":"[libcamera-devel,2/8] utils: checkstyle.py: Factor out automatic class registry","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"40ad580e1888f72d3f0f76cbe3a9c3a9feb1694f","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/1.1/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/10738/mbox/","series":[{"id":1550,"url":"https://patchwork.libcamera.org/api/1.1/series/1550/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1550","date":"2020-12-24T12:28:47","name":"checkstyle.py: Ensure meson.build is updated when adding header","version":1,"mbox":"https://patchwork.libcamera.org/series/1550/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10738/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10738/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 08C5CC0F1A\n\tfor ;\n\tThu, 24 Dec 2020 12:29:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CCD78615B0;\n\tThu, 24 Dec 2020 13:29:12 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC52160528\n\tfor ;\n\tThu, 24 Dec 2020 13:29:08 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4CC2FA1D\n\tfor ;\n\tThu, 24 Dec 2020 13:29:08 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fVnESeqV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608812948;\n\tbh=9n2XxMWv5HmxGxi11lL7HODHwJPLMDLZV43LTTuKVIM=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fVnESeqVkqv5Ffmx7TYDJ/Ys8uW1AQaMz6K9dmUNE8FuIjPYgt4AVtBJsWrUbzxeR\n\tFWQGfddwHOwAiBIgghhhdWAa/psdw/XhoC0OODOvflyv7L8OLeI9OAKFUuQ6ZneTBD\n\tm0MOakVxlkGc5SlQ7di/ZR2vbXzrMqwYnjffwPDo=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 24 Dec 2020 14:28:49 +0200","Message-Id":"<20201224122855.22200-3-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201224122855.22200-1-laurent.pinchart@ideasonboard.com>","References":"<20201224122855.22200-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/8] utils: checkstyle.py: Factor out\n\tautomatic class registry","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The style checkers and formatters duplicate automatic class registry\ncode. Factor it out to a common ClassRegistry helper class. The list of\nsubclasses is moved to a class member variable of the auto-registered\nbase class type.\n\nSigned-off-by: Laurent Pinchart \n---\n utils/checkstyle.py | 45 ++++++++++++++++++++-------------------------\n 1 file changed, 20 insertions(+), 25 deletions(-)","diff":"diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex c04bf3850dcd..76267d5ea764 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -190,21 +190,25 @@ def parse_diff(diff):\n return hunks\n \n \n+# ------------------------------------------------------------------------------\n+# Helpers\n+#\n+\n+class ClassRegistry(type):\n+ def __new__(cls, clsname, bases, attrs):\n+ newclass = super().__new__(cls, clsname, bases, attrs)\n+ if bases:\n+ bases[0].subclasses.append(newclass)\n+ return newclass\n+\n+\n # ------------------------------------------------------------------------------\n # Style Checkers\n #\n \n-_style_checkers = []\n+class StyleChecker(metaclass=ClassRegistry):\n+ subclasses = []\n \n-class StyleCheckerRegistry(type):\n- def __new__(cls, clsname, bases, attrs):\n- newclass = super().__new__(cls, clsname, bases, attrs)\n- if clsname != 'StyleChecker':\n- _style_checkers.append(newclass)\n- return newclass\n-\n-\n-class StyleChecker(metaclass=StyleCheckerRegistry):\n def __init__(self):\n pass\n \n@@ -213,7 +217,7 @@ class StyleChecker(metaclass=StyleCheckerRegistry):\n #\n @classmethod\n def checkers(cls, filename):\n- for checker in _style_checkers:\n+ for checker in cls.subclasses:\n if checker.supports(filename):\n yield checker\n \n@@ -227,7 +231,7 @@ class StyleChecker(metaclass=StyleCheckerRegistry):\n @classmethod\n def all_patterns(cls):\n patterns = set()\n- for checker in _style_checkers:\n+ for checker in cls.subclasses:\n patterns.update(checker.patterns)\n \n return patterns\n@@ -383,18 +387,9 @@ class ShellChecker(StyleChecker):\n # Formatters\n #\n \n-_formatters = []\n-\n-class FormatterRegistry(type):\n- def __new__(cls, clsname, bases, attrs):\n- newclass = super().__new__(cls, clsname, bases, attrs)\n- if clsname != 'Formatter':\n- _formatters.append(newclass)\n- return newclass\n-\n-\n-class Formatter(metaclass=FormatterRegistry):\n+class Formatter(metaclass=ClassRegistry):\n enabled = True\n+ subclasses = []\n \n def __init__(self):\n pass\n@@ -404,7 +399,7 @@ class Formatter(metaclass=FormatterRegistry):\n #\n @classmethod\n def formatters(cls, filename):\n- for formatter in _formatters:\n+ for formatter in cls.subclasses:\n if not cls.enabled:\n continue\n if formatter.supports(filename):\n@@ -422,7 +417,7 @@ class Formatter(metaclass=FormatterRegistry):\n @classmethod\n def all_patterns(cls):\n patterns = set()\n- for formatter in _formatters:\n+ for formatter in cls.subclasses:\n if not cls.enabled:\n continue\n patterns.update(formatter.patterns)\n","prefixes":["libcamera-devel","2/8"]}