{"id":10695,"url":"https://patchwork.libcamera.org/api/1.1/patches/10695/?format=json","web_url":"https://patchwork.libcamera.org/patch/10695/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201222135849.38052-3-kieran.bingham@ideasonboard.com>","date":"2020-12-22T13:58:49","name":"[libcamera-devel,2/2] libcamera: file: Check files exist()","commit_ref":"0a823785fad27e1eb9a900e80923bc9bde106de9","pull_url":null,"state":"accepted","archived":false,"hash":"93b97cc3cf248aa370867b59e31ad55eba32c15a","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/1.1/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/10695/mbox/","series":[{"id":1540,"url":"https://patchwork.libcamera.org/api/1.1/series/1540/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1540","date":"2020-12-22T13:58:47","name":"libcamera: file: Don't parse directories","version":1,"mbox":"https://patchwork.libcamera.org/series/1540/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10695/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10695/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0EAC1C0F1A\n\tfor ;\n\tTue, 22 Dec 2020 13:58:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 42A45615B0;\n\tTue, 22 Dec 2020 14:58:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2D6E6615AC\n\tfor ;\n\tTue, 22 Dec 2020 14:58:55 +0100 (CET)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B9B89122D;\n\tTue, 22 Dec 2020 14:58:54 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"n1+azX+g\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1608645534;\n\tbh=R4Wh/zlrA6x3NiPzgk5P/f3VImanYz6p9nc32FLlknA=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=n1+azX+gvZQLN07jOhMLMfuQ1C+gqw+B16UeNwfUtiWJGK7zul8aI6pAcqGHV+O6R\n\tCUmC9+slT204qWGnFjmsC/h8dQqF1hVvqZUPQZbEvp1xxLzP/+7TU04o85BkCVYEy+\n\tfi7EzXu5ksfoYhtoIcu53EMlDYs/cxuoE0cI0QVE=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Tue, 22 Dec 2020 13:58:49 +0000","Message-Id":"<20201222135849.38052-3-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201222135849.38052-1-kieran.bingham@ideasonboard.com>","References":"<20201222135849.38052-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/2] libcamera: file: Check files exist()","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Ensure that when we check for existence with File() it will only\nreturn if the path leads to a file, and not a directory.\n\nDevice nodes which could still be opened by this class are still supported.\n\nSigned-off-by: Kieran Bingham \n---\n src/libcamera/file.cpp | 3 ++-\n 1 file changed, 2 insertions(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\nindex 3a3f5bb63ffc..bce2b6138239 100644\n--- a/src/libcamera/file.cpp\n+++ b/src/libcamera/file.cpp\n@@ -458,7 +458,8 @@ bool File::exists(const std::string &name)\n \tif (ret < 0)\n \t\treturn false;\n \n-\treturn true;\n+\t/* Directories can not be handled here, even if they exist. */\n+\treturn !S_ISDIR(st.st_mode);\n }\n \n } /* namespace libcamera */\n","prefixes":["libcamera-devel","2/2"]}