{"id":10648,"url":"https://patchwork.libcamera.org/api/1.1/patches/10648/?format=json","web_url":"https://patchwork.libcamera.org/patch/10648/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201211154525.5141-1-naush@raspberrypi.com>","date":"2020-12-11T15:45:23","name":"[libcamera-devel,v8,1/3] libcamera: controls: Add frame duration control","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"00e10dcde697c49ecfac78f9d944cd5a240b53da","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/1.1/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/1.1/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/10648/mbox/","series":[{"id":1527,"url":"https://patchwork.libcamera.org/api/1.1/series/1527/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1527","date":"2020-12-11T15:45:23","name":"[libcamera-devel,v8,1/3] libcamera: controls: Add frame duration control","version":8,"mbox":"https://patchwork.libcamera.org/series/1527/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10648/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10648/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9ACF9BD80A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri, 11 Dec 2020 15:45:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E458C67FA5;\n\tFri, 11 Dec 2020 16:45:32 +0100 (CET)","from mail-wr1-x42b.google.com (mail-wr1-x42b.google.com\n\t[IPv6:2a00:1450:4864:20::42b])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 86D3B67F06\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 11 Dec 2020 16:45:30 +0100 (CET)","by mail-wr1-x42b.google.com with SMTP id r7so9490929wrc.5\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri, 11 Dec 2020 07:45:30 -0800 (PST)","from naushir-VirtualBox.patuck.local ([88.97.76.4])\n\tby smtp.gmail.com with ESMTPSA id\n\t89sm16281248wre.51.2020.12.11.07.45.28\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tFri, 11 Dec 2020 07:45:29 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"XIQaKFbj\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=gH8HMYcOquTPDuesHKOTcqJ/C07iagYJVPlUMXZ+2JM=;\n\tb=XIQaKFbjJervKr5MKTd08z7SEDAvlrU1Jd2iuIvfPwQklcpbjbVb4cxSF2rnL7YHTP\n\tAPM2TNTF7jFgyqh5wDQaWS0VGYuzS7lu/dc/2J8W9r3mKgDr2zy8/cISCQtxYTJQckAt\n\t6doHIxEZnkJhITsPHiA4xozTnIaPY6mIzIhRQbqoqjMmO/Vu4ycF+Pp56bcLCqKOiwdQ\n\t+AhUAxSRfm5URC4KF6rSk/G01Ry1mkV4n2it+SDxDMW+Y8qwQa0mDxOw0P+6wu5JMMu7\n\tMwk78csnv/VlmXLHaBoRbho8GO3zdjyWhOHSiqt0hT2cvQebLdnpnByM5rTgrwjCW8DA\n\tmmXQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version\n\t:content-transfer-encoding;\n\tbh=gH8HMYcOquTPDuesHKOTcqJ/C07iagYJVPlUMXZ+2JM=;\n\tb=dfgq7HeMKC5rrEAJKjfTLFID37yTrv0AeX+n+B+NIhOH54BDTSOYFQH2Z+qceMicbj\n\tM6JpRkwsGYFxDUF3JkYK7F7KuzEu1af2wf0DLn6jys2DzWvX2RJHsvH3HYF5zNGSFJVJ\n\tBBkWKdQOI8tHlSBa0v/uGMa8h0vF9t3ZMUUUo/rW92W85HP3xHFHQGtX7JjIS3svLmXL\n\tNV1ztv78GvYeFjZZl62qJP6sFugVvpwhP8qgF2ZsiyxxrsS30W9X+/zNLX8GL65eS2Wz\n\tCGokB6y5dZo3IA60+djxoLCOO7RSkipcDo8TKKRooTZONuFLgjRNCKpZOLmcW9wzWItr\n\t9kxw==","X-Gm-Message-State":"AOAM532jTtHzmwSePoKsQz6o9mHKNzHoqn4/1/7ZYmdThoznDVWCQBLn\n\tiy6qqOWWEpq5+CiE1f6z2K/c1hyTIf5mNQ==","X-Google-Smtp-Source":"ABdhPJxXRpTTMpqUWZ75lnIRORAdDQhKaTUPCR2QNME2WZcLVVdOAUa1JDd4Bi/V29VIXJAKaVQNCw==","X-Received":"by 2002:adf:eac7:: with SMTP id o7mr14865231wrn.23.1607701529768;\n\tFri, 11 Dec 2020 07:45:29 -0800 (PST)","From":"Naushir Patuck <naush@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 11 Dec 2020 15:45:23 +0000","Message-Id":"<20201211154525.5141-1-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.25.1","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v8 1/3] libcamera: controls: Add frame\n\tduration control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"Add an int64_t array control (controls::FrameDurations) to specify the\nminimum and maximum (in that order) frame duration to be used by the\ncamera sensor.\n\nSigned-off-by: Naushir Patuck <naush@raspberrypi.com>\nReviewed-by: David Plowman <david.plowman@raspberrypi.com>\nTested-by: David Plowman <david.plowman@raspberrypi.com>\nReviewed-by: Jacopo Mondi <jacopo@jmondi.org>\n---\n src/libcamera/control_ids.yaml | 40 ++++++++++++++++++++++++++++++++++\n 1 file changed, 40 insertions(+)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 6d6f0fee..43a7cfb7 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -306,6 +306,46 @@ controls:\n         maximum valid value is given by the properties::ScalerCropMaximum\n         property, and the two can be used to implement digital zoom.\n \n+  - FrameDurations:\n+      type: int64_t\n+      description: |\n+          The minimum and maximum (in that order) frame duration,\n+          expressed in micro-seconds.\n+\n+          When provided by applications, the control specifies the sensor frame\n+          duration interval the pipeline has to use. This could also limit the\n+          largest exposure time the sensor can use. For example, if a maximum\n+          frame duration of 33ms is requested (corresponding to 30 frames per\n+          second), the sensor will not be able to raise the exposure time above\n+          33ms. A fixed frame duration is achieved by setting the minimum and\n+          maximum values to be the same.\n+\n+          The maximum frame duration provides the absolute limit to the shutter\n+          speed computed by the AE algorithm and it overrides any exposure mode\n+          setting specified with controls::AeExposureMode. Similarly, when a\n+          manual exposure time is set through controls::ExposureTime, it also\n+          gets clipped to the limits set by this control.\n+\n+          \\sa AeExposureMode\n+          \\sa ExposureTime\n+\n+          \\todo Refer to the frame duration limits property to describe how\n+          application-provided values gets clipped and reset.\n+\n+          When reported by pipelines, the control expresses the duration of the\n+          sensor frame used to produce streams part of the completed Request.\n+          The minimum and maximum values shall then be the same, as the sensor\n+          frame duration is a fixed parameter. The sensor frame duration is one\n+          of the parameter that defines the capture frame rate but it does not\n+          alone provide enough information to fully calculate it as it does not\n+          account for pipeline processing delays.\n+\n+          \\todo Define how to calculate the capture frame rate by\n+          defining controls to report additional delays introduced by\n+          the capture pipeline or post-processing stages (ie JPEG\n+          conversion, frame scaling).\n+      size: [2]\n+\n   # ----------------------------------------------------------------------------\n   # Draft controls section\n \n","prefixes":["libcamera-devel","v8","1/3"]}