{"id":10573,"url":"https://patchwork.libcamera.org/api/1.1/patches/10573/?format=json","web_url":"https://patchwork.libcamera.org/patch/10573/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201205103106.242080-11-paul.elder@ideasonboard.com>","date":"2020-12-05T10:30:53","name":"[libcamera-devel,v5,10/23] ipa: raspberrypi: meson: Add dependency on generated headers","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"5bc04260f220ba5dbaf70b8d89c545bc145fb943","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/people/17/?format=json","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"delegate":{"id":17,"url":"https://patchwork.libcamera.org/api/1.1/users/17/?format=json","username":"epaul","first_name":"Paul","last_name":"Elder","email":"paul.elder@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/10573/mbox/","series":[{"id":1506,"url":"https://patchwork.libcamera.org/api/1.1/series/1506/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1506","date":"2020-12-05T10:30:43","name":"IPA isolation implementation","version":5,"mbox":"https://patchwork.libcamera.org/series/1506/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10573/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10573/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id ABE6EBDB20\n\tfor <parsemail@patchwork.libcamera.org>;\n\tSat,  5 Dec 2020 10:31:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 75FAC635F9;\n\tSat,  5 Dec 2020 11:31:39 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EBEF7635FB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tSat,  5 Dec 2020 11:31:37 +0100 (CET)","from pyrite.rasen.tech (unknown\n\t[IPv6:2400:4051:61:600:2c71:1b79:d06d:5032])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2FD8799A;\n\tSat,  5 Dec 2020 11:31:35 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Cl5h7gWF\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1607164297;\n\tbh=RRx9xl/91/IVTkOarnqD3GRyWNfIE1WRL6m37UNG23M=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=Cl5h7gWFRLrJj3RzhRv2NpzMejifu5/6+DzAWD6whgXKmUE5orJKigVAkBgev55Rh\n\tg0SWeHiYEWWL085v7HIoYaQ2l/I6Dg6sPG50LcapzNdG9WtxLay1PxCvQ5ARLQ7tEK\n\trswGifvncWzmfmhomsn8M/CmNT9WkiMg21qPbAXA=","From":"Paul Elder <paul.elder@ideasonboard.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Sat,  5 Dec 2020 19:30:53 +0900","Message-Id":"<20201205103106.242080-11-paul.elder@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201205103106.242080-1-paul.elder@ideasonboard.com>","References":"<20201205103106.242080-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 10/23] ipa: raspberrypi: meson: Add\n\tdependency on generated headers","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"The raspberrypi IPA will depend on the raspberrypi IPA header generated\nfrom the mojo definition file. Add the dependency. Simply add all\ngenerated headers as a dependency, instead of walking the list of\nheaders, to simplify the implementation. This will have the effect of\ngenerating all headers before compiling the IPA, which has no drawbacks.\n\nSigned-off-by: Paul Elder <paul.elder@ideasonboard.com>\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n---\nNo change in v5\n\nChanges in v4:\n- rename libcamera_generated_headers to libcamera_generated_ipa_headers\n\nChanges in v3:\n- expand changelog\n\nNew in v2\n---\n src/ipa/raspberrypi/meson.build | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/raspberrypi/meson.build b/src/ipa/raspberrypi/meson.build\nindex 9445cd09..4331f718 100644\n--- a/src/ipa/raspberrypi/meson.build\n+++ b/src/ipa/raspberrypi/meson.build\n@@ -42,7 +42,7 @@ rpi_ipa_sources = files([\n ])\n \n mod = shared_module(ipa_name,\n-                    rpi_ipa_sources,\n+                    [rpi_ipa_sources, libcamera_generated_ipa_headers],\n                     name_prefix : '',\n                     include_directories : rpi_ipa_includes,\n                     dependencies : rpi_ipa_deps,\n","prefixes":["libcamera-devel","v5","10/23"]}