{"id":10546,"url":"https://patchwork.libcamera.org/api/1.1/patches/10546/?format=json","web_url":"https://patchwork.libcamera.org/patch/10546/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201202115253.14705-6-david.plowman@raspberrypi.com>","date":"2020-12-02T11:52:53","name":"[libcamera-devel,5/5] src: ipa: raspberrypi: Drop the correct number of frames on startup for ov5647","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"0aaa125dfa5d3760d5085b2369f849e791a63853","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10546/mbox/","series":[{"id":1500,"url":"https://patchwork.libcamera.org/api/1.1/series/1500/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1500","date":"2020-12-02T11:52:48","name":"Raspberry Pi AGC: initial frame drop count","version":1,"mbox":"https://patchwork.libcamera.org/series/1500/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10546/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10546/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 69837BE177\n\tfor ;\n\tWed, 2 Dec 2020 11:53:05 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 374A2635AB;\n\tWed, 2 Dec 2020 12:53:05 +0100 (CET)","from mail-wm1-x342.google.com (mail-wm1-x342.google.com\n\t[IPv6:2a00:1450:4864:20::342])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0C8DC635AB\n\tfor ;\n\tWed, 2 Dec 2020 12:53:03 +0100 (CET)","by mail-wm1-x342.google.com with SMTP id v14so6444035wml.1\n\tfor ;\n\tWed, 02 Dec 2020 03:53:03 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tn189sm1739215wmf.20.2020.12.02.03.53.01\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 02 Dec 2020 03:53:01 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"gG2P9mer\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=kS/s/B8ia6i0CSyDvuDHlL2Gy/xkSTrmSZjKbtjVXbg=;\n\tb=gG2P9merZaUHHaorMfRGiLiKXNAzctRxKqwkpC5NQmGo1ZtVVxGnAnJ1nyRtoZUpDz\n\t0LdlDf2Qhh/daq7K8cfruJEwX6HaqTFTOSRtmisA7NkwPzcD47Vc/RXQczt+2x0SCJHD\n\t8yjhgTb57t6AEY4YOhIJU+TPMeCLW6B9h40lSr5RnZxQs4uXJAvMdiEaf3NWKxKSIqfF\n\tDwU4C/0+4HlOOHHIxqicOjhla9WjwihhwaL1+lqI6sASIG9Q/ozIxLJDpTJedllpX3Nc\n\tsSSi+JWhhuX/ApM/Q2VlKM6cRRaQ/Ht8pWU3bp9luHXWIYBI1sZorLhSVLM+oxMXoK87\n\tDhKw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=kS/s/B8ia6i0CSyDvuDHlL2Gy/xkSTrmSZjKbtjVXbg=;\n\tb=sivqxDFqwy7PUxBpbwyvwX2DRotV+LwDFiSHiNFNHuOjer/Wpc8KS02Nd3rQwpMF7L\n\tO4T/bIwQIvOMU66vPMCNJ8okFq3At9KdY8dgtZ33j9ngnK2qTVpNUj7NQH3DMst0K/Yr\n\tTy5LwSg6M0KXNpQexIxLEu7rr6po8Sx4AufvXWMJVHc6MI+fIAH7sKSvWMykVp6uvFEL\n\tW/phaT5h5Knm0QCMs/ocySp8TpGcrjQxbigr60thk/yXdXmBuRV/Z0vasBVACZkx38j5\n\tfJQe4WEwlVdTT3usn19Qv/iQTA4HIuh4wSOHHtgFT1MUBWzAWiOvh2kmfMBTzeAZO05i\n\tV9DA==","X-Gm-Message-State":"AOAM530Na7LpfOYNj2mUyQOeyOsc1vdLiGzrXV8uUhDuxW/6OSL1j7v+\n\t+5bD6AcOiAkRUnIzFJUHT2ZlWaHuqD9gF0ET","X-Google-Smtp-Source":"ABdhPJzEcROacJ/pNddkUw4e6zMh+ntUCPWBz9VMZPU6U3hCf7KHMJlCx2mnYNEYEbOkXrPGQkiV/g==","X-Received":"by 2002:a05:600c:22d9:: with SMTP id\n\t25mr2735364wmg.158.1606909982531; \n\tWed, 02 Dec 2020 03:53:02 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 2 Dec 2020 11:52:53 +0000","Message-Id":"<20201202115253.14705-6-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20201202115253.14705-1-david.plowman@raspberrypi.com>","References":"<20201202115253.14705-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 5/5] src: ipa: raspberrypi: Drop the\n\tcorrect number of frames on startup for ov5647","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The ov5647 delivers two under-exposed frames at startup, even when\nthe exposure and gain are explicitly programmed. The system needs to\nbe told to drop these.\n\nSigned-off-by: David Plowman \n---\n src/ipa/raspberrypi/cam_helper_ov5647.cpp | 10 ++++++++++\n 1 file changed, 10 insertions(+)","diff":"diff --git a/src/ipa/raspberrypi/cam_helper_ov5647.cpp b/src/ipa/raspberrypi/cam_helper_ov5647.cpp\nindex dc5d8275..0b841cd1 100644\n--- a/src/ipa/raspberrypi/cam_helper_ov5647.cpp\n+++ b/src/ipa/raspberrypi/cam_helper_ov5647.cpp\n@@ -19,6 +19,7 @@ public:\n \tuint32_t GainCode(double gain) const override;\n \tdouble Gain(uint32_t gain_code) const override;\n \tvoid GetDelays(int &exposure_delay, int &gain_delay) const override;\n+\tunsigned int HideFramesStartup() const override;\n \tunsigned int HideFramesModeSwitch() const override;\n \tunsigned int MistrustFramesStartup() const override;\n \tunsigned int MistrustFramesModeSwitch() const override;\n@@ -54,6 +55,15 @@ void CamHelperOv5647::GetDelays(int &exposure_delay, int &gain_delay) const\n \tgain_delay = 2;\n }\n \n+unsigned int CamHelperOv5647::HideFramesStartup() const\n+{\n+\t/*\n+\t * On startup, we get a couple of under-exposed frames which\n+\t * we don't want shown.\n+\t */\n+\treturn 2;\n+}\n+\n unsigned int CamHelperOv5647::HideFramesModeSwitch() const\n {\n \t/*\n","prefixes":["libcamera-devel","5/5"]}