{"id":10539,"url":"https://patchwork.libcamera.org/api/1.1/patches/10539/?format=json","web_url":"https://patchwork.libcamera.org/patch/10539/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201201175536.11093-5-david.plowman@raspberrypi.com>","date":"2020-12-01T17:55:35","name":"[libcamera-devel,v4,4/5] libcamera: controls: Improve documentation for ExposureTime and AnalogueGain","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9f8f2b3d833c72bd7cb5f58987ecc733e49b44dd","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10539/mbox/","series":[{"id":1499,"url":"https://patchwork.libcamera.org/api/1.1/series/1499/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1499","date":"2020-12-01T17:55:31","name":"Raspberry Pi AGC improvements","version":4,"mbox":"https://patchwork.libcamera.org/series/1499/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10539/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10539/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CC263BE176\n\tfor ;\n\tTue, 1 Dec 2020 17:55:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 8C4DD6350D;\n\tTue, 1 Dec 2020 18:55:48 +0100 (CET)","from mail-wm1-x343.google.com (mail-wm1-x343.google.com\n\t[IPv6:2a00:1450:4864:20::343])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id CFE5263504\n\tfor ;\n\tTue, 1 Dec 2020 18:55:46 +0100 (CET)","by mail-wm1-x343.google.com with SMTP id a3so7527847wmb.5\n\tfor ;\n\tTue, 01 Dec 2020 09:55:46 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tl3sm438561wrr.89.2020.12.01.09.55.45\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 01 Dec 2020 09:55:45 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"uAOnLemO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=COAYMNMqiriqFstPxQ8fW7J1G1dQjwxxt6BNNdSn0zg=;\n\tb=uAOnLemOMv9cCrK2L30Dhi+PAXj2/wLjqUkqGYVcH9sJvtBRxMLxGV7xjUDtEPuINT\n\tzStzu67nSJTn7Sik4y9sZSociIzbG+73fShG1IZI2FeZ+Dq1OEwTSavlM9LoQWEuANxb\n\teeVn51cnU40TMZGISlMvSovn3zAVRAdjZp5RLeTGDkqJM6gQ+xku7SHhI+GQGekVPNRs\n\t6EUEC+/eOKLezUKRpE51ZCsLXNRDmrHZf1dOILuN9kYXeY7F7SRYZ9njyBvF6cF44CkP\n\ttEdjSxiU1G2fJdDsmQFbtscrmj+YvbGzMDrdy9qJf2Cb2tyLDo6iHF8DJDHKJfQM0SRQ\n\tdCGw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=COAYMNMqiriqFstPxQ8fW7J1G1dQjwxxt6BNNdSn0zg=;\n\tb=tXdlXXXAMfM44Ubl+bp/U6cL1bCBvz/6zNgAfWwCwna4t2t4dmRQFjnVE7+ioSiShL\n\tHXgSuY9OoQo0r8sNpTgwK0sOOgQoNqljc+9ah/0/Yf51mTW+Ckmbnuu44h3qbt9iCKLR\n\tGKGcjar06fEwD+SUUTN+2msJzfu1F9xIFBaovwlKMkvC5RmBL4EllpMgdsoFqIrFYKGX\n\tckgdXtxlttp/fIzICiTOa1ggWH22DO/FpdowOCdsvUuYUgvtISATqm/OfQAZisc0QF2w\n\tjICA1ZSwAD5chC4bRHBMqJcBlNXchCtHDKEl2AewqDzj/fPUhIE/AvNHonawSCfcUv1u\n\t5mHA==","X-Gm-Message-State":"AOAM531KUqciA++1diyuPRQaala6G/w1H7F7pT032ZYYIeC3KLpXLV4u\n\tv+73Tz+LGpms+6QAZ6Zeh8r4vm00NpbwRA5B","X-Google-Smtp-Source":"ABdhPJyRSnLpVeUDEufytiHV+lBOzxbHL0vKnglAlEz0awiTM4qMzVJKqhPooqxwmLBdyY6hriCv6Q==","X-Received":"by 2002:a1c:e0d4:: with SMTP id\n\tx203mr4040602wmg.68.1606845346340; \n\tTue, 01 Dec 2020 09:55:46 -0800 (PST)","From":"David Plowman ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 1 Dec 2020 17:55:35 +0000","Message-Id":"<20201201175536.11093-5-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20201201175536.11093-1-david.plowman@raspberrypi.com>","References":"<20201201175536.11093-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 4/5] libcamera: controls: Improve\n\tdocumentation for ExposureTime and AnalogueGain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Setting these controls \"fixes\" them and the AE may not change them;\nsetting them back to zero returns them to the control of the AE\nalgorithm.\n\nSigned-off-by: David Plowman \n---\n src/libcamera/control_ids.yaml | 14 ++++++++++++++\n 1 file changed, 14 insertions(+)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex a883e27e..fba1f545 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -125,8 +125,15 @@ controls:\n Exposure time (shutter speed) for the frame applied in the sensor\n device. This value is specified in micro-seconds.\n \n+ Setting this value means that it is now fixed and the AE algorithm may\n+ not change it. Setting it back to zero returns it to the control of the\n+ AE algorithm.\n+\n \\sa AnalogueGain AeEnable\n \n+ \\todo Consider how setting the exposure time interacts with other AE\n+ features, such as aperture, aperture/shutter priority modes etc.\n+\n - AnalogueGain:\n type: float\n description: |\n@@ -134,8 +141,15 @@ controls:\n The value of the control specifies the gain multiplier applied to all\n colour channels. This value cannot be lower than 1.0.\n \n+ Setting this value means that it is now fixed and the AE algorithm may\n+ not change it. Setting it back to zero returns it to the control of the\n+ AE algorithm.\n+\n \\sa ExposureTime AeEnable\n \n+ \\todo Consider how setting the analogue gain interacts with other AE\n+ features, such as aperture, aperture/shutter priority modes etc.\n+\n - Brightness:\n type: float\n description: |\n","prefixes":["libcamera-devel","v4","4/5"]}