{"id":10512,"url":"https://patchwork.libcamera.org/api/1.1/patches/10512/?format=json","web_url":"https://patchwork.libcamera.org/patch/10512/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201126145005.8838-2-david.plowman@raspberrypi.com>","date":"2020-11-26T14:50:04","name":"[libcamera-devel,v2,1/2] libcamera: controls: Add DigitalGain control","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a34631626761459e19eeac80a8c7588fef5643c7","submitter":{"id":42,"url":"https://patchwork.libcamera.org/api/1.1/people/42/?format=json","name":"David Plowman","email":"david.plowman@raspberrypi.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/1.1/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/10512/mbox/","series":[{"id":1485,"url":"https://patchwork.libcamera.org/api/1.1/series/1485/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1485","date":"2020-11-26T14:50:03","name":"Digital gain control","version":2,"mbox":"https://patchwork.libcamera.org/series/1485/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10512/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10512/checks/","tags":{},"headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EC284BE08A\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu, 26 Nov 2020 14:50:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 371E86346A;\n\tThu, 26 Nov 2020 15:50:11 +0100 (CET)","from mail-ej1-x644.google.com (mail-ej1-x644.google.com\n\t[IPv6:2a00:1450:4864:20::644])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1897B6346A\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Nov 2020 15:50:09 +0100 (CET)","by mail-ej1-x644.google.com with SMTP id f9so1103577ejw.4\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 26 Nov 2020 06:50:09 -0800 (PST)","from pi4-davidp.lan (plowpeople3.plus.com. [80.229.223.72])\n\tby smtp.gmail.com with ESMTPSA id\n\tcw26sm3249359ejb.47.2020.11.26.06.50.07\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 26 Nov 2020 06:50:07 -0800 (PST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Vx6SzyaR\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=3vIKDhkdBHpJGsSr1ppRdTN17fdllSE311fHIekkoBE=;\n\tb=Vx6SzyaRSLU+Zj9S5qkVkPku6Wu9PqPziXi52ZckY/mz9flxVzGI2Al2ENA6yBVDPp\n\tm/Fa+7O2gMLHYqV3BC6vigNO3R59nh1oapii3V1XjMfJVyGh5FjAUTSepXSfc9BXGJHX\n\tX71onq47BR4xrSSpXzDbx90ut824PvKGO7Dne5jt5ZoLaxsX1Vk3pvOXbodcU+XqE30z\n\tCpknEOJyDCFyGuAfyHvIwbMQTyFBflcaX4ep1X7U1XWzrNBlZdDRFBvPX3njMsXseA82\n\t5SuLNApz9t7O+iG7nf5Yj0pEYiYYS7b52/1+RJq+as8hggvNY25s+56m6sHW7cPeghwF\n\td7cg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=3vIKDhkdBHpJGsSr1ppRdTN17fdllSE311fHIekkoBE=;\n\tb=nCTsO1JZmaabdhYMbtjMLtbd5/3+GeEONQytfSxE843PBSf8MHwwLfqtVrtriUdJF7\n\tGg74WI39LUckBTdA4H3ZFk3NwsL+T8KCUNf51vySgDJmy9x5htVqAxx2XVfzt+Z3cUgB\n\t3pp3eTckclIyn3NG90M/IiG1vC03DoAtfyhyTOaGsqVrYaTpxR8U+z4Fb0dRxSrrHJli\n\tEMFG1ivzMIWp7fJJesyFjo8CX+RRZYlr9b2EqUdDH/45vfUUT1brR/2pmu1wuv30vnDa\n\tJGOSUZbB74e7RnidCoXynv9kdVY5+UsyE2Bd5st87pb9mRefsLEIZWyiNv2t8+/+N+Lo\n\tZnFg==","X-Gm-Message-State":"AOAM530Tjle2uICT/7fSrQyHPhE/DDcSQfrdzYYFKjpCC25y2He9zLWu\n\tmM+tf3JeLjZfq1m6Xj/FQ6dkap0CuomlQCBc","X-Google-Smtp-Source":"ABdhPJxGD7wqa2MQgmIqu3qQU/1a2M26v/8IQ4mbRmL0dbW9KX6jCXagGRk9/Muptsn+/M+ouktT2Q==","X-Received":"by 2002:a17:906:b53:: with SMTP id\n\tv19mr3059354ejg.250.1606402208421; \n\tThu, 26 Nov 2020 06:50:08 -0800 (PST)","From":"David Plowman <david.plowman@raspberrypi.com>","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 26 Nov 2020 14:50:04 +0000","Message-Id":"<20201126145005.8838-2-david.plowman@raspberrypi.com>","X-Mailer":"git-send-email 2.20.1","In-Reply-To":"<20201126145005.8838-1-david.plowman@raspberrypi.com>","References":"<20201126145005.8838-1-david.plowman@raspberrypi.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 1/2] libcamera: controls: Add\n\tDigitalGain control","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"},"content":"This control reports the global digital gain applied by the pipeline\nas a whole, after capturing a raw image from the sensor.\n\nSigned-off-by: David Plowman <david.plowman@raspberrypi.com>\n---\n src/libcamera/control_ids.yaml | 17 +++++++++++++++++\n 1 file changed, 17 insertions(+)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex c8874fa9..75a00f79 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -530,4 +530,21 @@ controls:\n         This control is only present when the pipeline supports scaling. Its\n         maximum valid value is given by the properties::ScalerCropMaximum\n         property, and the two can be used to implement digital zoom.\n+\n+  - DigitalGain:\n+      type: float\n+      description: |\n+        Digital gain value applied during the processing steps applied\n+        to the image as captured from the sensor.\n+\n+        The global digital gain factor is applied to all the colour channels\n+        of the RAW image. Different pipeline models are free to\n+        specify how the global gain factor applies to each separate\n+        channel.\n+\n+        If an imaging pipeline applies digital gain in distinct\n+        processing steps, this value indicates their total sum.\n+        Pipelines are free to decide how to adjust each processing\n+        step to respect the received gain factor and shall report\n+        their total value in the request metadata.\n ...\n","prefixes":["libcamera-devel","v2","1/2"]}