{"id":10472,"url":"https://patchwork.libcamera.org/api/1.1/patches/10472/?format=json","web_url":"https://patchwork.libcamera.org/patch/10472/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201123164319.152742-2-kieran.bingham@ideasonboard.com>","date":"2020-11-23T16:43:12","name":"[libcamera-devel,RFC,1/8] meson: Simplify pkg_mod.generate","commit_ref":null,"pull_url":null,"state":"changes-requested","archived":false,"hash":"7d41dc3fb06c0975d6f823a6013c5508499c0c42","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10472/mbox/","series":[{"id":1477,"url":"https://patchwork.libcamera.org/api/1.1/series/1477/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1477","date":"2020-11-23T16:43:11","name":"Configuration files and parsing","version":1,"mbox":"https://patchwork.libcamera.org/series/1477/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10472/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10472/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8D19CBE08A\n\tfor ;\n\tMon, 23 Nov 2020 16:45:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 37C9B633F1;\n\tMon, 23 Nov 2020 17:45:01 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 630D7633F0\n\tfor ;\n\tMon, 23 Nov 2020 17:44:58 +0100 (CET)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id E8F085A6;\n\tMon, 23 Nov 2020 17:44:57 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"rwdZZcdC\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1606149898;\n\tbh=eGOD0ERkSrh+rYDXGtunSC0Hk4IjYH8e1eCj+Keasd8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=rwdZZcdCSciVnptjnaLtqP1z2+PF5zW6K+PYdUDnVQ/w7sZ3DHcRNNcAR91d+tFHc\n\tLAqnsOGFfZI9qbBSnJ3eLO2L/V9U2IfpO6uRnSZs97Owf9qAGkvECTX4aHNg92LuHD\n\tAI4zUogeh1wUbQg88iAVArYZTDlZPHl6ucZwJVIM=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Mon, 23 Nov 2020 16:43:12 +0000","Message-Id":"<20201123164319.152742-2-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>","References":"<20201123164319.152742-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [RFC PATCH 1/8] meson: Simplify pkg_mod.generate","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Later versions of meson allow for the first positional argument to\nspecificy the defaults. Specify the libcamera library as the first\nargument, and remove the filebase.\n\nSigned-off-by: Kieran Bingham \n---\n meson.build | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/meson.build b/meson.build\nindex 55cf36e15f57..ced4afa7d726 100644\n--- a/meson.build\n+++ b/meson.build\n@@ -146,10 +146,9 @@ run_command('ln', '-fsT', meson.source_root(),\n configure_file(output : 'config.h', configuration : config_h)\n \n pkg_mod = import('pkgconfig')\n-pkg_mod.generate(libraries : libcamera,\n+pkg_mod.generate(libcamera,\n version : '1.0',\n name : 'libcamera',\n- filebase : 'camera',\n description : 'Complex Camera Support Library',\n subdirs : 'libcamera')\n \n","prefixes":["libcamera-devel","RFC","1/8"]}