{"id":1036,"url":"https://patchwork.libcamera.org/api/1.1/patches/1036/?format=json","web_url":"https://patchwork.libcamera.org/patch/1036/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20190418104715.22622-5-jacopo@jmondi.org>","date":"2019-04-18T10:47:05","name":"[libcamera-devel,v5,04/14] libcamera: v4l2_device: Propagate releaseBuffers() error","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"71ba44bf0a75b3be165e3241e789d718cd15f53b","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/1036/mbox/","series":[{"id":255,"url":"https://patchwork.libcamera.org/api/1.1/series/255/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=255","date":"2019-04-18T10:47:01","name":"libcamera: ipu3: Multiple streams support","version":5,"mbox":"https://patchwork.libcamera.org/series/255/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/1036/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/1036/checks/","tags":{},"headers":{"Return-Path":"","Received":["from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D2DB360DC0\n\tfor ;\n\tThu, 18 Apr 2019 12:46:32 +0200 (CEST)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 68EE01C0004;\n\tThu, 18 Apr 2019 10:46:32 +0000 (UTC)"],"X-Originating-IP":"2.224.242.101","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 18 Apr 2019 12:47:05 +0200","Message-Id":"<20190418104715.22622-5-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.21.0","In-Reply-To":"<20190418104715.22622-1-jacopo@jmondi.org>","References":"<20190418104715.22622-1-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","Subject":"[libcamera-devel] [PATCH v5 04/14] libcamera: v4l2_device:\n\tPropagate releaseBuffers() error","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 18 Apr 2019 10:46:34 -0000"},"content":"The error code returned by requestBuffers(0) was not propagated to the\ncaller. Fix it.\n\nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/v4l2_device.cpp | 3 +--\n 1 file changed, 1 insertion(+), 2 deletions(-)","diff":"diff --git a/src/libcamera/v4l2_device.cpp b/src/libcamera/v4l2_device.cpp\nindex 4cc4a6d656b1..d394632dad4c 100644\n--- a/src/libcamera/v4l2_device.cpp\n+++ b/src/libcamera/v4l2_device.cpp\n@@ -737,10 +737,9 @@ int V4L2Device::releaseBuffers()\n {\n \tLOG(V4L2, Debug) << \"Releasing bufferPool\";\n \n-\trequestBuffers(0);\n \tbufferPool_ = nullptr;\n \n-\treturn 0;\n+\treturn requestBuffers(0);\n }\n \n /**\n","prefixes":["libcamera-devel","v5","04/14"]}