{"id":10325,"url":"https://patchwork.libcamera.org/api/1.1/patches/10325/?format=json","web_url":"https://patchwork.libcamera.org/patch/10325/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201103155025.5948-5-laurent.pinchart@ideasonboard.com>","date":"2020-11-03T15:50:22","name":"[libcamera-devel,4/7] qcam: viewfinder_gl: Rename YUV.vert to identity.vert","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"7a54de78c369a0576fa06123c8fec2357197ae61","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10325/mbox/","series":[{"id":1441,"url":"https://patchwork.libcamera.org/api/1.1/series/1441/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1441","date":"2020-11-03T15:50:18","name":"qcam: Miscellaneous shaders cleanups and RGB support","version":1,"mbox":"https://patchwork.libcamera.org/series/1441/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10325/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10325/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C05B9BDB89\n\tfor ;\n\tTue, 3 Nov 2020 15:51:23 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 55CB162C3D;\n\tTue, 3 Nov 2020 16:51:23 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74F7362C42\n\tfor ;\n\tTue, 3 Nov 2020 16:51:20 +0100 (CET)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EB60AB9C;\n\tTue, 3 Nov 2020 16:51:19 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"KuZFXfJo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1604418680;\n\tbh=5Ykvp841gWtzzBknkCyMAXPW4JBMsUVhXuLOGpoSK6g=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=KuZFXfJobQyuQ2x1Fe8YcGG1c7IbafvzB/iyjgin6NXGSoaJ4ncqAazuKKPq0v60p\n\tZZF72kFUKYG28Nb1nnIS553mjgk5zn/yDih93lg9fa2z9JK+IX+BEACC25Aa8zXeio\n\t+Rwd1XII4FMcNu9TXZuc+VgsnLCcbr5YElwIBUCM=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 3 Nov 2020 17:50:22 +0200","Message-Id":"<20201103155025.5948-5-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>","References":"<20201103155025.5948-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 4/7] qcam: viewfinder_gl: Rename YUV.vert\n\tto identity.vert","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"In preparation for RGB formats support, rename the identity vertex\nshader from YUV.vert to identify.vert.\n\nSigned-off-by: Laurent Pinchart \n---\n src/qcam/assets/shader/{YUV.vert => identity.vert} | 2 +-\n src/qcam/assets/shader/shaders.qrc | 2 +-\n src/qcam/viewfinder_gl.cpp | 2 +-\n 3 files changed, 3 insertions(+), 3 deletions(-)\n rename src/qcam/assets/shader/{YUV.vert => identity.vert} (77%)","diff":"diff --git a/src/qcam/assets/shader/YUV.vert b/src/qcam/assets/shader/identity.vert\nsimilarity index 77%\nrename from src/qcam/assets/shader/YUV.vert\nrename to src/qcam/assets/shader/identity.vert\nindex f38e8045db89..6d6f7551017e 100644\n--- a/src/qcam/assets/shader/YUV.vert\n+++ b/src/qcam/assets/shader/identity.vert\n@@ -2,7 +2,7 @@\n /*\n * Copyright (C) 2020, Linaro\n *\n- * YUV.vert - Vertex shader for YUV to RGB conversion\n+ * identity.vert - Identity vertex shader for pixel format conversion\n */\n \n attribute vec4 vertexIn;\ndiff --git a/src/qcam/assets/shader/shaders.qrc b/src/qcam/assets/shader/shaders.qrc\nindex 857ed9fd5cde..863109146281 100644\n--- a/src/qcam/assets/shader/shaders.qrc\n+++ b/src/qcam/assets/shader/shaders.qrc\n@@ -1,9 +1,9 @@\n \n \n \n-\tYUV.vert\n \tYUV_2_planes.frag\n \tYUV_3_planes.frag\n \tYUV_packed.frag\n+\tidentity.vert\n \n \ndiff --git a/src/qcam/viewfinder_gl.cpp b/src/qcam/viewfinder_gl.cpp\nindex dc35d4fd8505..110f0fa673df 100644\n--- a/src/qcam/viewfinder_gl.cpp\n+++ b/src/qcam/viewfinder_gl.cpp\n@@ -191,7 +191,7 @@ bool ViewFinderGL::createVertexShader()\n \tvertexShader_ = std::make_unique(QOpenGLShader::Vertex, this);\n \n \t/* Compile the vertex shader */\n-\tif (!vertexShader_->compileSourceFile(\":YUV.vert\")) {\n+\tif (!vertexShader_->compileSourceFile(\":identity.vert\")) {\n \t\tqWarning() << \"[ViewFinderGL]:\" << vertexShader_->log();\n \t\treturn false;\n \t}\n","prefixes":["libcamera-devel","4/7"]}