{"id":10240,"url":"https://patchwork.libcamera.org/api/1.1/patches/10240/?format=json","web_url":"https://patchwork.libcamera.org/patch/10240/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201025160434.25664-6-jacopo@jmondi.org>","date":"2020-10-25T16:04:25","name":"[libcamera-devel,v5,05/14] libcamera: controls: Rename enumerate values","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"8c1dada5c1b4619b6c644acf2b8c6f7913963f91","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10240/mbox/","series":[{"id":1414,"url":"https://patchwork.libcamera.org/api/1.1/series/1414/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1414","date":"2020-10-25T16:04:20","name":"libcamera: Introduce draft controls","version":5,"mbox":"https://patchwork.libcamera.org/series/1414/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10240/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10240/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48B10BDB13\n\tfor ;\n\tSun, 25 Oct 2020 16:04:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0773561E5F;\n\tSun, 25 Oct 2020 17:04:49 +0100 (CET)","from relay10.mail.gandi.net (relay10.mail.gandi.net\n\t[217.70.178.230])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8E61561DA7\n\tfor ;\n\tSun, 25 Oct 2020 17:04:46 +0100 (CET)","from uno.lan (2-224-242-101.ip172.fastwebnet.it [2.224.242.101])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay10.mail.gandi.net (Postfix) with ESMTPSA id 97E3C240003;\n\tSun, 25 Oct 2020 16:04:45 +0000 (UTC)"],"From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Sun, 25 Oct 2020 17:04:25 +0100","Message-Id":"<20201025160434.25664-6-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20201025160434.25664-1-jacopo@jmondi.org>","References":"<20201025160434.25664-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v5 05/14] libcamera: controls: Rename\n\tenumerate values","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Rename the enumeration of supported values with the suffix \"Enum\"\nin place of \"Values\" to prepare to re-use the suffix \"Values\"\nfor the vector of Control's value introduced by the next patch.\n\nReviewed-by: Laurent Pinchart \nReviewed-by: Kieran Bingham \nSigned-off-by: Jacopo Mondi \n---\n utils/gen-controls.py | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/utils/gen-controls.py b/utils/gen-controls.py\nindex 93cb3885c3da..bf681503f86a 100755\n--- a/utils/gen-controls.py\n+++ b/utils/gen-controls.py\n@@ -24,9 +24,9 @@ def format_description(description):\n \n def generate_cpp(controls):\n enum_doc_start_template = string.Template('''/**\n- * \\\\enum ${name}Values\n+ * \\\\enum ${name}Enum\n * \\\\brief Supported ${name} values''')\n- enum_doc_value_template = string.Template(''' * \\\\var ${name}Values::${value}\n+ enum_doc_value_template = string.Template(''' * \\\\var ${name}Enum::${value}\n ${description}''')\n doc_template = string.Template('''/**\n * \\\\var ${name}\n@@ -98,7 +98,7 @@ ${description}\n \n \n def generate_h(controls):\n- enum_template_start = string.Template('''enum ${name}Values {''')\n+ enum_template_start = string.Template('''enum ${name}Enum {''')\n enum_value_template = string.Template('''\\t${name} = ${value},''')\n template = string.Template('''extern const Control<${type}> ${name};''')\n \n","prefixes":["libcamera-devel","v5","05/14"]}