{"id":10225,"url":"https://patchwork.libcamera.org/api/1.1/patches/10225/?format=json","web_url":"https://patchwork.libcamera.org/patch/10225/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201023171116.24899-7-jacopo@jmondi.org>","date":"2020-10-23T17:11:10","name":"[libcamera-devel,v4,06/12] ipa: raspberry: Initialize ControlInfo with values list","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ade6cf954aa4a7ee38bae15d3687d04196397b23","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10225/mbox/","series":[{"id":1410,"url":"https://patchwork.libcamera.org/api/1.1/series/1410/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1410","date":"2020-10-23T17:11:04","name":"libcamera: Introduce draft controls","version":4,"mbox":"https://patchwork.libcamera.org/series/1410/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10225/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10225/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 06C58BDB13\n\tfor ;\n\tFri, 23 Oct 2020 17:11:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BBA26619A3;\n\tFri, 23 Oct 2020 19:11:32 +0200 (CEST)","from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net\n\t[217.70.183.197])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3B57C615D4\n\tfor ;\n\tFri, 23 Oct 2020 19:11:28 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay5-d.mail.gandi.net (Postfix) with ESMTPSA id 55F721C0004;\n\tFri, 23 Oct 2020 17:11:27 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Fri, 23 Oct 2020 19:11:10 +0200","Message-Id":"<20201023171116.24899-7-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20201023171116.24899-1-jacopo@jmondi.org>","References":"<20201023171116.24899-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 06/12] ipa: raspberry: Initialize\n\tControlInfo with values list","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Initialize the ControlInfoMap of controls supported by the Raspberry\npipeline handler and IPA using the list of the enumerated values instead\nof specifying them manually.\n\nReviewed-by: Naushir Patuck \nReviewed-by: Kieran Bingham \nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/ipa/raspberrypi.h | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/ipa/raspberrypi.h b/include/libcamera/ipa/raspberrypi.h\nindex b23baf2f1330..1d3827404966 100644\n--- a/include/libcamera/ipa/raspberrypi.h\n+++ b/include/libcamera/ipa/raspberrypi.h\n@@ -50,13 +50,13 @@ static const ControlInfoMap Controls = {\n \t{ &controls::AeEnable, ControlInfo(false, true) },\n \t{ &controls::ExposureTime, ControlInfo(0, 999999) },\n \t{ &controls::AnalogueGain, ControlInfo(1.0f, 32.0f) },\n-\t{ &controls::AeMeteringMode, ControlInfo(0, static_cast(controls::MeteringModeMax)) },\n-\t{ &controls::AeConstraintMode, ControlInfo(0, static_cast(controls::ConstraintModeMax)) },\n-\t{ &controls::AeExposureMode, ControlInfo(0, static_cast(controls::ExposureModeMax)) },\n+\t{ &controls::AeMeteringMode, ControlInfo(controls::AeMeteringModeValues.data(), controls::AeMeteringModeValues.size()) },\n+\t{ &controls::AeConstraintMode, ControlInfo(controls::AeConstraintModeValues.data(), controls::AeConstraintModeValues.size()) },\n+\t{ &controls::AeExposureMode, ControlInfo(controls::AeExposureModeValues.data(), controls::AeExposureModeValues.size()) },\n \t{ &controls::ExposureValue, ControlInfo(0.0f, 16.0f) },\n \t{ &controls::AwbEnable, ControlInfo(false, true) },\n \t{ &controls::ColourGains, ControlInfo(0.0f, 32.0f) },\n-\t{ &controls::AwbMode, ControlInfo(0, static_cast(controls::AwbModeMax)) },\n+\t{ &controls::AwbMode, ControlInfo(controls::AwbModeValues.data(), controls::AwbModeValues.size()) },\n \t{ &controls::Brightness, ControlInfo(-1.0f, 1.0f) },\n \t{ &controls::Contrast, ControlInfo(0.0f, 32.0f) },\n \t{ &controls::Saturation, ControlInfo(0.0f, 32.0f) },\n","prefixes":["libcamera-devel","v4","06/12"]}