{"id":10203,"url":"https://patchwork.libcamera.org/api/1.1/patches/10203/?format=json","web_url":"https://patchwork.libcamera.org/patch/10203/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201022135605.614240-6-kieran.bingham@ideasonboard.com>","date":"2020-10-22T13:56:05","name":"[libcamera-devel,5/5] libcamera: MappedBuffer: Delete copy and assignment","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"fe76e87dc22a3c30f3e9ad213d785a8b936a86da","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":{"id":11,"url":"https://patchwork.libcamera.org/api/1.1/users/11/?format=json","username":"kbingham","first_name":"Kieran","last_name":"Bingham","email":"kieran.bingham@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/10203/mbox/","series":[{"id":1404,"url":"https://patchwork.libcamera.org/api/1.1/series/1404/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1404","date":"2020-10-22T13:56:00","name":"Delete Copy-Move-Assign","version":1,"mbox":"https://patchwork.libcamera.org/series/1404/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10203/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10203/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2833AC3D3C\n\tfor ;\n\tThu, 22 Oct 2020 13:56:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ED20B6145A;\n\tThu, 22 Oct 2020 15:56:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B809D61478\n\tfor ;\n\tThu, 22 Oct 2020 15:56:11 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5AEFA17C5;\n\tThu, 22 Oct 2020 15:56:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"L3e9e8xd\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603374971;\n\tbh=aqBQr4hkBETqFM9cnszpdq/GoQiskDhazGi/WzvNye8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=L3e9e8xdYWXtO460M2o3jBS9dr8+IqgtkC/6MhJUa1WR4hXv2VBN/4lv0iIwY6f2t\n\tQpwptO1/DF7c57Sli+0UWmqIqFF3P5NYgdDBh3/i15vbk9ZHewkB2V/26ws4SA1izi\n\tL8yWrANFmwpOheli4KeaxXw/tuzLN5ffnd2TT6iY=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Thu, 22 Oct 2020 14:56:05 +0100","Message-Id":"<20201022135605.614240-6-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201022135605.614240-1-kieran.bingham@ideasonboard.com>","References":"<20201022135605.614240-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 5/5] libcamera: MappedBuffer: Delete copy\n\tand assignment","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Prevent copying and assignment of MappedBuffer types, which could invoke unmapping\nor mapped memory.\n\nSigned-off-by: Kieran Bingham \n---\n include/libcamera/internal/buffer.h | 4 ++++\n 1 file changed, 4 insertions(+)","diff":"diff --git a/include/libcamera/internal/buffer.h b/include/libcamera/internal/buffer.h\nindex b7b0173f93f5..8c7126482b95 100644\n--- a/include/libcamera/internal/buffer.h\n+++ b/include/libcamera/internal/buffer.h\n@@ -10,6 +10,7 @@\n #include \n #include \n \n+#include \n #include \n #include \n \n@@ -34,6 +35,9 @@ protected:\n \n \tint error_;\n \tstd::vector maps_;\n+\n+private:\n+\tDELETE_COPY_AND_ASSIGN(MappedBuffer);\n };\n \n class MappedFrameBuffer : public MappedBuffer\n","prefixes":["libcamera-devel","5/5"]}