{"id":10195,"url":"https://patchwork.libcamera.org/api/1.1/patches/10195/?format=json","web_url":"https://patchwork.libcamera.org/patch/10195/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201022081731.36217-2-tomi.valkeinen@iki.fi>","date":"2020-10-22T08:17:29","name":"[libcamera-devel,2/4] pipeline: raspberrypi: return an error if setFormat() fails","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f3f4e223f8f46c4dad2aa32b235c9eaf2de59718","submitter":{"id":70,"url":"https://patchwork.libcamera.org/api/1.1/people/70/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@iki.fi"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10195/mbox/","series":[{"id":1403,"url":"https://patchwork.libcamera.org/api/1.1/series/1403/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1403","date":"2020-10-22T08:17:28","name":"[libcamera-devel,1/4] Add .clang-tidy","version":1,"mbox":"https://patchwork.libcamera.org/series/1403/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10195/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10195/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C9872C3D3C\n\tfor ;\n\tThu, 22 Oct 2020 08:17:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A2B4C613E6;\n\tThu, 22 Oct 2020 10:17:51 +0200 (CEST)","from mail-lj1-x244.google.com (mail-lj1-x244.google.com\n\t[IPv6:2a00:1450:4864:20::244])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7332160351\n\tfor ;\n\tThu, 22 Oct 2020 10:17:50 +0200 (CEST)","by mail-lj1-x244.google.com with SMTP id m20so981096ljj.5\n\tfor ;\n\tThu, 22 Oct 2020 01:17:50 -0700 (PDT)","from deskari.lan (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\tl3sm187007lji.36.2020.10.22.01.17.49\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 22 Oct 2020 01:17:49 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"VIoeAs/R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=Ur181zJY4BDVdAz0cbEk0Cx2tq726LoO8afr6LItANI=;\n\tb=VIoeAs/R2hVf7aG+5+HEK1RJUHZb8/Yi3P0hsQ7eJMlQLYS25rQzO0HwN6EwavP1iD\n\ty21/Cd4OQdiqhmkAkYJs8wtasJ3ME84UdenK/U21HQ9fYvDBYvgRISB1hFtDwjzc9biS\n\teHV4efrX4kC16us8l2fD77JQT72/n0xPfTPtM/NUFk8gHFdhTB7KfdznnL+WghDkMC/c\n\tqsFTkDYglc9vMUNVWiANABRiL/mGNjI86XqBc+rxmZTZuuNncN+wontzCYH3D/bxvCxx\n\ta7fKi+IvkJGyUZxriYPA9JVP1Q4KBrDq5rtW3EgXQaexSTELE+/9ymc55a13szV3H07m\n\tfVqQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=Ur181zJY4BDVdAz0cbEk0Cx2tq726LoO8afr6LItANI=;\n\tb=jiRr9KArHNUaKoqXHS+dQfGvbXwWHaScENyW0CC9wyLv1Dhenmt3KzDvyXHJVTJRyq\n\ttKQVfjlGKqed3wmaFU88pgO4Nol0IwO8E1cLjpGKRWioO3yIGBLTTRYC+6XX9eCl9qI2\n\ti3rCess7TPOi3HS3u/4+04eqIu8j6V7b3u7JsOTpVmsSmpqVSRGvcPyzd4d0Dt12tUh0\n\tgCOOSAOZWPyoD53lBY7xu/9EUEG9KZAnnktdPUjB0AWvhezb3vfc0Z8bJ2kmdjtXK7b4\n\tr6TjowTlP89vzwetXVxKn78edUE+Oo2nC5KpYeP7WuLLEeDgz1aIMu8V+yHw4UvqddvI\n\tCWww==","X-Gm-Message-State":"AOAM532GwntnHfNTDVI21jotNuYRFxsO65CX/4q9f9TWPapy4ja4HWte\n\t5h04lpM9eUf3Sh/EoBSwUp9Jdyw0fXKF8Q==","X-Google-Smtp-Source":"ABdhPJy9hUTNIf4xIeUHhig9cDP9BrYGbQEJ71iyV4vOfeE3m4OykuYKizSG4errTR+eX1Tk/fZ6Cg==","X-Received":"by 2002:a2e:3915:: with SMTP id g21mr520049lja.18.1603354669786; \n\tThu, 22 Oct 2020 01:17:49 -0700 (PDT)","From":"Tomi Valkeinen ","To":"libcamera-devel@lists.libcamera.org","Date":"Thu, 22 Oct 2020 11:17:29 +0300","Message-Id":"<20201022081731.36217-2-tomi.valkeinen@iki.fi>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201022081731.36217-1-tomi.valkeinen@iki.fi>","References":"<20201022081731.36217-1-tomi.valkeinen@iki.fi>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 2/4] pipeline: raspberrypi: return an\n\terror if setFormat() fails","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Tomi Valkeinen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The method calls setFormat(), stores the return value, but then does not\ndo anything with the return value. I presume it is meant to fail and\nreturn the error.\n\nSigned-off-by: Tomi Valkeinen \n---\n src/libcamera/pipeline/raspberrypi/raspberrypi.cpp | 2 ++\n 1 file changed, 2 insertions(+)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\nindex dd62dfc7..aa8d9340 100644\n--- a/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/raspberrypi.cpp\n@@ -586,6 +586,8 @@ int PipelineHandlerRPi::configure(Camera *camera, CameraConfiguration *config)\n \t * because of flips in the sensor.\n \t */\n \tret = data->isp_[Isp::Input].dev()->setFormat(&sensorFormat);\n+\tif (ret)\n+\t\treturn ret;\n \n \t/*\n \t * See which streams are requested, and route the user\n","prefixes":["libcamera-devel","2/4"]}