{"id":10191,"url":"https://patchwork.libcamera.org/api/1.1/patches/10191/?format=json","web_url":"https://patchwork.libcamera.org/patch/10191/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201021154148.511505-15-kieran.bingham@ideasonboard.com>","date":"2020-10-21T15:41:47","name":"[libcamera-devel,v4,14/15] test: v4l2_videodevice: Prevent variable shadowing of format","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"2c7de0271f48396814dfb69455c3330d2894d614","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10191/mbox/","series":[{"id":1401,"url":"https://patchwork.libcamera.org/api/1.1/series/1401/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1401","date":"2020-10-21T15:41:33","name":"Shadowed Variables","version":4,"mbox":"https://patchwork.libcamera.org/series/1401/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10191/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10191/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2E35DBDB13\n\tfor ;\n\tWed, 21 Oct 2020 15:42:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EC7CE60F6F;\n\tWed, 21 Oct 2020 17:42:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2AAAD603F9\n\tfor ;\n\tWed, 21 Oct 2020 17:41:58 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AED21116B;\n\tWed, 21 Oct 2020 17:41:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HJUjtgnQ\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603294917;\n\tbh=FWbcbdxbuYlrWMximjA4KHJiaXV2z5DdBW+e6Zf/PHo=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=HJUjtgnQhqhSZxfWAOqA3CXGO+bDtt9gQIed9YrMuPGH4HxqR33dTC87+SW+FcMdB\n\tK8EH+XXzlwj7Hefc4Zi+FwAiQ01o18ZYUj+3iCaArWINzrWNmj5fflmfxDHOamihjo\n\tkTmhmyLVfKrqBJguonI7aIdnz7nx1vqNiHIZnTzo=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 21 Oct 2020 16:41:47 +0100","Message-Id":"<20201021154148.511505-15-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201021154148.511505-1-kieran.bingham@ideasonboard.com>","References":"<20201021154148.511505-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 14/15] test: v4l2_videodevice: Prevent\n\tvariable shadowing of format","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Rename the scoped usage of the variable format while iterating the formats\nas it shadows the outer scoped format which is used for specific testing.\n\nSigned-off-by: Kieran Bingham \nReviewed-by: Niklas Söderlund \nReviewed-by: Laurent Pinchart \n---\n test/v4l2_videodevice/formats.cpp | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/test/v4l2_videodevice/formats.cpp b/test/v4l2_videodevice/formats.cpp\nindex b5020d2bedd2..255446fe758a 100644\n--- a/test/v4l2_videodevice/formats.cpp\n+++ b/test/v4l2_videodevice/formats.cpp\n@@ -55,10 +55,10 @@ protected:\n \t\t\t{ V4L2_PIX_FMT_Y16_BE, \"Y16 -BE\" }\n \t\t};\n \n-\t\tfor (const auto &format : formats) {\n-\t\t\tif (V4L2PixelFormat(format.first).toString() != format.second) {\n+\t\tfor (const auto &fmt : formats) {\n+\t\t\tif (V4L2PixelFormat(fmt.first).toString() != fmt.second) {\n \t\t\t\tcerr << \"Failed to convert V4L2PixelFormat\"\n-\t\t\t\t << utils::hex(format.first) << \"to string\"\n+\t\t\t\t << utils::hex(fmt.first) << \"to string\"\n \t\t\t\t << endl;\n \t\t\t\treturn TestFail;\n \t\t\t}\n","prefixes":["libcamera-devel","v4","14/15"]}