{"id":10181,"url":"https://patchwork.libcamera.org/api/1.1/patches/10181/?format=json","web_url":"https://patchwork.libcamera.org/patch/10181/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201021154148.511505-5-kieran.bingham@ideasonboard.com>","date":"2020-10-21T15:41:37","name":"[libcamera-devel,v4,04/15] libcamera: pipeline: rpi_stream: Explicitly name requestBuffer","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"af660763c3e85194bff081e418edce0a5cd10bf9","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/1.1/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10181/mbox/","series":[{"id":1401,"url":"https://patchwork.libcamera.org/api/1.1/series/1401/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1401","date":"2020-10-21T15:41:33","name":"Shadowed Variables","version":4,"mbox":"https://patchwork.libcamera.org/series/1401/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10181/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10181/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1E8AEBDB13\n\tfor ;\n\tWed, 21 Oct 2020 15:41:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B411960995;\n\tWed, 21 Oct 2020 17:41:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A796060BE5\n\tfor ;\n\tWed, 21 Oct 2020 17:41:54 +0200 (CEST)","from Q.local (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net\n\t[86.31.172.11])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 414EEAEE;\n\tWed, 21 Oct 2020 17:41:54 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"m0Tc978Q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603294914;\n\tbh=p8OVJy2+spdtsu3tlRc3jASGz2jYQOq37XEfR3jGRg4=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=m0Tc978QHGWQCZjGRT4on4J4TT9OkvMNL6MnWA0yt5oMbuHEpTiCv0NjqssRzP2lA\n\tenhvo2ktK4NG0PFsdsYk9Q/ohHmqkz+4OLxPbH4VNUXlCw0h67YvdfhRj6ASf9LnAk\n\tVfsi7W+oI92w2KWiGGcQa98uVlTIvn7feruOZ680=","From":"Kieran Bingham ","To":"libcamera devel ","Date":"Wed, 21 Oct 2020 16:41:37 +0100","Message-Id":"<20201021154148.511505-5-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201021154148.511505-1-kieran.bingham@ideasonboard.com>","References":"<20201021154148.511505-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v4 04/15] libcamera: pipeline: rpi_stream:\n\tExplicitly name requestBuffer","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The FrameBuffer used to track any addition to the request in an\nunder-run event was shadowed against the returned buffer, being placed\nback on the availableBuffers_ queue.\n\nRename the shadowed variable to be more explicit that it is a separate\nBuffer.\n\nSigned-off-by: Kieran Bingham \nReviewed-by: Niklas Söderlund \n---\n src/libcamera/pipeline/raspberrypi/rpi_stream.cpp | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\nindex 1a42cc17bcba..3a5dadab81e0 100644\n--- a/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/rpi_stream.cpp\n@@ -163,9 +163,9 @@ void Stream::returnBuffer(FrameBuffer *buffer)\n \t * If so, do it now as availableBuffers_ will not be empty.\n \t */\n \twhile (!requestBuffers_.empty()) {\n-\t\tFrameBuffer *buffer = requestBuffers_.front();\n+\t\tFrameBuffer *requestBuffer = requestBuffers_.front();\n \n-\t\tif (!buffer) {\n+\t\tif (!requestBuffer) {\n \t\t\t/*\n \t\t\t * We want to queue an internal buffer, but none\n \t\t\t * are available. Can't do anything, quit the loop.\n@@ -177,12 +177,12 @@ void Stream::returnBuffer(FrameBuffer *buffer)\n \t\t\t * We want to queue an internal buffer, and at least one\n \t\t\t * is available.\n \t\t\t */\n-\t\t\tbuffer = availableBuffers_.front();\n+\t\t\trequestBuffer = availableBuffers_.front();\n \t\t\tavailableBuffers_.pop();\n \t\t}\n \n \t\trequestBuffers_.pop();\n-\t\tqueueToDevice(buffer);\n+\t\tqueueToDevice(requestBuffer);\n \t}\n }\n \n","prefixes":["libcamera-devel","v4","04/15"]}