{"id":10169,"url":"https://patchwork.libcamera.org/api/1.1/patches/10169/?format=json","web_url":"https://patchwork.libcamera.org/patch/10169/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201021143635.22846-9-jacopo@jmondi.org>","date":"2020-10-21T14:36:29","name":"[libcamera-devel,v3,08/14] libcamera: control_ids: Remove max values in enumerations","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"5f3f6d6949762cf7ebcb216e18c5dd75107404d0","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10169/mbox/","series":[{"id":1399,"url":"https://patchwork.libcamera.org/api/1.1/series/1399/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1399","date":"2020-10-21T14:36:21","name":"libcamera: Introduce draft controls","version":3,"mbox":"https://patchwork.libcamera.org/series/1399/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10169/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10169/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1A51CBDB13\n\tfor ;\n\tWed, 21 Oct 2020 14:36:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5FD161E0D;\n\tWed, 21 Oct 2020 16:36:52 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2887361E57\n\tfor ;\n\tWed, 21 Oct 2020 16:36:49 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 926D2C0015;\n\tWed, 21 Oct 2020 14:36:48 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 21 Oct 2020 16:36:29 +0200","Message-Id":"<20201021143635.22846-9-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20201021143635.22846-1-jacopo@jmondi.org>","References":"<20201021143635.22846-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 08/14] libcamera: control_ids: Remove\n\tmax values in enumerations","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The libcamera control definition schema includes a placeholder\nmaximum value for each enumeration of supported values.\n\nAs it is now possible to create ControlInfo from the list of enumerated\nvalues, it is not necessary to generate the placeholder value anymore.\n\nReviewed-by: Kieran Bingham \nSigned-off-by: Jacopo Mondi \n---\n src/libcamera/control_ids.yaml | 12 ------------\n 1 file changed, 12 deletions(-)","diff":"diff --git a/src/libcamera/control_ids.yaml b/src/libcamera/control_ids.yaml\nindex 2fca88e36635..637fbace152e 100644\n--- a/src/libcamera/control_ids.yaml\n+++ b/src/libcamera/control_ids.yaml\n@@ -48,9 +48,6 @@ controls:\n - name: MeteringCustom\n value: 3\n description: Custom metering mode.\n- - name: MeteringModeMax\n- value: 3\n- description: Maximum allowed value (place any new values above here).\n \n # AeConstraintMode needs further attention:\n # - Auto-generate max enum value.\n@@ -85,9 +82,6 @@ controls:\n - name: ConstraintCustom\n value: 3\n description: Custom constraint mode.\n- - name: ConstraintModeMax\n- value: 3\n- description: Maximum allowed value (place any new values above here).\n \n # AeExposureMode needs further attention:\n # - Auto-generate max enum value.\n@@ -112,9 +106,6 @@ controls:\n - name: ExposureCustom\n value: 3\n description: Custom exposure mode.\n- - name: ExposureModeMax\n- value: 3\n- description: Maximum allowed value (place any new values above here).\n \n - ExposureValue:\n type: float\n@@ -204,9 +195,6 @@ controls:\n - name: AwbCustom\n value: 7\n description: Custom AWB mode.\n- - name: AwbModeMax\n- value: 7\n- description: Maximum allowed value (place any new values above here).\n \n - AwbLocked:\n type: bool\n","prefixes":["libcamera-devel","v3","08/14"]}