{"id":10165,"url":"https://patchwork.libcamera.org/api/1.1/patches/10165/?format=json","web_url":"https://patchwork.libcamera.org/patch/10165/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201021143635.22846-5-jacopo@jmondi.org>","date":"2020-10-21T14:36:25","name":"[libcamera-devel,v3,04/14] libcamera: controls: Construct from values list","commit_ref":null,"pull_url":null,"state":"superseded","archived":true,"hash":"fb3d542f5f88990c9aedbb8e333089c4ae8934e5","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/1.1/people/3/?format=json","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"delegate":{"id":15,"url":"https://patchwork.libcamera.org/api/1.1/users/15/?format=json","username":"jmondi","first_name":"Jacopo","last_name":"Mondi","email":"jacopo@jmondi.org"},"mbox":"https://patchwork.libcamera.org/patch/10165/mbox/","series":[{"id":1399,"url":"https://patchwork.libcamera.org/api/1.1/series/1399/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1399","date":"2020-10-21T14:36:21","name":"libcamera: Introduce draft controls","version":3,"mbox":"https://patchwork.libcamera.org/series/1399/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10165/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10165/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EB777BDB13\n\tfor ;\n\tWed, 21 Oct 2020 14:36:48 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 886B261E26;\n\tWed, 21 Oct 2020 16:36:48 +0200 (CEST)","from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A665361DFC\n\tfor ;\n\tWed, 21 Oct 2020 16:36:46 +0200 (CEST)","from uno.lan (93-34-118-233.ip49.fastwebnet.it [93.34.118.233])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 1C00EC0015;\n\tWed, 21 Oct 2020 14:36:45 +0000 (UTC)"],"X-Originating-IP":"93.34.118.233","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Date":"Wed, 21 Oct 2020 16:36:25 +0200","Message-Id":"<20201021143635.22846-5-jacopo@jmondi.org>","X-Mailer":"git-send-email 2.28.0","In-Reply-To":"<20201021143635.22846-1-jacopo@jmondi.org>","References":"<20201021143635.22846-1-jacopo@jmondi.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v3 04/14] libcamera: controls: Construct\n\tfrom values list","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Add two constructors to the ControlInfo class that allows creating\na class instance from the list of the control supported values with\nan optional default value.\n\nSigned-off-by: Jacopo Mondi \n---\n include/libcamera/controls.h | 3 +++\n src/libcamera/controls.cpp | 31 +++++++++++++++++++++++++++++++\n 2 files changed, 34 insertions(+)","diff":"diff --git a/include/libcamera/controls.h b/include/libcamera/controls.h\nindex d1f6d4490c35..0099b6329026 100644\n--- a/include/libcamera/controls.h\n+++ b/include/libcamera/controls.h\n@@ -269,6 +269,9 @@ public:\n \t\t\t const ControlValue &max = 0,\n \t\t\t const ControlValue &def = 0,\n \t\t\t const std::vector &values = {});\n+\texplicit ControlInfo(const std::vector &values,\n+\t\t\t const ControlValue &def);\n+\texplicit ControlInfo(const std::vector &values);\n \n \tconst ControlValue &min() const { return min_; }\n \tconst ControlValue &max() const { return max_; }\ndiff --git a/src/libcamera/controls.cpp b/src/libcamera/controls.cpp\nindex 61feee37a1b8..389ecd5c519c 100644\n--- a/src/libcamera/controls.cpp\n+++ b/src/libcamera/controls.cpp\n@@ -493,6 +493,37 @@ ControlInfo::ControlInfo(const ControlValue &min,\n {\n }\n \n+/**\n+ * \\brief Construct a ControlInfo from the list of supported values and a default\n+ * \\param[in] values The control supported values\n+ * \\param[in] def The control default value\n+ *\n+ * Construct a ControlInfo from a list of supported values. The ControlInfo\n+ * minimum and maximum values are assigned to the first and last members of\n+ * the values list respectively.\n+ */\n+ControlInfo::ControlInfo(const std::vector &values,\n+\t\t\t const ControlValue &def)\n+\t: def_(def), values_(values)\n+{\n+\tmin_ = values_.front();\n+\tmax_ = values_.back();\n+}\n+\n+/**\n+ * \\brief Construct a ControlInfo from the list of supported values\n+ * \\param[in] values The control supported values\n+ *\n+ * Construct a ControlInfo from a list of supported values. The ControlInfo\n+ * minimum and maximum values are assigned to the first and last members of\n+ * the values list respectively. The ControlInfo default value is set to be\n+ * equal to the minimum one.\n+ */\n+ControlInfo::ControlInfo(const std::vector &values)\n+\t: ControlInfo(values, values.front())\n+{\n+}\n+\n /**\n * \\fn ControlInfo::min()\n * \\brief Retrieve the minimum value of the control\n","prefixes":["libcamera-devel","v3","04/14"]}