{"id":10128,"url":"https://patchwork.libcamera.org/api/1.1/patches/10128/?format=json","web_url":"https://patchwork.libcamera.org/patch/10128/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201020091505.138898-4-hiroh@chromium.org>","date":"2020-10-20T09:15:01","name":"[libcamera-devel,v2,4/8] android: Omit extra semicolons","commit_ref":"6c5792f7a8b29143fb55cea2ecfcd8598ce56cd9","pull_url":null,"state":"accepted","archived":false,"hash":"54fec2431bd72acc59e165eafa8a8f00d27108c6","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10128/mbox/","series":[{"id":1390,"url":"https://patchwork.libcamera.org/api/1.1/series/1390/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1390","date":"2020-10-20T09:14:58","name":"[libcamera-devel,v2,1/8] test: Omit extra semicolons","version":2,"mbox":"https://patchwork.libcamera.org/series/1390/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10128/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10128/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 21206BDB1F\n\tfor ;\n\tTue, 20 Oct 2020 09:15:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE782613CC;\n\tTue, 20 Oct 2020 11:15:20 +0200 (CEST)","from mail-pf1-x42e.google.com (mail-pf1-x42e.google.com\n\t[IPv6:2607:f8b0:4864:20::42e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3FD8C61394\n\tfor ;\n\tTue, 20 Oct 2020 11:15:19 +0200 (CEST)","by mail-pf1-x42e.google.com with SMTP id y14so812417pfp.13\n\tfor ;\n\tTue, 20 Oct 2020 02:15:19 -0700 (PDT)","from hiroh.tok.corp.google.com\n\t([2401:fa00:8f:2:de4a:3eff:fe7d:f78f])\n\tby smtp.gmail.com with ESMTPSA id\n\tp8sm1482014pgs.34.2020.10.20.02.15.16\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 20 Oct 2020 02:15:17 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"bmd8hI/6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=8pxfREl9eDmi/cM3ydqF58dxOJd5JJAZPW5HsxmdJ2o=;\n\tb=bmd8hI/63cq4uqEAdN8fFA15reCtXnvBzRUMZlCBZ6I6m6Yt8XYjbv+r9m0qV8TlhU\n\t6g4+3BL2e822jLY5pg7hSKvmSzF+rq7vp6LAJ+vrv4uhKp25vg0wiUG61qilMlBUeBJ7\n\t0ChU4672L+IeKlQzhbx/UoqIv1O+XlCkIhMqk=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=8pxfREl9eDmi/cM3ydqF58dxOJd5JJAZPW5HsxmdJ2o=;\n\tb=hpuh9MKZ6zAc6gM8oyZJJHWvlUK9m47rL/p3cRNH2EjGQIWqNrsqn7bD9jRadXj/Oe\n\t96QRNCqMG+9o9qvLZ3OV/9JlULBJ6dG96kBN7pFmtUtXjXBCy8J6fhzaOaimJKlDxuP8\n\t3LRNbQmtcRvsq3viTnSryUP4RkgYQD/nYCIWD1V2hQb2/TDNNipFVk5LXHnpHbAyUySZ\n\tyPlkE8CDHMKK2x3y9PnsW/tQaWPXGhUa8OvQokAx2trxK/eLq0SZUjyEb1RDLqEg0COM\n\tn1msA5i+wqlg79+aebi10SXgglU3PZzsFJkW7ZS7d7nyo2YXpSRWF+VKa6+wamOtpsDE\n\t8yeQ==","X-Gm-Message-State":"AOAM5330ylAHLZd/zguluL0ntjdLq8mScaPe8nTRXi+h5TSfHk4oCZ1M\n\tuVAtt0AU+pryMDKmpmEXu1EWsiXP9xdGHw==","X-Google-Smtp-Source":"ABdhPJzjx11h+Comoisu/WzYt5RtH0gYrWs3Hf+vpIxBIr1TjyshEnZkJJ/IMDOGVXx7Ns/c4vE4ww==","X-Received":"by 2002:aa7:91c8:0:b029:155:c7c1:3fae with SMTP id\n\tz8-20020aa791c80000b0290155c7c13faemr1873107pfa.74.1603185317691; \n\tTue, 20 Oct 2020 02:15:17 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 20 Oct 2020 18:15:01 +0900","Message-Id":"<20201020091505.138898-4-hiroh@chromium.org>","X-Mailer":"git-send-email 2.29.0.rc1.297.gfa9743e501-goog","In-Reply-To":"<20201020091505.138898-1-hiroh@chromium.org>","References":"<20201020091505.138898-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 4/8] android: Omit extra semicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The end semicolons with LOG_DECLARE_CATEGORY and\nLOG_DEFINE_CATEGORY are unnecessary.\n\nSigned-off-by: Hirokazu Honda \nReviewed-by: Laurent Pinchart \n---\n src/android/camera_device.cpp | 2 +-\n src/android/camera_hal_manager.cpp | 2 +-\n src/android/camera_metadata.cpp | 2 +-\n src/android/camera_stream.cpp | 2 +-\n src/android/camera_worker.cpp | 2 +-\n src/android/jpeg/encoder.h | 2 +-\n src/android/jpeg/encoder_libjpeg.cpp | 2 +-\n src/android/jpeg/post_processor_jpeg.cpp | 2 +-\n 8 files changed, 8 insertions(+), 8 deletions(-)","diff":"diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\nindex d706cf4..e9404c2 100644\n--- a/src/android/camera_device.cpp\n+++ b/src/android/camera_device.cpp\n@@ -129,7 +129,7 @@ const std::map camera3FormatsMap = {\n \n } /* namespace */\n \n-LOG_DECLARE_CATEGORY(HAL);\n+LOG_DECLARE_CATEGORY(HAL)\n \n MappedCamera3Buffer::MappedCamera3Buffer(const buffer_handle_t camera3buffer,\n \t\t\t\t\t int flags)\ndiff --git a/src/android/camera_hal_manager.cpp b/src/android/camera_hal_manager.cpp\nindex 2a33f9b..189eda2 100644\n--- a/src/android/camera_hal_manager.cpp\n+++ b/src/android/camera_hal_manager.cpp\n@@ -16,7 +16,7 @@\n \n using namespace libcamera;\n \n-LOG_DECLARE_CATEGORY(HAL);\n+LOG_DECLARE_CATEGORY(HAL)\n \n /*\n * \\class CameraHalManager\ndiff --git a/src/android/camera_metadata.cpp b/src/android/camera_metadata.cpp\nindex f0da9ea..edea48f 100644\n--- a/src/android/camera_metadata.cpp\n+++ b/src/android/camera_metadata.cpp\n@@ -11,7 +11,7 @@\n \n using namespace libcamera;\n \n-LOG_DEFINE_CATEGORY(CameraMetadata);\n+LOG_DEFINE_CATEGORY(CameraMetadata)\n \n CameraMetadata::CameraMetadata(size_t entryCapacity, size_t dataCapacity)\n {\ndiff --git a/src/android/camera_stream.cpp b/src/android/camera_stream.cpp\nindex 1b8afa8..eae451e 100644\n--- a/src/android/camera_stream.cpp\n+++ b/src/android/camera_stream.cpp\n@@ -15,7 +15,7 @@\n \n using namespace libcamera;\n \n-LOG_DECLARE_CATEGORY(HAL);\n+LOG_DECLARE_CATEGORY(HAL)\n \n /*\n * \\class CameraStream\ndiff --git a/src/android/camera_worker.cpp b/src/android/camera_worker.cpp\nindex ff09b75..df43646 100644\n--- a/src/android/camera_worker.cpp\n+++ b/src/android/camera_worker.cpp\n@@ -15,7 +15,7 @@\n \n using namespace libcamera;\n \n-LOG_DECLARE_CATEGORY(HAL);\n+LOG_DECLARE_CATEGORY(HAL)\n \n /*\n * \\class CaptureRequest\ndiff --git a/src/android/jpeg/encoder.h b/src/android/jpeg/encoder.h\nindex 4483153..4e85996 100644\n--- a/src/android/jpeg/encoder.h\n+++ b/src/android/jpeg/encoder.h\n@@ -14,7 +14,7 @@\n class Encoder\n {\n public:\n-\tvirtual ~Encoder() {};\n+\tvirtual ~Encoder() {}\n \n \tvirtual int configure(const libcamera::StreamConfiguration &cfg) = 0;\n \tvirtual int encode(const libcamera::FrameBuffer *source,\ndiff --git a/src/android/jpeg/encoder_libjpeg.cpp b/src/android/jpeg/encoder_libjpeg.cpp\nindex 8995ba5..f11e004 100644\n--- a/src/android/jpeg/encoder_libjpeg.cpp\n+++ b/src/android/jpeg/encoder_libjpeg.cpp\n@@ -25,7 +25,7 @@\n \n using namespace libcamera;\n \n-LOG_DECLARE_CATEGORY(JPEG);\n+LOG_DECLARE_CATEGORY(JPEG)\n \n namespace {\n \ndiff --git a/src/android/jpeg/post_processor_jpeg.cpp b/src/android/jpeg/post_processor_jpeg.cpp\nindex 753c28e..9d452b7 100644\n--- a/src/android/jpeg/post_processor_jpeg.cpp\n+++ b/src/android/jpeg/post_processor_jpeg.cpp\n@@ -18,7 +18,7 @@\n \n using namespace libcamera;\n \n-LOG_DEFINE_CATEGORY(JPEG);\n+LOG_DEFINE_CATEGORY(JPEG)\n \n PostProcessorJpeg::PostProcessorJpeg(CameraDevice *device)\n \t: cameraDevice_(device)\n","prefixes":["libcamera-devel","v2","4/8"]}