{"id":10118,"url":"https://patchwork.libcamera.org/api/1.1/patches/10118/?format=json","web_url":"https://patchwork.libcamera.org/patch/10118/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201020052905.89267-7-hiroh@chromium.org>","date":"2020-10-20T05:29:03","name":"[libcamera-devel,6/8] libcamera: Omit extra semicolons","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"ae6932251893dc523a27eb1c48e0944d36fe98c4","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10118/mbox/","series":[{"id":1388,"url":"https://patchwork.libcamera.org/api/1.1/series/1388/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1388","date":"2020-10-20T05:28:58","name":"[libcamera-devel,1/8] test: Omit extra semicolons","version":1,"mbox":"https://patchwork.libcamera.org/series/1388/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10118/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10118/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A2CCABDB13\n\tfor ;\n\tTue, 20 Oct 2020 05:29:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70269613B9;\n\tTue, 20 Oct 2020 07:29:28 +0200 (CEST)","from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com\n\t[IPv6:2607:f8b0:4864:20::1043])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 46BB461394\n\tfor ;\n\tTue, 20 Oct 2020 07:29:27 +0200 (CEST)","by mail-pj1-x1043.google.com with SMTP id p3so394022pjd.0\n\tfor ;\n\tMon, 19 Oct 2020 22:29:27 -0700 (PDT)","from hiroh.tok.corp.google.com\n\t([2401:fa00:8f:2:de4a:3eff:fe7d:f78f])\n\tby smtp.gmail.com with ESMTPSA id\n\tj4sm779043pfd.101.2020.10.19.22.29.24\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 19 Oct 2020 22:29:25 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"i1lC52PO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=yeDIIGEs4PSIIpwJxOaDX3oTcvE0+8ygpI8DM2IZWLY=;\n\tb=i1lC52PO27RNp+GEDQP/f7wsBIXw+FU1IKmyfy4yIIvc1ZLzHZbOkVuKpcUeiQXe2C\n\tNU/8xSKl2r6UikbTq7o24v9YyrLOtOsFWoTn+D4ik8YsjflzDaB/IZy62Cf1V8KZcTOj\n\t3jf0u8JH9cjByc2BTX4mzC/wKA5WM9qYxwO3U=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=yeDIIGEs4PSIIpwJxOaDX3oTcvE0+8ygpI8DM2IZWLY=;\n\tb=Cx6uiQiMKPrNKZLco0ecOtBFUQ58oD4MyfhvvVZSYJOBxZwLXaxrl3ew/NYpsvj178\n\tZ1xtqjQQkddrV8omV9j61jYCVIUVfxt0M9K6L580764zJMuCxkYbxLRO+e/+9AVLQ8wP\n\t6gpJQozGk4LiEFcSORHJiuEzstIMC60FJzzjqjjcH5rgjn1XRkjW7fF16sx06jAl6OWc\n\tIqITbV3Zd1n1KWms07QZtey0/NrPZnOtC+vPVALCnuq2kibv81vtc4ax+57B+codPwHr\n\tObDfUDD8XkbAIyqp972Zklm71rixvc37bQVjlarWOifmxEyZHIcnQPP1eUkZKDbeemwW\n\tiuSQ==","X-Gm-Message-State":"AOAM532XqQpjOvQ7s+dcGKXsVaNt1GyXC2Sciq5C/Icr/cKQfuJTiQ04\n\tjus2m8WOvexXq/OykdJJJQnTuPo5Xhy+kw==","X-Google-Smtp-Source":"ABdhPJx4ksBoG2tVzyzh6eJuhmzz1vxwn/Ko7LJNoGKoq1YKimvuY0lxKxeIMJEN1xk/kPFKOr4gQA==","X-Received":"by 2002:a17:90a:db43:: with SMTP id\n\tu3mr1321732pjx.225.1603171765747; \n\tMon, 19 Oct 2020 22:29:25 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 20 Oct 2020 14:29:03 +0900","Message-Id":"<20201020052905.89267-7-hiroh@chromium.org>","X-Mailer":"git-send-email 2.29.0.rc1.297.gfa9743e501-goog","In-Reply-To":"<20201020052905.89267-1-hiroh@chromium.org>","References":"<20201020052905.89267-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 6/8] libcamera: Omit extra semicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The end semicolons with LOG_DEFINE_CATEGORY and\nLOG_DECLARE_CATEGORY are unnecessary.\n\nSigned-off-by: Hirokazu Honda \n---\n src/libcamera/byte_stream_buffer.cpp | 2 +-\n src/libcamera/camera_sensor.cpp | 2 +-\n src/libcamera/file.cpp | 2 +-\n src/libcamera/pipeline/ipu3/ipu3.cpp | 2 +-\n src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp | 2 +-\n src/libcamera/pipeline/simple/converter.cpp | 2 +-\n src/libcamera/sysfs.cpp | 2 +-\n 7 files changed, 7 insertions(+), 7 deletions(-)","diff":"diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\nindex df7029b..7db5501 100644\n--- a/src/libcamera/byte_stream_buffer.cpp\n+++ b/src/libcamera/byte_stream_buffer.cpp\n@@ -14,7 +14,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(Serialization);\n+LOG_DEFINE_CATEGORY(Serialization)\n \n /**\n * \\file byte_stream_buffer.h\ndiff --git a/src/libcamera/camera_sensor.cpp b/src/libcamera/camera_sensor.cpp\nindex 78c7cee..935de52 100644\n--- a/src/libcamera/camera_sensor.cpp\n+++ b/src/libcamera/camera_sensor.cpp\n@@ -28,7 +28,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(CameraSensor);\n+LOG_DEFINE_CATEGORY(CameraSensor)\n \n /**\n * \\struct CameraSensorInfo\ndiff --git a/src/libcamera/file.cpp b/src/libcamera/file.cpp\nindex 04b0cb6..3a3f5bb 100644\n--- a/src/libcamera/file.cpp\n+++ b/src/libcamera/file.cpp\n@@ -23,7 +23,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(File);\n+LOG_DEFINE_CATEGORY(File)\n \n /**\n * \\class File\ndiff --git a/src/libcamera/pipeline/ipu3/ipu3.cpp b/src/libcamera/pipeline/ipu3/ipu3.cpp\nindex f5a20d3..92c65d0 100644\n--- a/src/libcamera/pipeline/ipu3/ipu3.cpp\n+++ b/src/libcamera/pipeline/ipu3/ipu3.cpp\n@@ -66,7 +66,7 @@ public:\n \n \tStatus validate() override;\n \n-\tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; };\n+\tconst StreamConfiguration &cio2Format() const { return cio2Configuration_; }\n \tconst ImgUDevice::PipeConfig imguConfig() const { return pipeConfig_; }\n \n private:\ndiff --git a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\nindex 0572acc..62605c0 100644\n--- a/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n+++ b/src/libcamera/pipeline/raspberrypi/staggered_ctrl.cpp\n@@ -17,7 +17,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(RPI_S_W);\n+LOG_DEFINE_CATEGORY(RPI_S_W)\n \n namespace RPi {\n \ndiff --git a/src/libcamera/pipeline/simple/converter.cpp b/src/libcamera/pipeline/simple/converter.cpp\nindex 75fb297..b4ee021 100644\n--- a/src/libcamera/pipeline/simple/converter.cpp\n+++ b/src/libcamera/pipeline/simple/converter.cpp\n@@ -21,7 +21,7 @@\n \n namespace libcamera {\n \n-LOG_DECLARE_CATEGORY(SimplePipeline);\n+LOG_DECLARE_CATEGORY(SimplePipeline)\n \n SimpleConverter::SimpleConverter(MediaDevice *media)\n \t: m2m_(nullptr)\ndiff --git a/src/libcamera/sysfs.cpp b/src/libcamera/sysfs.cpp\nindex 6c8e955..3ebe66f 100644\n--- a/src/libcamera/sysfs.cpp\n+++ b/src/libcamera/sysfs.cpp\n@@ -22,7 +22,7 @@\n \n namespace libcamera {\n \n-LOG_DEFINE_CATEGORY(SysFs);\n+LOG_DEFINE_CATEGORY(SysFs)\n \n namespace sysfs {\n \n","prefixes":["libcamera-devel","6/8"]}