{"id":10115,"url":"https://patchwork.libcamera.org/api/1.1/patches/10115/?format=json","web_url":"https://patchwork.libcamera.org/patch/10115/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201020052905.89267-4-hiroh@chromium.org>","date":"2020-10-20T05:29:00","name":"[libcamera-devel,3/8] gstreamer: Omit extra semicolons","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"daab1473d90396858b81eaf7f6e5fc4a0f88d8ed","submitter":{"id":63,"url":"https://patchwork.libcamera.org/api/1.1/people/63/?format=json","name":"Hirokazu Honda","email":"hiroh@chromium.org"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10115/mbox/","series":[{"id":1388,"url":"https://patchwork.libcamera.org/api/1.1/series/1388/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1388","date":"2020-10-20T05:28:58","name":"[libcamera-devel,1/8] test: Omit extra semicolons","version":1,"mbox":"https://patchwork.libcamera.org/series/1388/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10115/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10115/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4F4FDBDB13\n\tfor ;\n\tTue, 20 Oct 2020 05:29:22 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 15A30613C2;\n\tTue, 20 Oct 2020 07:29:22 +0200 (CEST)","from mail-pj1-x1043.google.com (mail-pj1-x1043.google.com\n\t[IPv6:2607:f8b0:4864:20::1043])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 067B6610C4\n\tfor ;\n\tTue, 20 Oct 2020 07:29:21 +0200 (CEST)","by mail-pj1-x1043.google.com with SMTP id gm14so333232pjb.2\n\tfor ;\n\tMon, 19 Oct 2020 22:29:20 -0700 (PDT)","from hiroh.tok.corp.google.com\n\t([2401:fa00:8f:2:de4a:3eff:fe7d:f78f])\n\tby smtp.gmail.com with ESMTPSA id\n\tj4sm779043pfd.101.2020.10.19.22.29.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tMon, 19 Oct 2020 22:29:18 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=chromium.org header.i=@chromium.org\n\theader.b=\"keOmQSX6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org;\n\ts=google; \n\th=from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=F0hBzpfFTq9B1iOi2sSv4UEXrd/PquHYtGw2Pwrw3M4=;\n\tb=keOmQSX6tBUZw7wuxtbgegChtHuKTbOUUsHZffnVkNgE63uj8ppVLBu6cx/2z53HII\n\t3uFavEwB017HrjueHj1dgQCowBxglz1jlCkmGhQR48cJ5aR3DWkdXiwETMzJFFH07hdP\n\tI7PH+xV6qqCaXVV7MClyYjbToSCuAOOnRRAGE=","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references:mime-version:content-transfer-encoding;\n\tbh=F0hBzpfFTq9B1iOi2sSv4UEXrd/PquHYtGw2Pwrw3M4=;\n\tb=cLkNWkBeDbR1XaHBA5jyR3+9JHk7vDREEgrTN3iNZmSVy/0SFNFuLM0UhOj5u+5tgj\n\toLvohnmKLlxvqAV9lG0y0gNDpJvl/cHYrpfWPkD0i6emIv5i4pKUan0MyW1/VpQlCKbK\n\tO2TeL+jwXaA747s/B0FK3JxcX1BhvLlTgTiIccy3ZZsH+YkwvehHgG3ry/pCa+ixDOvc\n\tf5Z0qhwiXQ3t0XeVH7O7hjwSLJ9z2bXCL0eXPalu9GNOZl2JGH7YbJRAgAz/Y5T23uz4\n\t73ppXs8yGL5LgBPHaWWlxjzbjo6KvV2w143AH8R+Kk2+8+rd0ozDKMds2KFJ5/D1Mqwv\n\tgLKQ==","X-Gm-Message-State":"AOAM533ECRTcFhJ5Hcx3Iy3HWWiNjMZ/O+UyI6DRRC5Ckl+8SQdFz0WB\n\tzzxlXXY5G+hwNaxdnqQoGCCQ9B5OXn/U+A==","X-Google-Smtp-Source":"ABdhPJzEDoX3u0zW0bgzujJeE16Kv4pNwBvJpRAo/NnkpX3RDP+ikHob5oszfxub/bJ1184KPDaS9w==","X-Received":"by 2002:a17:902:6508:b029:d3:b362:72b5 with SMTP id\n\tb8-20020a1709026508b02900d3b36272b5mr1250452plk.55.1603171759455; \n\tMon, 19 Oct 2020 22:29:19 -0700 (PDT)","From":"Hirokazu Honda ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 20 Oct 2020 14:29:00 +0900","Message-Id":"<20201020052905.89267-4-hiroh@chromium.org>","X-Mailer":"git-send-email 2.29.0.rc1.297.gfa9743e501-goog","In-Reply-To":"<20201020052905.89267-1-hiroh@chromium.org>","References":"<20201020052905.89267-1-hiroh@chromium.org>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 3/8] gstreamer: Omit extra semicolons","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Macros used in gstreamer (e.g. G_DEFINE_TYPE) is a function. The\nend semicolons with the macros are unnecessary.\n\nSigned-off-by: Hirokazu Honda \n---\n src/gstreamer/gstlibcamera.cpp | 2 +-\n src/gstreamer/gstlibcameraallocator.cpp | 2 +-\n src/gstreamer/gstlibcamerapad.cpp | 2 +-\n src/gstreamer/gstlibcamerapool.cpp | 2 +-\n src/gstreamer/gstlibcameraprovider.cpp | 6 +++---\n src/gstreamer/gstlibcamerasrc.cpp | 2 +-\n 6 files changed, 8 insertions(+), 8 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcamera.cpp b/src/gstreamer/gstlibcamera.cpp\nindex 81c7bb1..52388b5 100644\n--- a/src/gstreamer/gstlibcamera.cpp\n+++ b/src/gstreamer/gstlibcamera.cpp\n@@ -24,4 +24,4 @@ plugin_init(GstPlugin *plugin)\n \n GST_PLUGIN_DEFINE(GST_VERSION_MAJOR, GST_VERSION_MINOR,\n \t\t libcamera, \"libcamera capture plugin\",\n-\t\t plugin_init, VERSION, \"LGPL\", PACKAGE, \"https://libcamera.org\");\n+\t\t plugin_init, VERSION, \"LGPL\", PACKAGE, \"https://libcamera.org\")\ndiff --git a/src/gstreamer/gstlibcameraallocator.cpp b/src/gstreamer/gstlibcameraallocator.cpp\nindex 78ded40..13c6b49 100644\n--- a/src/gstreamer/gstlibcameraallocator.cpp\n+++ b/src/gstreamer/gstlibcameraallocator.cpp\n@@ -101,7 +101,7 @@ struct _GstLibcameraAllocator {\n };\n \n G_DEFINE_TYPE(GstLibcameraAllocator, gst_libcamera_allocator,\n-\t GST_TYPE_DMABUF_ALLOCATOR);\n+\t GST_TYPE_DMABUF_ALLOCATOR)\n \n static gboolean\n gst_libcamera_allocator_release(GstMiniObject *mini_object)\ndiff --git a/src/gstreamer/gstlibcamerapad.cpp b/src/gstreamer/gstlibcamerapad.cpp\nindex 9f3e2be..c00e81c 100644\n--- a/src/gstreamer/gstlibcamerapad.cpp\n+++ b/src/gstreamer/gstlibcamerapad.cpp\n@@ -27,7 +27,7 @@ enum {\n \tPROP_STREAM_ROLE\n };\n \n-G_DEFINE_TYPE(GstLibcameraPad, gst_libcamera_pad, GST_TYPE_PAD);\n+G_DEFINE_TYPE(GstLibcameraPad, gst_libcamera_pad, GST_TYPE_PAD)\n \n static void\n gst_libcamera_pad_set_property(GObject *object, guint prop_id,\ndiff --git a/src/gstreamer/gstlibcamerapool.cpp b/src/gstreamer/gstlibcamerapool.cpp\nindex b756ee3..62db184 100644\n--- a/src/gstreamer/gstlibcamerapool.cpp\n+++ b/src/gstreamer/gstlibcamerapool.cpp\n@@ -29,7 +29,7 @@ struct _GstLibcameraPool {\n \tStream *stream;\n };\n \n-G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL);\n+G_DEFINE_TYPE(GstLibcameraPool, gst_libcamera_pool, GST_TYPE_BUFFER_POOL)\n \n static GstFlowReturn\n gst_libcamera_pool_acquire_buffer(GstBufferPool *pool, GstBuffer **buffer,\ndiff --git a/src/gstreamer/gstlibcameraprovider.cpp b/src/gstreamer/gstlibcameraprovider.cpp\nindex cd850d8..ee44dc7 100644\n--- a/src/gstreamer/gstlibcameraprovider.cpp\n+++ b/src/gstreamer/gstlibcameraprovider.cpp\n@@ -35,14 +35,14 @@ enum {\n \n #define GST_TYPE_LIBCAMERA_DEVICE gst_libcamera_device_get_type()\n G_DECLARE_FINAL_TYPE(GstLibcameraDevice, gst_libcamera_device,\n-\t\t GST_LIBCAMERA, DEVICE, GstDevice);\n+\t\t GST_LIBCAMERA, DEVICE, GstDevice)\n \n struct _GstLibcameraDevice {\n \tGstDevice parent;\n \tgchar *name;\n };\n \n-G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE);\n+G_DEFINE_TYPE(GstLibcameraDevice, gst_libcamera_device, GST_TYPE_DEVICE)\n \n static GstElement *\n gst_libcamera_device_create_element(GstDevice *device, const gchar *name)\n@@ -164,7 +164,7 @@ struct _GstLibcameraProvider {\n G_DEFINE_TYPE_WITH_CODE(GstLibcameraProvider, gst_libcamera_provider,\n \t\t\tGST_TYPE_DEVICE_PROVIDER,\n \t\t\tGST_DEBUG_CATEGORY_INIT(provider_debug, \"libcamera-provider\", 0,\n-\t\t\t\t\t\t\"libcamera Device Provider\"));\n+\t\t\t\t\t\t\"libcamera Device Provider\"))\n \n static GList *\n gst_libcamera_provider_probe(GstDeviceProvider *provider)\ndiff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex 5001083..a099508 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -140,7 +140,7 @@ enum {\n \n G_DEFINE_TYPE_WITH_CODE(GstLibcameraSrc, gst_libcamera_src, GST_TYPE_ELEMENT,\n \t\t\tGST_DEBUG_CATEGORY_INIT(source_debug, \"libcamerasrc\", 0,\n-\t\t\t\t\t\t\"libcamera Source\"));\n+\t\t\t\t\t\t\"libcamera Source\"))\n \n #define TEMPLATE_CAPS GST_STATIC_CAPS(\"video/x-raw; image/jpeg\")\n \n","prefixes":["libcamera-devel","3/8"]}