{"id":10109,"url":"https://patchwork.libcamera.org/api/1.1/patches/10109/?format=json","web_url":"https://patchwork.libcamera.org/patch/10109/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201020014005.12783-4-laurent.pinchart@ideasonboard.com>","date":"2020-10-20T01:40:03","name":"[libcamera-devel,v2,3/5] libcamera: camera_manager: Make CameraManager::Private::mutex_ mutable","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"f08d5d59481903ee07404788963383a4c1dc42d6","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10109/mbox/","series":[{"id":1386,"url":"https://patchwork.libcamera.org/api/1.1/series/1386/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1386","date":"2020-10-20T01:40:00","name":"libcamera: Implement d-pointer design pattern","version":2,"mbox":"https://patchwork.libcamera.org/series/1386/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10109/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10109/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 18C9ABDB1F\n\tfor ;\n\tTue, 20 Oct 2020 01:41:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D60E96052F;\n\tTue, 20 Oct 2020 03:41:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3DD2060CE6\n\tfor ;\n\tTue, 20 Oct 2020 03:40:57 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D5C98309\n\tfor ;\n\tTue, 20 Oct 2020 03:40:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"fcDunE+X\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603158057;\n\tbh=26KzoJx9qWaZkCKCO4gPjO1Iu/nyX45r/CLqOaCLeh0=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=fcDunE+XmyeGbROi9B1R/TPiI+1dt0IlfUt+O3kZ0JJxMlLobFROEfixZMNkVaQgY\n\tYSDEvTizsj1iopqByAB2e5gNf4jWrXQKQj5LkknsiqrE6teTin9wOm50ZXeLt0wmDx\n\tkNOXNjx0elpqqbcANEtDII2tmi8WgLVYh1iZDXmQ=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 20 Oct 2020 04:40:03 +0300","Message-Id":"<20201020014005.12783-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201020014005.12783-1-laurent.pinchart@ideasonboard.com>","References":"<20201020014005.12783-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 3/5] libcamera: camera_manager: Make\n\tCameraManager::Private::mutex_ mutable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"utf-8\"","Content-Transfer-Encoding":"base64","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The mutex_ stored in the CameraManager::Private class is used to protect\nmembers that may need to be accessed from const functions. Make it\nmutable to allow this.\n\nSigned-off-by: Laurent Pinchart \nReviewed-by: Niklas Söderlund \nReviewed-by: Jacopo Mondi \n---\n src/libcamera/camera_manager.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 81785f919d8b..3fef69633028 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -50,7 +50,7 @@ public:\n \t * - initialized_ and status_ during initialization\n \t * - cameras_ and camerasByDevnum_ after initialization\n \t */\n-\tMutex mutex_;\n+\tmutable Mutex mutex_;\n \tstd::vector> cameras_;\n \tstd::map> camerasByDevnum_;\n \n","prefixes":["libcamera-devel","v2","3/5"]}