{"id":10105,"url":"https://patchwork.libcamera.org/api/1.1/patches/10105/?format=json","web_url":"https://patchwork.libcamera.org/patch/10105/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201020000310.3008-6-laurent.pinchart@ideasonboard.com>","date":"2020-10-20T00:03:10","name":"[libcamera-devel,5/5] libcamera: Document the libcamera namespace","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"9295ebd986073d70f5b9a8993399f56d4dc95824","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10105/mbox/","series":[{"id":1385,"url":"https://patchwork.libcamera.org/api/1.1/series/1385/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1385","date":"2020-10-20T00:03:05","name":"libcamera: Miscellaneous documentation fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/1385/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10105/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10105/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 764EDBDB20\n\tfor ;\n\tTue, 20 Oct 2020 00:04:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 40F10613C7;\n\tTue, 20 Oct 2020 02:04:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0ED7661373\n\tfor ;\n\tTue, 20 Oct 2020 02:04:07 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8AD8A93\n\tfor ;\n\tTue, 20 Oct 2020 02:04:06 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lKAomt5f\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603152246;\n\tbh=FTzyW4EaAvKsmKJ2HO7vLBvMq0yeOnloqOmNhNq/ETI=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=lKAomt5fycyMFc9OePEDbEHAk3GgovBbQz73KvFl+9mbIEXeHlXJ0+sQP4aNP9hsS\n\t2d7mMr8QqRxgMUOqVktaSdQEcWDRAkQT7/E8OxwCIlWR45jcAfN0P/vkDFcsqZZ85D\n\tEA5FVhIBpLkRJZ6lG3NcHby/ePjA7Z8jCfRMotp8=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 20 Oct 2020 03:03:10 +0300","Message-Id":"<20201020000310.3008-6-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>","References":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 5/5] libcamera: Document the libcamera\n\tnamespace","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The libcamera namespace has been left undefined from the start. While\nthe documentation doesn't bring much added value, leaving it out\nconfuses the most recent doxygen master branch:\n\ninclude/libcamera/transform.h:16: warning: Internal inconsistency: member Identity does not belong to any container!\ninclude/libcamera/transform.h:17: warning: Internal inconsistency: member Rot0 does not belong to any container!\ninclude/libcamera/transform.h:18: warning: Internal inconsistency: member HFlip does not belong to any container!\ninclude/libcamera/transform.h:19: warning: Internal inconsistency: member VFlip does not belong to any container!\ninclude/libcamera/transform.h:20: warning: Internal inconsistency: member HVFlip does not belong to any container!\ninclude/libcamera/transform.h:21: warning: Internal inconsistency: member Rot180 does not belong to any container!\ninclude/libcamera/transform.h:22: warning: Internal inconsistency: member Transpose does not belong to any container!\ninclude/libcamera/transform.h:23: warning: Internal inconsistency: member Rot270 does not belong to any container!\ninclude/libcamera/transform.h:24: warning: Internal inconsistency: member Rot90 does not belong to any container!\ninclude/libcamera/transform.h:26: warning: Internal inconsistency: member Rot180Transpose does not belong to any container!\n\nDocument it.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/camera_manager.cpp | 3 +++\n 1 file changed, 3 insertions(+)","diff":"diff --git a/src/libcamera/camera_manager.cpp b/src/libcamera/camera_manager.cpp\nindex 756f5b2b4a03..81785f919d8b 100644\n--- a/src/libcamera/camera_manager.cpp\n+++ b/src/libcamera/camera_manager.cpp\n@@ -27,6 +27,9 @@\n * \\brief The camera manager\n */\n \n+/**\n+ * \\brief Top-level libcamera namespace\n+ */\n namespace libcamera {\n \n LOG_DEFINE_CATEGORY(Camera)\n","prefixes":["libcamera-devel","5/5"]}