{"id":10103,"url":"https://patchwork.libcamera.org/api/1.1/patches/10103/?format=json","web_url":"https://patchwork.libcamera.org/patch/10103/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201020000310.3008-4-laurent.pinchart@ideasonboard.com>","date":"2020-10-20T00:03:08","name":"[libcamera-devel,3/5] libcamera: Place doxygen \\file block above namespace","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"3bfecf85e1e9f6a4419bf0e3135d92c9605bc7b9","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/1.1/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":{"id":14,"url":"https://patchwork.libcamera.org/api/1.1/users/14/?format=json","username":"pinchartl","first_name":"Laurent","last_name":"Pinchart","email":"laurent.pinchart@ideasonboard.com"},"mbox":"https://patchwork.libcamera.org/patch/10103/mbox/","series":[{"id":1385,"url":"https://patchwork.libcamera.org/api/1.1/series/1385/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1385","date":"2020-10-20T00:03:05","name":"libcamera: Miscellaneous documentation fixes","version":1,"mbox":"https://patchwork.libcamera.org/series/1385/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10103/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10103/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE00BBDB1F\n\tfor ;\n\tTue, 20 Oct 2020 00:04:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 89C96613CA;\n\tTue, 20 Oct 2020 02:04:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4FFFB613BB\n\tfor ;\n\tTue, 20 Oct 2020 02:04:06 +0200 (CEST)","from pendragon.lan (62-78-145-57.bb.dnainternet.fi [62.78.145.57])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DFB9693\n\tfor ;\n\tTue, 20 Oct 2020 02:04:05 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"YmlK6plK\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1603152246;\n\tbh=8BoDIcM4DjyFZqdU4i+gFFnrw+luwGPktI/qKe4uiKw=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=YmlK6plKpv1FpZmeJNvrLzRgaYw3fKD1uleBf0WspKkVFqZa20F1Sz0D6uNpqo/u0\n\tKp52T7LEos2tfrt7vHaIcNOo6q5fri5L8LR7dwJtgxggLzj/Dmp4h4C5x1zCllJGnT\n\ttHZYBulBHKZR+8KC1mM/KzJIltEA6yOC4F6eKbmA=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Date":"Tue, 20 Oct 2020 03:03:08 +0300","Message-Id":"<20201020000310.3008-4-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.27.0","In-Reply-To":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>","References":"<20201020000310.3008-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 3/5] libcamera: Place doxygen \\file block\n\tabove namespace","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Make the whole code base consistent by placing the doxygen \\file block\nabove the libcamera namespace opening. There's a single offender, and\ntwo locations in which a white line is missing.\n\nSigned-off-by: Laurent Pinchart \n---\n src/libcamera/byte_stream_buffer.cpp | 8 ++++----\n src/libcamera/v4l2_pixelformat.cpp | 1 +\n src/libcamera/v4l2_videodevice.cpp | 1 +\n 3 files changed, 6 insertions(+), 4 deletions(-)","diff":"diff --git a/src/libcamera/byte_stream_buffer.cpp b/src/libcamera/byte_stream_buffer.cpp\nindex df7029b02a7f..eb9003927266 100644\n--- a/src/libcamera/byte_stream_buffer.cpp\n+++ b/src/libcamera/byte_stream_buffer.cpp\n@@ -12,15 +12,15 @@\n \n #include \"libcamera/internal/log.h\"\n \n-namespace libcamera {\n-\n-LOG_DEFINE_CATEGORY(Serialization);\n-\n /**\n * \\file byte_stream_buffer.h\n * \\brief Managed memory container for serialized data\n */\n \n+namespace libcamera {\n+\n+LOG_DEFINE_CATEGORY(Serialization);\n+\n /**\n * \\class ByteStreamBuffer\n * \\brief Wrap a memory buffer and provide sequential data read and write\ndiff --git a/src/libcamera/v4l2_pixelformat.cpp b/src/libcamera/v4l2_pixelformat.cpp\nindex 6b05909f56ae..03ab085c1231 100644\n--- a/src/libcamera/v4l2_pixelformat.cpp\n+++ b/src/libcamera/v4l2_pixelformat.cpp\n@@ -22,6 +22,7 @@\n * \\file v4l2_pixelformat.h\n * \\brief V4L2 Pixel Format\n */\n+\n namespace libcamera {\n \n LOG_DECLARE_CATEGORY(V4L2)\ndiff --git a/src/libcamera/v4l2_videodevice.cpp b/src/libcamera/v4l2_videodevice.cpp\nindex 508522ef42bb..16162e1edba3 100644\n--- a/src/libcamera/v4l2_videodevice.cpp\n+++ b/src/libcamera/v4l2_videodevice.cpp\n@@ -32,6 +32,7 @@\n * \\file v4l2_videodevice.h\n * \\brief V4L2 Video Device\n */\n+\n namespace libcamera {\n \n LOG_DECLARE_CATEGORY(V4L2)\n","prefixes":["libcamera-devel","3/5"]}