{"id":10014,"url":"https://patchwork.libcamera.org/api/1.1/patches/10014/?format=json","web_url":"https://patchwork.libcamera.org/patch/10014/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201007131812.2688973-2-tomi.valkeinen@iki.fi>","date":"2020-10-07T13:18:10","name":"[libcamera-devel,v2,1/3] ipa: raspberrypi: fix bin_x calculation","commit_ref":null,"pull_url":null,"state":"accepted","archived":false,"hash":"a0ce669b546747de18011f3755b917f8f794b34d","submitter":{"id":70,"url":"https://patchwork.libcamera.org/api/1.1/people/70/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@iki.fi"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10014/mbox/","series":[{"id":1364,"url":"https://patchwork.libcamera.org/api/1.1/series/1364/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1364","date":"2020-10-07T13:18:09","name":"ipa: raspberrypi: fix uninit variables","version":2,"mbox":"https://patchwork.libcamera.org/series/1364/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10014/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10014/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 84028BEEE0\n\tfor ;\n\tWed, 7 Oct 2020 13:18:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 520F8605BF;\n\tWed, 7 Oct 2020 15:18:29 +0200 (CEST)","from mail-lj1-x241.google.com (mail-lj1-x241.google.com\n\t[IPv6:2a00:1450:4864:20::241])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B593E605BB\n\tfor ;\n\tWed, 7 Oct 2020 15:18:27 +0200 (CEST)","by mail-lj1-x241.google.com with SMTP id r24so1945906ljm.3\n\tfor ;\n\tWed, 07 Oct 2020 06:18:27 -0700 (PDT)","from deskari.lan (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\ti139sm329539lfi.276.2020.10.07.06.18.26\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Oct 2020 06:18:26 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"Ge7RcPdq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=VjW3v+iYoAihvSHm5zPVY+BTaBGIbTXNOxQerJAtna0=;\n\tb=Ge7RcPdqm+NRes6TIn/8NVmumQ0A4lduEkXg7n4fb+mIN+GYxH04b5ksCev0HMorqg\n\te6m/kHu+xgfSdgYsctvJhZpV/92J2TMz1OIzLmoFIZY4He44Rcu8SX/jA6EKpvqhAY2Q\n\tG/06dmXqCz41VOR4HhCS4yFOF2/GK2ewmhcrWOJaMyNCXyaDbX9GFJFrvvN5eGB9v9Zx\n\t9cQWnT1WMr/v8qRGA9NHIdocXDGdN1WWU8OUekmz3OjSMAzIH7nIUht3LgZyAi5LVswZ\n\tzyU+VmVNnCbQx5eOJYn2Y1o4tR+2vVKCAtriQWDubbz5hcy0jZAdMTFWFPmIqUdchjS+\n\tVsiQ==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=VjW3v+iYoAihvSHm5zPVY+BTaBGIbTXNOxQerJAtna0=;\n\tb=Ur/4kPWwcWtoOPEkGlLrF3AKvAR4T/ieIAerln3VBU4tkqIYj8rjq8idpttbW7Yu98\n\tE09FC4QZmLNzG3CvqQXmUrZFDp3Im2U6WSIpIwOd8YzcOvDfRbXzknPJkkG5TFsNF9ZY\n\tpbQkvqsAkr1QWHiyiqS+Zr2OlOPdXEned5MRav3TAJAmiZSVAwSDaHDV0I5eYZFqDDGq\n\trNt8vV2QrsiBopdN9QTQc1fwDx7SDNxcU/T7ponsirfBuwzoaLLeVJrkKW2mdod/15Ya\n\tMmnrZqh76Rz1A7UmX5Qut/0ZXBM4XpBvEcglBnC6ygYZollGgPrc3pTRI/v6EOFtSRYG\n\tjZYQ==","X-Gm-Message-State":"AOAM533ppHzBq2DbqreVGyMY4nKGjFrJzw3reNHMOCAiAezWiHc43kFB\n\tpReVXdZDQ1Ck6MkR6iAircaFEKqUsly3nqDt","X-Google-Smtp-Source":"ABdhPJxGr+vaGduO5nAz5Qz8mvo0SN6JUGsux2A3GvteXuP8w+UhjjhVw/57nCeFoGOibsYfavAEdw==","X-Received":"by 2002:a2e:9118:: with SMTP id\n\tm24mr1291571ljg.364.1602076707056; \n\tWed, 07 Oct 2020 06:18:27 -0700 (PDT)","From":"Tomi Valkeinen ","To":"libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck ,\n\tDavid Plowman ","Date":"Wed, 7 Oct 2020 16:18:10 +0300","Message-Id":"<20201007131812.2688973-2-tomi.valkeinen@iki.fi>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201007131812.2688973-1-tomi.valkeinen@iki.fi>","References":"<20201007131812.2688973-1-tomi.valkeinen@iki.fi>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH v2 1/3] ipa: raspberrypi: fix bin_x\n\tcalculation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Tomi Valkeinen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"I presume this code is supposed to set bin_x and bin_y, and not bin_y\ntwo times. This caused use of uninitialized variable later when bin_x\nwas used.\n\nSigned-off-by: Tomi Valkeinen \nReviewed-by: Kieran Bingham \nReviewed-by: David Plowman \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex b0c7d1c..48a72dd 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -178,7 +178,7 @@ void IPARPi::setMode(const CameraSensorInfo &sensorInfo)\n \t *\n \t * \\todo Get the pipeline handle to provide the full data\n \t */\n-\tmode_.bin_y = std::min(2, static_cast(mode_.scale_x));\n+\tmode_.bin_x = std::min(2, static_cast(mode_.scale_x));\n \tmode_.bin_y = std::min(2, static_cast(mode_.scale_y));\n \n \t/* The noise factor is the square root of the total binning factor. */\n","prefixes":["libcamera-devel","v2","1/3"]}