{"id":10007,"url":"https://patchwork.libcamera.org/api/1.1/patches/10007/?format=json","web_url":"https://patchwork.libcamera.org/patch/10007/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/1.1/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20201007110743.55561-2-tomi.valkeinen@iki.fi>","date":"2020-10-07T11:07:40","name":"[libcamera-devel,1/4] ipa: raspberrypi: fix bin_x calculation","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"a0ce669b546747de18011f3755b917f8f794b34d","submitter":{"id":70,"url":"https://patchwork.libcamera.org/api/1.1/people/70/?format=json","name":"Tomi Valkeinen","email":"tomi.valkeinen@iki.fi"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/10007/mbox/","series":[{"id":1362,"url":"https://patchwork.libcamera.org/api/1.1/series/1362/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=1362","date":"2020-10-07T11:07:39","name":"ipa: raspberrypi: fix uninit variables","version":1,"mbox":"https://patchwork.libcamera.org/series/1362/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/10007/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/10007/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BCB8FBEEE0\n\tfor ;\n\tWed, 7 Oct 2020 11:08:07 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 69BAA6059B;\n\tWed, 7 Oct 2020 13:08:07 +0200 (CEST)","from mail-lf1-x144.google.com (mail-lf1-x144.google.com\n\t[IPv6:2a00:1450:4864:20::144])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DF05860553\n\tfor ;\n\tWed, 7 Oct 2020 13:08:05 +0200 (CEST)","by mail-lf1-x144.google.com with SMTP id g2so1781958lfr.10\n\tfor ;\n\tWed, 07 Oct 2020 04:08:05 -0700 (PDT)","from deskari.lan (91-152-83-50.elisa-laajakaista.fi.\n\t[91.152.83.50]) by smtp.gmail.com with ESMTPSA id\n\tx14sm287445lfc.93.2020.10.07.04.08.04\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 07 Oct 2020 04:08:04 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com;\n\tdkim=fail reason=\"signature verification failed\" (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"s/T/f+Lv\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;\n\th=sender:from:to:cc:subject:date:message-id:in-reply-to:references\n\t:mime-version:content-transfer-encoding;\n\tbh=HeRPwF3rcso5VQ08mkHRzIs5kjhxqwAHvyl3LAyXSRY=;\n\tb=s/T/f+LvN3jvuzLSLUQDsbTnK/0XyB176RzRLmN0I5kdWKQWvGP8VPTSjU3h7jnd9A\n\tqsagX4X2800ROyRkHbGKMkAZQse8RSbruXfsNNNa1VKEm2iGGYbyGYtP6+qOzrvx6/7L\n\ttSEkORnx2aUl87OvXAOBN8rIGuSyO7BepkuTtuf6dbgKN2rCAIAXvjg8KqyW4FstzPF7\n\tYo/pKjBQDL6HZ+qOtkvgmOuSBiSXlEWqeWJCbK4O6FzzVIzw+aFDt1QLRiQm7CQ/m8DZ\n\tlg4QESGhzmTZbza4dINb4u8SPZV/LZrjxjGrSrjeJPI0MFAYqaA7d9qeksDe8sdQqlGn\n\tDCkw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:sender:from:to:cc:subject:date:message-id\n\t:in-reply-to:references:mime-version:content-transfer-encoding;\n\tbh=HeRPwF3rcso5VQ08mkHRzIs5kjhxqwAHvyl3LAyXSRY=;\n\tb=Cz75T/rK4WgbL1DBdV5wL3Gq9190deH7e4DASFrLojHYQ/uJx4EDXPPYIv6JeE+RSS\n\ts7I1Lpn+aUFg+VVBiNENFKN2m1m4r7gDkk913ihiD6iZYwwdpvRZKKwjou2y52EXjHbo\n\tddt/Egb7LetWn4bav6FABh04wU/sJLPIGtpRhfkTo4URloA9lBJHoVvNHgOncB6YsK63\n\tXMOwquVXTbNKOo5GsGLX4yuAGyr4cYRqvg2KW0k10ytRtvm21h+0RG3C/nZVZU5ATucs\n\tsB4NeYQmXSPqBvLCbDO6VWUP3mysZyp17Xa/Iapr5Giy9S50tfTxW7IYHCWLXlhEhz1O\n\tD4Qg==","X-Gm-Message-State":"AOAM530XByGvJEH3vBKj9pKI+GD1TeqCQs0T1RvvFWUIa/km5nFkW7UW\n\tjBBjMPWMvQofPOiJZ7S0slfRAZEBmXGfnA==","X-Google-Smtp-Source":"ABdhPJzBxipH9h+0641ISu+xH8zaiUJaYh3E2DKFIYeUzDvEu7B81OMkr92zwf6oCJq4ANKj2/oAeg==","X-Received":"by 2002:ac2:5e9b:: with SMTP id b27mr720220lfq.312.1602068885107;\n\tWed, 07 Oct 2020 04:08:05 -0700 (PDT)","From":"Tomi Valkeinen ","To":"libcamera-devel@lists.libcamera.org,\n\tNaushir Patuck ,\n\tDavid Plowman ","Date":"Wed, 7 Oct 2020 14:07:40 +0300","Message-Id":"<20201007110743.55561-2-tomi.valkeinen@iki.fi>","X-Mailer":"git-send-email 2.25.1","In-Reply-To":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>","References":"<20201007110743.55561-1-tomi.valkeinen@iki.fi>","MIME-Version":"1.0","Subject":"[libcamera-devel] [PATCH 1/4] ipa: raspberrypi: fix bin_x\n\tcalculation","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Cc":"Tomi Valkeinen ","Content-Type":"text/plain; charset=\"us-ascii\"","Content-Transfer-Encoding":"7bit","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"I presume this code is supposed to set bin_x and bin_y, and not bin_y\ntwo times. This caused use of uninitialized variable later when bin_x\nwas used.\n\nSigned-off-by: Tomi Valkeinen \n---\n src/ipa/raspberrypi/raspberrypi.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/raspberrypi/raspberrypi.cpp b/src/ipa/raspberrypi/raspberrypi.cpp\nindex b0c7d1c..48a72dd 100644\n--- a/src/ipa/raspberrypi/raspberrypi.cpp\n+++ b/src/ipa/raspberrypi/raspberrypi.cpp\n@@ -178,7 +178,7 @@ void IPARPi::setMode(const CameraSensorInfo &sensorInfo)\n \t *\n \t * \\todo Get the pipeline handle to provide the full data\n \t */\n-\tmode_.bin_y = std::min(2, static_cast(mode_.scale_x));\n+\tmode_.bin_x = std::min(2, static_cast(mode_.scale_x));\n \tmode_.bin_y = std::min(2, static_cast(mode_.scale_y));\n \n \t/* The noise factor is the square root of the total binning factor. */\n","prefixes":["libcamera-devel","1/4"]}